From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 84603 invoked by alias); 11 Dec 2017 13:04:02 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 84581 invoked by uid 89); 11 Dec 2017 13:04:01 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-25.3 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mail-qt0-f178.google.com Received: from mail-qt0-f178.google.com (HELO mail-qt0-f178.google.com) (209.85.216.178) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 11 Dec 2017 13:03:51 +0000 Received: by mail-qt0-f178.google.com with SMTP id m59so38098943qte.11 for ; Mon, 11 Dec 2017 05:03:51 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=rV4hMsxOQRk83B/WKyaogKgpMO2D6dfoqgewr20GLr0=; b=cpmeDVHFV7CeMvdkKs55YDhMp2eWVVv3tMqKM3KrX1yvHqi7atXjXIKE2TOzTi3JRQ j9yb/mKHHvj0AmVFmzE1yxnAgEOS7ACZRsQ3WRwzfX5gQhbk1QsVo+znAEcfUTCldLES opj9pRfKAz9jU8rdSSd1K7yUF62YS06u9h3hHXe7warEsZ9LT9qQrdiJKaEOV4tCzFmw SFPjEupGkkca1G+tAC9ADf+uLAPCR1xDzysuR5gqngc8cuIs8yO7cUHiKgR+bCH1aiSn mCWOxAsEyQEdthWGN885eNz/0OmHBLh7Zko7lWMIIuJntgomGG3Y+Bmc3D87Wj6LKGZ0 cjGg== X-Gm-Message-State: AKGB3mKxLPxLuRmKRpENUeEic0PfTtvVK/5BNK7W0QIV3rcYrQ+WpBtx Hcq+Ks0I5k26kh73lzhoAIeSJbTEMptwJFfXSAA= X-Google-Smtp-Source: ACJfBosD/vVn9GeUEaOn48AicQegi7sSA/P796OaAYaNbQAotTTNgPUO6eaGPneYdF+RAf0L01c/2lo1zfxgmjbpPQ8= X-Received: by 10.200.50.39 with SMTP id x36mr410302qta.255.1512997430036; Mon, 11 Dec 2017 05:03:50 -0800 (PST) MIME-Version: 1.0 Received: by 10.12.132.161 with HTTP; Mon, 11 Dec 2017 05:03:49 -0800 (PST) In-Reply-To: <83d5d4a6-a137-b680-1af0-33b895bd817d@redhat.com> References: <149790572259.20186.14601775821404892582.stgit@host1.jankratochvil.net> <149790575186.20186.4091613230201630619.stgit@host1.jankratochvil.net> <83d5d4a6-a137-b680-1af0-33b895bd817d@redhat.com> From: Yao Qi Date: Mon, 11 Dec 2017 13:04:00 -0000 Message-ID: Subject: Re: [PATCH v3 3/5] Code cleanup: dwarf2_initialize_objfile return value To: Pedro Alves Cc: Jan Kratochvil , GDB Patches , Victor Leschuk Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2017-12/txt/msg00229.txt.bz2 On Fri, Dec 8, 2017 at 11:52 PM, Pedro Alves wrote: > diff --git a/gdb/dwarf2read.c b/gdb/dwarf2read.c > index a9daf1f..798af72 100644 > --- a/gdb/dwarf2read.c > +++ b/gdb/dwarf2read.c > @@ -5291,7 +5291,7 @@ const struct quick_symbol_functions dwarf2_gdb_inde= x_functions =3D > /* Initialize for reading DWARF for this objfile. Return 0 if this > file will use psymtabs, or 1 if using the GNU index. */ > > -int > +const sym_fns & > dwarf2_initialize_objfile (struct objfile *objfile) > { > /* If we're about to read full symbols, don't bother with the > @@ -5320,13 +5320,13 @@ dwarf2_initialize_objfile (struct objfile *objfil= e) > /* Return 1 so that gdb sees the "quick" functions. However, > these functions will be no-ops because we will have expanded > all symtabs. */ > - return 1; > + return elf_sym_fns_gdb_index; > } > > if (dwarf2_read_index (objfile)) > - return 1; > + return elf_sym_fns_gdb_index; > > - return 0; > + return elf_sym_fns_lazy_psyms; > } > This breaks the arm-wince-pe build, dwarf2read.o: In function `dwarf2_initialize_objfile(objfile*)': /home/yao.qi/SourceCode/gnu/binutils-gdb/gdb/dwarf2read.c:6486: undefined reference to `elf_sym_fns_gdb_index' /home/yao.qi/SourceCode/gnu/binutils-gdb/gdb/dwarf2read.c:6490: undefined reference to `elf_sym_fns_debug_names' /home/yao.qi/SourceCode/gnu/binutils-gdb/gdb/dwarf2read.c:6495: undefined reference to `elf_sym_fns_lazy_psyms' collect2: error: ld returned 1 exit status Makefile:1920: recipe for target 'gdb' failed https://ci.linaro.org/job/tcwg-binutils/4395/ --=20 Yao (=E9=BD=90=E5=B0=A7)