From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4644 invoked by alias); 5 Feb 2018 08:34:12 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 4633 invoked by uid 89); 5 Feb 2018 08:34:11 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=no version=3.3.2 spammy=HX-Received:Mon X-HELO: mail-lf0-f42.google.com Received: from mail-lf0-f42.google.com (HELO mail-lf0-f42.google.com) (209.85.215.42) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 05 Feb 2018 08:34:10 +0000 Received: by mail-lf0-f42.google.com with SMTP id h92so40501614lfi.7 for ; Mon, 05 Feb 2018 00:34:09 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=fjHzW1Lsuhzj2wZUh7gMVuog28PoSJul13kGO7n1UY0=; b=rFnWsCROtRSvBnbH2hOGp0PH0rcEhKYlE9CNqbfj6PpuCiHVS/GIi8vQZEYBeWLWN2 ddbE4qJ8IJnDSWktglsXviQjyfHxMXh1987XYAjVnmnh3VZbP6jiJPerrs+AchAaGznA vAFyV1PLaQEa+NIDRUWdm086fT0lZiLf8ytiOo/4zD36GERd+A/yCp/WsH+XrnSrrU7X 6XAxEK2ZwZfueSg35mv+CeweakHXFzp9E1z5V9dXOfDuyjz4BDpgOCNfHWfFKLqKjRem w94GTHS0ywypwbzHdRYJ2gEtKLXNI01k60wGpIzBCWPufLdS1jv334AYHTfdOC76wgus 1j1g== X-Gm-Message-State: AKwxytfXLZ3wkebizXfgLallAdZpj5snU8B6NRotWBAZj/MPGeDRba9i TCDxKAx5I+KeThIUbnwcH1RB84Prc5SOwQ2Lk1dVkQ== X-Google-Smtp-Source: AH8x227YDKDLZ3stLIjoNctdJesdA7KvVQ/UXAK3K4gbjHQ60w0tUtlUZs4YAa8FnLwkbD4QUb65zziSOW/pICR6cqM= X-Received: by 10.25.16.3 with SMTP id f3mr28451438lfi.98.1517819647823; Mon, 05 Feb 2018 00:34:07 -0800 (PST) MIME-Version: 1.0 Received: by 10.25.216.93 with HTTP; Mon, 5 Feb 2018 00:34:07 -0800 (PST) In-Reply-To: <476b9768-30b7-73ce-ec5b-a19c7656019d@simark.ca> References: <1517658143-946-1-git-send-email-b7.10110111@gmail.com> <476b9768-30b7-73ce-ec5b-a19c7656019d@simark.ca> From: Ruslan Kabatsayev Date: Mon, 05 Feb 2018 08:34:00 -0000 Message-ID: Subject: Re: [PATCH v4] Align natural-format register values to the same column To: Simon Marchi Cc: gdb-patches@sourceware.org Content-Type: text/plain; charset="UTF-8" X-IsSubscribed: yes X-SW-Source: 2018-02/txt/msg00060.txt.bz2 On 5 February 2018 at 00:59, Simon Marchi wrote: > On 2018-02-03 06:42 AM, Ruslan Kabatsayev wrote: >> Currently, commands such as "info reg", "info all-reg", as well as register >> window in the TUI print badly aligned columns, like here: >> >> eax 0x1 1 >> ecx 0xffffd3e0 -11296 >> edx 0xffffd404 -11260 >> ebx 0xf7fa5ff4 -134586380 >> esp 0xffffd390 0xffffd390 >> ebp 0xffffd3c8 0xffffd3c8 >> esi 0x0 0 >> edi 0x0 0 >> eip 0x8048b60 0x8048b60 >> eflags 0x286 [ PF SF IF ] >> cs 0x23 35 >> ss 0x2b 43 >> ds 0x2b 43 >> es 0x2b 43 >> fs 0x0 0 >> gs 0x63 99 >> >> After this patch, these commands print the third column values consistently >> aligned one under another, provided the second column is not too long. >> Originally, the third column was (attempted to be) aligned using a simple tab >> character. This patch changes the alignment to spaces only. The tests checking >> the output and expecting the single tab have been fixed in a previous patch, so >> this change doesn't break any. > > Thanks, this version LGTM, please push. Pushed. > > Simon