From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16006 invoked by alias); 26 Aug 2014 20:31:51 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 15997 invoked by uid 89); 26 Aug 2014 20:31:51 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-oi0-f52.google.com Received: from mail-oi0-f52.google.com (HELO mail-oi0-f52.google.com) (209.85.218.52) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Tue, 26 Aug 2014 20:31:49 +0000 Received: by mail-oi0-f52.google.com with SMTP id g201so2176651oib.11 for ; Tue, 26 Aug 2014 13:31:47 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=71h6IVGA0daYUBbotzvIbO4zOuxPLHpS0/l6HrLkP1Q=; b=QH4bBmf830/oTSc7wuEpisTZVpZvhNjoP005kzNpio45kN9m9cLD6kZ+rd0jk9y3WS mUmNL4fRYt1FLoVGQ+ByjEIU6z0QcxLSn5zuCt8HdP9fz1k2zupnzsKjmTZU3Wxzqyv+ Dc4w0NKJ4udkhNDPZHBiiZau6c0lh4DItAEltKJ3cNX+rSrU1SOqlzAVtjpd0uHY81Zo 6wJZMnW+xwrY7uFBK9Ggq8YnRT8bcLxslrMReZOrKxPMABQxK2fyp6unDvXWZo3PhkDw Ldgw9rr11jOe++P5AMK9HpFg5ikLm/5UJAA+BnG9SeU/75QXQNJ7RT3G//FXJ+RmtEd+ mSIw== X-Gm-Message-State: ALoCoQmZrzC8j8VAG/dsd/IWTiRO38/dV8fvoPXqaGjfoO/AFlPdJAOwNqEpX2/8PUYpsrW/Q56o MIME-Version: 1.0 X-Received: by 10.182.236.225 with SMTP id ux1mr15872137obc.57.1409085107332; Tue, 26 Aug 2014 13:31:47 -0700 (PDT) Received: by 10.182.84.169 with HTTP; Tue, 26 Aug 2014 13:31:47 -0700 (PDT) In-Reply-To: <21494.15883.93664.480097@ruffy2.mtv.corp.google.com> References: <83oay128ca.fsf@gnu.org> <87ioo7uuqm.fsf@fleche.redhat.com> <21494.15883.93664.480097@ruffy2.mtv.corp.google.com> Date: Tue, 26 Aug 2014 20:31:00 -0000 Message-ID: Subject: Re: [PATCH] Add Frame.read_register to Python API From: Alexander Smundak To: Doug Evans Cc: gdb-patches Content-Type: multipart/mixed; boundary=001a11c2fad0481f5905018e316d X-SW-Source: 2014-08/txt/msg00533.txt.bz2 --001a11c2fad0481f5905018e316d Content-Type: text/plain; charset=UTF-8 Content-length: 529 I've fixed the problems you pointed out, please take another look. Sasha The ability to read registers is needed to use Frame Filter API to display the frames created by JIT compilers. gdb/Changelog 2014-08-26 Sasha Smundak * python/py-frame.c (frapy_read_register): New function. 2014-08-26 Sasha Smundak * python.texi (Frames in Python): Add read_register description. 2014-08-26 Sasha Smundak * gdb.python/py-frame.exp: Test Frame.read_register. --001a11c2fad0481f5905018e316d Content-Type: text/plain; charset=US-ASCII; name="frame-read-register-patch-4.txt" Content-Disposition: attachment; filename="frame-read-register-patch-4.txt" Content-Transfer-Encoding: base64 X-Attachment-Id: f_hzbov0dv0 Content-length: 5755 ZGlmZiAtLWdpdCBhL2dkYi9ORVdTIGIvZ2RiL05FV1MKaW5kZXggZDYwM2Nm Ny4uNDZjNmE4NyAxMDA2NDQKLS0tIGEvZ2RiL05FV1MKKysrIGIvZ2RiL05F V1MKQEAgLTMsNiArMyw5IEBACiAKICoqKiBDaGFuZ2VzIHNpbmNlIEdEQiA3 LjgKIAorKiBQeXRob24gU2NyaXB0aW5nCisgIFlvdSBjYW4gbm93IGFjY2Vz cyBmcmFtZSByZWdpc3RlcnMgZnJvbSBQeXRob24gc2NyaXB0cy4KKwogKiBP biByZXN1bWUsIEdEQiBub3cgYWx3YXlzIHBhc3NlcyB0aGUgc2lnbmFsIHRo ZSBwcm9ncmFtIGhhZCBzdG9wcGVkCiAgIGZvciB0byB0aGUgdGhyZWFkIHRo ZSBzaWduYWwgd2FzIHNlbnQgdG8sIGV2ZW4gaWYgdGhlIHVzZXIgY2hhbmdl ZAogICB0aHJlYWRzIGJlZm9yZSByZXN1bWluZy4gIFByZXZpb3VzbHkgR0RC IHdvdWxkIG9mdGVuIChidXQgbm90CmRpZmYgLS1naXQgYS9nZGIvZG9jL3B5 dGhvbi50ZXhpIGIvZ2RiL2RvYy9weXRob24udGV4aQppbmRleCA0Njg4Nzgz Li4zY2I2YmY4IDEwMDY0NAotLS0gYS9nZGIvZG9jL3B5dGhvbi50ZXhpCisr KyBiL2dkYi9kb2MvcHl0aG9uLnRleGkKQEAgLTM1ODksNiArMzU4OSwxMyBA QCBSZXR1cm4gdGhlIGZyYW1lJ3Mgc3ltdGFiIGFuZCBsaW5lIG9iamVjdC4K IEB4cmVme1N5bWJvbCBUYWJsZXMgSW4gUHl0aG9ufS4KIEBlbmQgZGVmdW4K IAorQGRlZnVuIEZyYW1lLnJlYWRfcmVnaXN0ZXIgKHJlZ2lzdGVyKQorUmV0 dXJuIHRoZSB2YWx1ZSBvZiBAdmFye3JlZ2lzdGVyfSBpbiB0aGlzIGZyYW1l LiAgVGhlIEB2YXJ7cmVnaXN0ZXJ9Cithcmd1bWVudCBtdXN0IGJlIGEgc3Ry aW5nIChlLmcuLCBAY29kZXsnc3AnfSBvciBAY29kZXsncmF4J30pLgorUmV0 dXJucyBhIEBjb2Rle0dkYi5WYWx1ZX0gb2JqZWN0LiAgVGhyb3dzIGFuIGV4 Y2VwdGlvbiBpZiBAdmFye3JlZ2lzdGVyfQorZG9lcyBub3QgZXhpc3QuCitA ZW5kIGRlZnVuCisKIEBkZWZ1biBGcmFtZS5yZWFkX3ZhciAodmFyaWFibGUg QHJ7W30sIGJsb2NrQHJ7XX0pCiBSZXR1cm4gdGhlIHZhbHVlIG9mIEB2YXJ7 dmFyaWFibGV9IGluIHRoaXMgZnJhbWUuICBJZiB0aGUgb3B0aW9uYWwKIGFy Z3VtZW50IEB2YXJ7YmxvY2t9IGlzIHByb3ZpZGVkLCBzZWFyY2ggZm9yIHRo ZSB2YXJpYWJsZSBmcm9tIHRoYXQKZGlmZiAtLWdpdCBhL2dkYi9weXRob24v cHktZnJhbWUuYyBiL2dkYi9weXRob24vcHktZnJhbWUuYwppbmRleCAxMjBl MTQ3Li44OGU5MTE0IDEwMDY0NAotLS0gYS9nZGIvcHl0aG9uL3B5LWZyYW1l LmMKKysrIGIvZ2RiL3B5dGhvbi9weS1mcmFtZS5jCkBAIC0yOCw2ICsyOCw3 IEBACiAjaW5jbHVkZSAicHl0aG9uLWludGVybmFsLmgiCiAjaW5jbHVkZSAi c3ltZmlsZS5oIgogI2luY2x1ZGUgIm9iamZpbGVzLmgiCisjaW5jbHVkZSAi dXNlci1yZWdzLmgiCiAKIHR5cGVkZWYgc3RydWN0IHsKICAgUHlPYmplY3Rf SEVBRApAQCAtMjM1LDYgKzIzNiw0MCBAQCBmcmFweV9wYyAoUHlPYmplY3Qg KnNlbGYsIFB5T2JqZWN0ICphcmdzKQogICByZXR1cm4gZ2RiX3B5X2xvbmdf ZnJvbV91bG9uZ2VzdCAocGMpOwogfQogCisvKiBJbXBsZW1lbnRhdGlvbiBv ZiBnZGIuRnJhbWUucmVhZF9yZWdpc3RlciAoc2VsZiwgcmVnaXN0ZXIpIC0+ IGdkYi5WYWx1ZS4KKyAgIFJldHVybnMgdGhlIHZhbHVlIG9mIGEgcmVnaXN0 ZXIgaW4gdGhpcyBmcmFtZS4gICovCisKK3N0YXRpYyBQeU9iamVjdCAqCitm cmFweV9yZWFkX3JlZ2lzdGVyIChQeU9iamVjdCAqc2VsZiwgUHlPYmplY3Qg KmFyZ3MpCit7CisgIHZvbGF0aWxlIHN0cnVjdCBnZGJfZXhjZXB0aW9uIGV4 Y2VwdDsKKyAgY29uc3QgY2hhciAqcmVnbnVtX3N0cjsKKyAgc3RydWN0IHZh bHVlICp2YWwgPSBOVUxMOworCisgIGlmICghUHlBcmdfUGFyc2VUdXBsZSAo YXJncywgInMiLCAmcmVnbnVtX3N0cikpCisgICAgcmV0dXJuIE5VTEw7CisK KyAgVFJZX0NBVENIIChleGNlcHQsIFJFVFVSTl9NQVNLX0FMTCkKKyAgICB7 CisgICAgICBzdHJ1Y3QgZnJhbWVfaW5mbyAqZnJhbWU7CisgICAgICBpbnQg cmVnbnVtID0gLTE7CisKKyAgICAgIEZSQVBZX1JFUVVJUkVfVkFMSUQgKHNl bGYsIGZyYW1lKTsKKworICAgICAgcmVnbnVtID0gdXNlcl9yZWdfbWFwX25h bWVfdG9fcmVnbnVtIChnZXRfZnJhbWVfYXJjaCAoZnJhbWUpLAorICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICByZWdudW1f c3RyLAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICBzdHJsZW4gKHJlZ251bV9zdHIpKTsKKyAgICAgIGlmIChyZWdudW0g Pj0gMCkKKyAgICAgICAgdmFsID0gdmFsdWVfb2ZfcmVnaXN0ZXIgKHJlZ251 bSwgZnJhbWUpOworCisgICAgICBpZiAodmFsID09IE5VTEwpCisgICAgICAg IFB5RXJyX1NldFN0cmluZyAoUHlFeGNfVmFsdWVFcnJvciwgXygiVW5rbm93 biByZWdpc3Rlci4iKSk7CisgICAgfQorICBHREJfUFlfSEFORExFX0VYQ0VQ VElPTiAoZXhjZXB0KTsKKworICByZXR1cm4gdmFsID09IE5VTEwgPyBOVUxM IDogdmFsdWVfdG9fdmFsdWVfb2JqZWN0ICh2YWwpOworfQorCiAvKiBJbXBs ZW1lbnRhdGlvbiBvZiBnZGIuRnJhbWUuYmxvY2sgKHNlbGYpIC0+IGdkYi5C bG9jay4KICAgIFJldHVybnMgdGhlIGZyYW1lJ3MgY29kZSBibG9jay4gICov CiAKQEAgLTY3NCw2ICs3MDksOSBAQCBSZXR1cm4gdGhlIHJlYXNvbiB3aHkg aXQncyBub3QgcG9zc2libGUgdG8gZmluZCBmcmFtZXMgb2xkZXIgdGhhbiB0 aGlzLiIgfSwKICAgeyAicGMiLCBmcmFweV9wYywgTUVUSF9OT0FSR1MsCiAg ICAgInBjICgpIC0+IExvbmcuXG5cCiBSZXR1cm4gdGhlIGZyYW1lJ3MgcmVz dW1lIGFkZHJlc3MuIiB9LAorICB7ICJyZWFkX3JlZ2lzdGVyIiwgZnJhcHlf cmVhZF9yZWdpc3RlciwgTUVUSF9WQVJBUkdTLAorICAgICJyZWFkX3JlZ2lz dGVyIChyZWdpc3Rlcl9uYW1lKSAtPiBnZGIuVmFsdWVcblwKK1JldHVybiB0 aGUgdmFsdWUgb2YgdGhlIHJlZ2lzdGVyIGluIHRoZSBmcmFtZS4iIH0sCiAg IHsgImJsb2NrIiwgZnJhcHlfYmxvY2ssIE1FVEhfTk9BUkdTLAogICAgICJi bG9jayAoKSAtPiBnZGIuQmxvY2suXG5cCiBSZXR1cm4gdGhlIGZyYW1lJ3Mg Y29kZSBibG9jay4iIH0sCmRpZmYgLS1naXQgYS9nZGIvdGVzdHN1aXRlL2dk Yi5weXRob24vcHktZnJhbWUuZXhwIGIvZ2RiL3Rlc3RzdWl0ZS9nZGIucHl0 aG9uL3B5LWZyYW1lLmV4cAppbmRleCAzNTE3ODI0Li5lNDdmMzQwIDEwMDY0 NAotLS0gYS9nZGIvdGVzdHN1aXRlL2dkYi5weXRob24vcHktZnJhbWUuZXhw CisrKyBiL2dkYi90ZXN0c3VpdGUvZ2RiLnB5dGhvbi9weS1mcmFtZS5leHAK QEAgLTk0LDMgKzk0LDIwIEBAIGdkYl90ZXN0ICJweXRob24gcHJpbnQgKCdy ZXN1bHQgPSAlcycgJSBmMC5yZWFkX3ZhciAoJ3ZhcmlhYmxlX3doaWNoX3N1 cmVseV9kb2VzCiBnZGJfdGVzdCAicHl0aG9uIHByaW50ICgncmVzdWx0ID0g JXMnICUgZjAucmVhZF92YXIgKCdhJykpIiAiID0gMSIgInRlc3QgRnJhbWUu cmVhZF92YXIgLSBzdWNjZXNzIgogCiBnZGJfdGVzdCAicHl0aG9uIHByaW50 ICgncmVzdWx0ID0gJXMnICUgKGdkYi5zZWxlY3RlZF9mcmFtZSAoKSA9PSBm MSkpIiAiID0gVHJ1ZSIgInRlc3QgZ2RiLnNlbGVjdGVkX2ZyYW1lIgorCisj IENhbiByZWFkIFNQIHJlZ2lzdGVyLgorZ2RiX3Rlc3QgInB5dGhvbiBwcmlu dCAoJ3Jlc3VsdCA9ICVzJyAlIChnZGIuc2VsZWN0ZWRfZnJhbWUgKCkucmVh ZF9yZWdpc3RlciAoJ3NwJykgPT0gZ2RiLnBhcnNlX2FuZF9ldmFsICgnXCRz cCcpKSkiIFwKKyAgIiA9IFRydWUiIFwKKyAgInRlc3QgRnJhbWUucmVhZF9y ZWdpc3RlcihzcCkiCisKKyMgUEMgdmFsdWUgb2J0YWluZWQgdmlhIHJlYWRf cmVnaXN0ZXIgaXMgYXMgZXhwZWN0ZWQuCitnZGJfdGVzdCAicHl0aG9uIHBy aW50ICgncmVzdWx0ID0gJXMnICUgKGYwLnJlYWRfcmVnaXN0ZXIoJ3BjJykg PT0gZjAucGMoKSkpIiBcCisgICIgPSBUcnVlIiBcCisgICJ0ZXN0IEZyYW1l LnJlYWRfcmVnaXN0ZXIocGMpIgorCisjIE9uIHg4Ni02NCwgUEMgaXMgaW4g JHJpcCByZWdpc3Rlci4KK2lmIHtbaXN0YXJnZXQgeDg2XzY0LSpdfSB7Cisg ICAgZ2RiX3Rlc3QgInB5dGhvbiBwcmludCAoJ3Jlc3VsdCA9ICVzJyAlIChm MC5yZWFkX3JlZ2lzdGVyKCdwYycpID09IGYwLnJlYWRfcmVnaXN0ZXIoJ3Jp cCcpKSkiIFwKKwkiID0gVHJ1ZSIgXAorCSJ0ZXN0IEZyYW1lLnJlYWRfcmVn aXN0ZXIocmlwKSIKK30K --001a11c2fad0481f5905018e316d--