From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1752 invoked by alias); 11 Jun 2014 23:52:49 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 1740 invoked by uid 89); 11 Jun 2014 23:52:48 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.7 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-oa0-f51.google.com Received: from mail-oa0-f51.google.com (HELO mail-oa0-f51.google.com) (209.85.219.51) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Wed, 11 Jun 2014 23:52:47 +0000 Received: by mail-oa0-f51.google.com with SMTP id j17so551371oag.24 for ; Wed, 11 Jun 2014 16:52:45 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=PFwhd+t770JKh57tGNWQ8dkBGpvGora6FLy3QF1ZHVg=; b=G1CtWxpk5XlanjrSm8k5kU3A4TZzBunDo5owQNtH8Xqcjt7AYpMrokZZGytBXWAGTy s1cEjEEQuNpKL/zzRmL8ccioBNxsIxuYGvtbEj9PktIGqDfumC/U6pWYgU/Y4QCLfINw D/s9Ey6behTjmADjbLkhymwWndYRl8UvKM6NRcte2VyS28ULiKtTGXABpwN6pXNyGVg1 m38YwQvJh+CQQg4GtPJ/4EtEVELozlFTk6wp/1nGDjw918sQ/fn71M7R1LrVJs84N3PA noooPg0QqYvQYfV074JjLWv7bwjETAWtJ64sskKdJu+PzbNy06s61HrLfuRwlK7pQekj ZYcA== X-Gm-Message-State: ALoCoQkbT0ARB2Xgu6KALQp4yH3xTHhZOaa/HxmQmDT6l+KuA0WCB+cHrwQNtX6pEerHdhee0f64 MIME-Version: 1.0 X-Received: by 10.60.33.102 with SMTP id q6mr8224908oei.59.1402530765466; Wed, 11 Jun 2014 16:52:45 -0700 (PDT) Received: by 10.182.144.133 with HTTP; Wed, 11 Jun 2014 16:52:45 -0700 (PDT) In-Reply-To: <87ioo7uuqm.fsf@fleche.redhat.com> References: <83oay128ca.fsf@gnu.org> <87ioo7uuqm.fsf@fleche.redhat.com> Date: Wed, 11 Jun 2014 23:52:00 -0000 Message-ID: Subject: Re: [PATCH] Add Frame.read_register to Python API From: Alexander Smundak To: Tom Tromey Cc: Eli Zaretskii , gdb-patches Content-Type: multipart/mixed; boundary=089e01182bf6101fc904fb982440 X-SW-Source: 2014-06/txt/msg00480.txt.bz2 --089e01182bf6101fc904fb982440 Content-Type: text/plain; charset=UTF-8 Content-length: 2814 > Alexander> def __init__(self, fobj): > Alexander> super(InlinedFrameDecorator, self).__init__(fobj) > Alexander> + self.fobj = fobj > > Alexander> def function(self): > Alexander> - frame = fobj.inferior_frame() > Alexander> + frame = self.fobj.inferior_frame() > Alexander> name = str(frame.name()) > > I think this is a nice fix but it seems unrelated to the patch at hand. > > Alexander> @defun Frame.find_sal () > Alexander> -Return the frame's symtab and line object. > Alexander> +Return the frame's @code{gdb.Symtab_and_line} object. > > Likewise. Should I mail these two as a single patch or as two separate patches? > Alexander> + FRAPY_REQUIRE_VALID (self, frame); > Alexander> + if (!PyArg_ParseTuple (args, "i", ®num)) > Alexander> + { > Alexander> + const char *regnum_str; > Alexander> + PyErr_Clear(); /* Clear PyArg_ParseTuple failure above. */ > Alexander> + if (PyArg_ParseTuple (args, "s", ®num_str)) > Alexander> + { > Alexander> + regnum = user_reg_map_name_to_regnum (get_frame_arch (frame), > Alexander> + regnum_str, > Alexander> + strlen (regnum_str)); > Alexander> + } > Alexander> + } > > I tend to think this would be clearer if the arguments were only parsed > once and then explicit type checks were applied to the resulting object. Did that, and then started doubting whether it is really necessary to read a register by its (very arch-specific) number. The new version supports reading the register by the name. Another change is that it now throws an exception if the name is wrong. > Alexander> +# On x86-64, PC is register 16. > Alexander> +gdb_test "python print ('result = %s' % ((f0.architecture().name() != 'i386:x86-64') or f0.read_register('pc') == f0.read_register(16)))" \ > Alexander> + "True" \ > Alexander> + "test Frame.read_register(regnum)" > > A test that is arch-specific needs to be conditionalized somehow. IMHO it's borderline arch-specific -- it is runnable on any platform, although it will not be testing much on any but x86-64. There hasn't been any arch-specific tests for Python so far, so I am not sure what to do. Here's the new version (style violations have been addressed, too): The ability to read registers is needed to use Frame Filter API to display the frames created by JIT compilers. gdb/Changelog 2014-06-11 Sasha Smundak * python/py-frame.c (frapy_read_register): New function. 2014-06-11 Sasha Smundak * python.texi (Frames in Python): Add read_register description. 2014-06-11 Sasha Smundak * gdb.python/py-frame.exp: Test Frame.read_register. --089e01182bf6101fc904fb982440 Content-Type: text/plain; charset=US-ASCII; name="frame-read-register-patch-3.txt" Content-Disposition: attachment; filename="frame-read-register-patch-3.txt" Content-Transfer-Encoding: base64 X-Attachment-Id: f_hwbakju90 Content-length: 5531 ZGlmZiAtLWdpdCBhL2dkYi9ORVdTIGIvZ2RiL05FV1MKaW5kZXggMTM5N2U4 Yi4uM2RiNDU4YiAxMDA2NDQKLS0tIGEvZ2RiL05FV1MKKysrIGIvZ2RiL05F V1MKQEAgLTMsNiArMyw5IEBACiAKICoqKiBDaGFuZ2VzIHNpbmNlIEdEQiA3 LjcKIAorKiBQeXRob24gU2NyaXB0aW5nCisgIFlvdSBjYW4gbm93IGFjY2Vz cyBmcmFtZSByZWdpc3RlcnMgZnJvbSBQeXRob24gc2NyaXB0cy4KKwogKiBO ZXcgY29tbWFuZCBsaW5lIG9wdGlvbnMKIAogLUQgZGF0YS1kaXJlY3RvcnkK ZGlmZiAtLWdpdCBhL2dkYi9kb2MvcHl0aG9uLnRleGkgYi9nZGIvZG9jL3B5 dGhvbi50ZXhpCmluZGV4IDQ2ODg3ODMuLjNjYjZiZjggMTAwNjQ0Ci0tLSBh L2dkYi9kb2MvcHl0aG9uLnRleGkKKysrIGIvZ2RiL2RvYy9weXRob24udGV4 aQpAQCAtMzU4OSw2ICszNTg5LDEzIEBAIFJldHVybiB0aGUgZnJhbWUncyBz eW10YWIgYW5kIGxpbmUgb2JqZWN0LgogQHhyZWZ7U3ltYm9sIFRhYmxlcyBJ biBQeXRob259LgogQGVuZCBkZWZ1bgogCitAZGVmdW4gRnJhbWUucmVhZF9y ZWdpc3RlciAocmVnaXN0ZXIpCitSZXR1cm4gdGhlIHZhbHVlIG9mIEB2YXJ7 cmVnaXN0ZXJ9IGluIHRoaXMgZnJhbWUuICBUaGUgQHZhcntyZWdpc3Rlcn0K K2FyZ3VtZW50IG11c3QgYmUgYSBzdHJpbmcgKGUuZy4sIEBjb2RleydzcCd9 IG9yIEBjb2RleydyYXgnfSkuCitSZXR1cm5zIGEgQGNvZGV7R2RiLlZhbHVl fSBvYmplY3QuICBUaHJvd3MgYW4gZXhjZXB0aW9uIGlmIEB2YXJ7cmVnaXN0 ZXJ9Citkb2VzIG5vdCBleGlzdC4KK0BlbmQgZGVmdW4KKwogQGRlZnVuIEZy YW1lLnJlYWRfdmFyICh2YXJpYWJsZSBAcntbfSwgYmxvY2tAcntdfSkKIFJl dHVybiB0aGUgdmFsdWUgb2YgQHZhcnt2YXJpYWJsZX0gaW4gdGhpcyBmcmFt ZS4gIElmIHRoZSBvcHRpb25hbAogYXJndW1lbnQgQHZhcntibG9ja30gaXMg cHJvdmlkZWQsIHNlYXJjaCBmb3IgdGhlIHZhcmlhYmxlIGZyb20gdGhhdApk aWZmIC0tZ2l0IGEvZ2RiL3B5dGhvbi9weS1mcmFtZS5jIGIvZ2RiL3B5dGhv bi9weS1mcmFtZS5jCmluZGV4IDc3MDc3ZDMuLjczYmZmYjEgMTAwNjQ0Ci0t LSBhL2dkYi9weXRob24vcHktZnJhbWUuYworKysgYi9nZGIvcHl0aG9uL3B5 LWZyYW1lLmMKQEAgLTI4LDYgKzI4LDcgQEAKICNpbmNsdWRlICJweXRob24t aW50ZXJuYWwuaCIKICNpbmNsdWRlICJzeW1maWxlLmgiCiAjaW5jbHVkZSAi b2JqZmlsZXMuaCIKKyNpbmNsdWRlICJ1c2VyLXJlZ3MuaCIKIAogdHlwZWRl ZiBzdHJ1Y3QgewogICBQeU9iamVjdF9IRUFECkBAIC0yMzUsNiArMjM2LDM5 IEBAIGZyYXB5X3BjIChQeU9iamVjdCAqc2VsZiwgUHlPYmplY3QgKmFyZ3Mp CiAgIHJldHVybiBnZGJfcHlfbG9uZ19mcm9tX3Vsb25nZXN0IChwYyk7CiB9 CiAKKy8qIEltcGxlbWVudGF0aW9uIG9mIGdkYi5GcmFtZS5yZWFkX3JlZ2lz dGVyIChzZWxmLCByZWdpc3RlcikgLT4gZ2RiLlZhbHVlLgorICAgUmV0dXJu cyB0aGUgdmFsdWUgb2YgYSByZWdpc3RlciBpbiB0aGlzIGZyYW1lLiAgKi8K Kworc3RhdGljIFB5T2JqZWN0ICoKK2ZyYXB5X3JlYWRfcmVnaXN0ZXIgKFB5 T2JqZWN0ICpzZWxmLCBQeU9iamVjdCAqYXJncykKK3sKKyAgc3RydWN0IGZy YW1lX2luZm8gKmZyYW1lOworICB2b2xhdGlsZSBzdHJ1Y3QgZ2RiX2V4Y2Vw dGlvbiBleGNlcHQ7CisgIGludCByZWdudW0gPSAtMTsKKyAgc3RydWN0IHZh bHVlICp2YWwgPSBOVUxMOworICBjb25zdCBjaGFyICpyZWdudW1fc3RyOwor CisgIGlmICghUHlBcmdfUGFyc2VUdXBsZSAoYXJncywgInMiLCAmcmVnbnVt X3N0cikpCisgICAgcmV0dXJuIE5VTEw7CisKKyAgVFJZX0NBVENIIChleGNl cHQsIFJFVFVSTl9NQVNLX0FMTCkKKyAgICB7CisgICAgICBGUkFQWV9SRVFV SVJFX1ZBTElEIChzZWxmLCBmcmFtZSk7CisKKyAgICAgIHJlZ251bSA9IHVz ZXJfcmVnX21hcF9uYW1lX3RvX3JlZ251bSAoZ2V0X2ZyYW1lX2FyY2ggKGZy YW1lKSwKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgcmVnbnVtX3N0ciwKKyAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgc3RybGVuIChyZWdudW1fc3RyKSk7CisgICAg ICBpZiAocmVnbnVtID49IDApCisgICAgICAgIHZhbCA9IHZhbHVlX29mX3Jl Z2lzdGVyIChyZWdudW0sIGZyYW1lKTsKKworICAgICAgaWYgKHZhbCA9PSBO VUxMKQorICAgICAgICBQeUVycl9TZXRTdHJpbmcgKFB5RXhjX1ZhbHVlRXJy b3IsIF8oIlVua25vd24gcmVnaXN0ZXIuIikpOworICAgIH0KKyAgR0RCX1BZ X0hBTkRMRV9FWENFUFRJT04gKGV4Y2VwdCk7CisKKyAgcmV0dXJuIHZhbCA9 PSBOVUxMID8gTlVMTCA6IHZhbHVlX3RvX3ZhbHVlX29iamVjdCAodmFsKTsK K30KKwogLyogSW1wbGVtZW50YXRpb24gb2YgZ2RiLkZyYW1lLmJsb2NrIChz ZWxmKSAtPiBnZGIuQmxvY2suCiAgICBSZXR1cm5zIHRoZSBmcmFtZSdzIGNv ZGUgYmxvY2suICAqLwogCkBAIC02NzQsNiArNzA4LDkgQEAgUmV0dXJuIHRo ZSByZWFzb24gd2h5IGl0J3Mgbm90IHBvc3NpYmxlIHRvIGZpbmQgZnJhbWVz IG9sZGVyIHRoYW4gdGhpcy4iIH0sCiAgIHsgInBjIiwgZnJhcHlfcGMsIE1F VEhfTk9BUkdTLAogICAgICJwYyAoKSAtPiBMb25nLlxuXAogUmV0dXJuIHRo ZSBmcmFtZSdzIHJlc3VtZSBhZGRyZXNzLiIgfSwKKyAgeyAicmVhZF9yZWdp c3RlciIsIGZyYXB5X3JlYWRfcmVnaXN0ZXIsIE1FVEhfVkFSQVJHUywKKyAg ICAicmVhZF9yZWdpc3RlciAocmVnaXN0ZXIpIC0+IGdkYi5WYWx1ZVxuXAor UmV0dXJuIHRoZSB2YWx1ZSBvZiB0aGUgcmVnaXN0ZXIgaW4gdGhlIGZyYW1l LiIgfSwKICAgeyAiYmxvY2siLCBmcmFweV9ibG9jaywgTUVUSF9OT0FSR1Ms CiAgICAgImJsb2NrICgpIC0+IGdkYi5CbG9jay5cblwKIFJldHVybiB0aGUg ZnJhbWUncyBjb2RlIGJsb2NrLiIgfSwKZGlmZiAtLWdpdCBhL2dkYi90ZXN0 c3VpdGUvZ2RiLnB5dGhvbi9weS1mcmFtZS5leHAgYi9nZGIvdGVzdHN1aXRl L2dkYi5weXRob24vcHktZnJhbWUuZXhwCmluZGV4IDM1MTc4MjQuLjllZWVi YmEgMTAwNjQ0Ci0tLSBhL2dkYi90ZXN0c3VpdGUvZ2RiLnB5dGhvbi9weS1m cmFtZS5leHAKKysrIGIvZ2RiL3Rlc3RzdWl0ZS9nZGIucHl0aG9uL3B5LWZy YW1lLmV4cApAQCAtOTQsMyArOTQsMTYgQEAgZ2RiX3Rlc3QgInB5dGhvbiBw cmludCAoJ3Jlc3VsdCA9ICVzJyAlIGYwLnJlYWRfdmFyICgndmFyaWFibGVf d2hpY2hfc3VyZWx5X2RvZXMKIGdkYl90ZXN0ICJweXRob24gcHJpbnQgKCdy ZXN1bHQgPSAlcycgJSBmMC5yZWFkX3ZhciAoJ2EnKSkiICIgPSAxIiAidGVz dCBGcmFtZS5yZWFkX3ZhciAtIHN1Y2Nlc3MiCiAKIGdkYl90ZXN0ICJweXRo b24gcHJpbnQgKCdyZXN1bHQgPSAlcycgJSAoZ2RiLnNlbGVjdGVkX2ZyYW1l ICgpID09IGYxKSkiICIgPSBUcnVlIiAidGVzdCBnZGIuc2VsZWN0ZWRfZnJh bWUiCisKKyMgQ2FuIHJlYWQgU1AgcmVnaXN0ZXIuCitnZGJfdGVzdCAicHl0 aG9uIHByaW50ICgncmVzdWx0ID0gJXMnICUgZjAucmVhZF9yZWdpc3Rlcign c3AnKSkiIFwKKyAgIiA9IDB4XFswLTlhLWZBLUZcXSsiIFwKKyAgInRlc3Qg RnJhbWUucmVhZF9yZWdpc3RlcihmcCkiCisjIFBDIHZhbHVlIG9idGFpbmVk IHZpYSByZWFkX3JlZ2lzdGVyIGlzIGFzIGV4cGVjdGVkLgorZ2RiX3Rlc3Qg InB5dGhvbiBwcmludCAoJ3Jlc3VsdCA9ICVzJyAlIChmMC5yZWFkX3JlZ2lz dGVyKCdwYycpLmNhc3QoZ2RiLmxvb2t1cF90eXBlKCd1bnNpZ25lZCBsb25n JykpID09IGYwLnBjKCkpKSIgXAorICAiVHJ1ZSIgXAorICAidGVzdCBGcmFt ZS5yZWFkX3JlZ2lzdGVyKHBjKSIKKyMgT24geDg2LTY0LCBQQyBpcyBpbiAk cmlwIHJlZ2lzdGVyLgorZ2RiX3Rlc3QgInB5dGhvbiBwcmludCAoJ3Jlc3Vs dCA9ICVzJyAlICgoZjAuYXJjaGl0ZWN0dXJlKCkubmFtZSgpICE9ICdpMzg2 Ong4Ni02NCcpIG9yIGYwLnJlYWRfcmVnaXN0ZXIoJ3BjJykgPT0gZjAucmVh ZF9yZWdpc3RlcigncmlwJykpKSIgXAorICAiVHJ1ZSIgXAorICAidGVzdCBG cmFtZS5yZWFkX3JlZ2lzdGVyKHJlZ251bSkiCg== --089e01182bf6101fc904fb982440--