From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-x332.google.com (mail-wm1-x332.google.com [IPv6:2a00:1450:4864:20::332]) by sourceware.org (Postfix) with ESMTPS id A7E183858D1E for ; Tue, 18 Apr 2023 09:59:24 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A7E183858D1E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=hev.cc Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=hev.cc Received: by mail-wm1-x332.google.com with SMTP id 5b1f17b1804b1-3f178da21b2so5372115e9.1 for ; Tue, 18 Apr 2023 02:59:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hev-cc.20221208.gappssmtp.com; s=20221208; t=1681811963; x=1684403963; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=1pbryTB1mjPzk6gz7B/W0MB9ET+pkEs6y1A1arf0VBY=; b=yhzYiurWgaTDc+Jk8WhEMsQe2TgtR712JdJG6VM5BUeAshhkbJISb1B8Fjc0aF8MOP JmIMHoLUJSFEIquuTs3N7lmGFk7Z7/WDinihosb+Mkdn29ynQTtv+s5QrSsEM9yjbvg8 BBuJpdYk2oSRVmT04GFcB4vWtUhpEiFvwsJm4KslUb2zdXPeT/o9v0V4sg5JUz1vP3mA NkK/a5zwMk0/evTy5m0tXKt04jyA2yEkq73uvmMu/DwZ1NtTb+D8lip8PPRro0mORwHW uXkc/IWtKkYyqmbETpb3PA9ewWHFybU7l5eURll3+ghHpAeVoy+MJ5qAvgwk33CrIiP/ /LvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681811963; x=1684403963; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=1pbryTB1mjPzk6gz7B/W0MB9ET+pkEs6y1A1arf0VBY=; b=NbRvYaV9wtrdMOnypn9Q5oIDmwMaiULO8UjOUgNjmiPfHlZZ+8NH9QPp9IG9+ip6Z7 0i6xfQ+CE4X7Z9usmnklj6OvH/a6khE7a3mUkKYRKNgtPyyWx9mn7fXpqKGQ5ajDKZ4W Rgrg6l8R1HfbCm/awJJMWbDx/8rXJYBOLURBRjU1OCXSVvlEx0Z7RQ02lt3RwYSZkrvU OHuR+1O0d58p0U36qMcCCMaziK5XLla1Q7toLQSrn4dClrcJXk0/7A3Fzs3QWz1VW5/v ZmbFtT61IM0fsw+iX+sBMR8NeYzwwqVpkXOifVIePaUiKSfJx5/aHKcbXcolsxLIEJnf QxVQ== X-Gm-Message-State: AAQBX9fSmq+/+fkDmRIu5Vp9GylCel9bpC81KJaIUjtB3FXdZIvPkDKv 8VGRy3DhFTCxMkhHnLhFXsulvsbLhrFlSKB1QaqWnMqc9swYRK2tTBJtMAWD X-Google-Smtp-Source: AKy350bJN7CJub79NZMreDnvzi/xKz6JQupRDatN4koDEwg4g6F8pUcqh9xRWfI0gf0nRS7TtNS1XHU+Jgp/XqD6hm0= X-Received: by 2002:a5d:4acb:0:b0:2ef:b3e6:8293 with SMTP id y11-20020a5d4acb000000b002efb3e68293mr1699658wrs.9.1681811962965; Tue, 18 Apr 2023 02:59:22 -0700 (PDT) MIME-Version: 1.0 References: <20230417162428.48426-1-r@hev.cc> <901e6d84-2476-9108-b79c-0a3747d02b2f@redhat.com> In-Reply-To: From: hev Date: Tue, 18 Apr 2023 17:59:11 +0800 Message-ID: Subject: Re: [PATCH] gdb: Fix false match issue in skip_prologue_using_linetable To: Tom de Vries Cc: Keith Seitz , gdb-patches@sourceware.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Tue, Apr 18, 2023 at 4:43=E2=80=AFPM Tom de Vries wro= te: > > On 4/18/23 04:26, hev wrote: > >> I have to ask, though, is there a way to write a test case for this? M= aybe > >> by using dw2-prologue-end.exp as an example? > > > I attempted to write a test case, but it did not work. I discovered thi= s > > issue while running the Rust debuginfo test[1] on LoongArch. As the > > function entry alignment is 4-byte, which is the size of an instruction= , > > there is no padding between the two functions. This creates a possibili= ty > > of matching the start address of the next function. This is unlike x86, > > which is why this problem does not occur on x86. I sincerely hope that = this > > information proves to be beneficial to you. > > Using this information I managed to write a regression test for this, > I've attached it to a PR I opened for this issue ( > https://sourceware.org/bugzilla/show_bug.cgi?id=3D30369 ). Awesome! Thank you. -- Rui