From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-x435.google.com (mail-wr1-x435.google.com [IPv6:2a00:1450:4864:20::435]) by sourceware.org (Postfix) with ESMTPS id 1DD473858C50 for ; Sun, 23 Apr 2023 01:25:09 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1DD473858C50 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=hev.cc Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=hev.cc Received: by mail-wr1-x435.google.com with SMTP id ffacd0b85a97d-2f7db354092so1852743f8f.2 for ; Sat, 22 Apr 2023 18:25:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hev-cc.20221208.gappssmtp.com; s=20221208; t=1682213107; x=1684805107; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=KDHSFaFKkrurfYMsliJlyw3fUuo/KnX3r8q9rv/voUE=; b=L6plcWywXlk35wjn849feuIHMQ//PogjzdA0qbqRNu61AmDEaqU4wOU8dLyjHHz4H4 hdOzmI57fA/fLWH0Kj6hrgALpY5LLsPCpujQwCYfNW46W/UWr7Q0ebfRQet3wRwR9oco ctDSL0Lg/i2AxNe1XXXsk6KETG9Gu0d+sJP2IihKzTWoDiizqvG9n9TdSgBsf3xNu7gx fuiHBvK/5a4Al1fveQTPmjniakX9YNML/3HwlOCcjrjPaqdk4LwC6ZAoouRkwLayqRAq 1MGaWx0zq8DR8H0elcfjDMqxegIq9uZFsgXof22GD/NWFIAxb/9SHUrVxgVPmQLL1J5V pqvQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682213107; x=1684805107; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=KDHSFaFKkrurfYMsliJlyw3fUuo/KnX3r8q9rv/voUE=; b=NU7IN1K3erOv+XeqK3XCUsePh4WqnW/fMXvKwzXNxa2VfMT/BkMcka2CvARDhSpJFf 3r6sGChUpbgzjfbubjUEnt20kCSChZPJQsVMU+hgwjmds7kMlycrr1ixjoayIkYl9LWt eo33UR+4oqq7h+EBREsdh1oD83er5UbxnAPWJKXfDv/HNXF5u04723tElsRRPJuXxS// tcZ2B6HQ/vuIzmALFL+cRZKTAGJgeJvA4JRem6TgBtI3LldD2WcfHhbzw1Bm1EXX39sA gceeCLj/G7VkIQQC7j0hwd6SmYfbw+5uyB5sCvJB2V7ogB5BuXK04F37jp5REYT360oD TK/g== X-Gm-Message-State: AAQBX9f5lqKuGO3W3XjKyCWI+gXeIYo478QZ2l4pa5l7WgsXeDBOVUAJ +54ikRVs+adba1Jgngq1iSG1hbVovEyr0k/yzRlLZdknswO9+AzLSD5TvlHq X-Google-Smtp-Source: AKy350Y/tdWLOrHNCAYjS3e+Z71SncSM0FtXmY2g4MwKc1WRwEQ7S58vd5qKoLy+F/O72dhDOf20QeMWInzN1Mx4Jig= X-Received: by 2002:a5d:4147:0:b0:301:8080:a8fa with SMTP id c7-20020a5d4147000000b003018080a8famr7623748wrq.27.1682213106831; Sat, 22 Apr 2023 18:25:06 -0700 (PDT) MIME-Version: 1.0 References: <20230417162428.48426-1-r@hev.cc> <3dee100c-1837-f95b-711a-c6f02bb9887a@suse.de> In-Reply-To: <3dee100c-1837-f95b-711a-c6f02bb9887a@suse.de> From: hev Date: Sun, 23 Apr 2023 09:24:55 +0800 Message-ID: Subject: Re: [PATCH] gdb: Fix false match issue in skip_prologue_using_linetable To: Tom de Vries Cc: gdb-patches@sourceware.org, Lancelot SIX Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-3.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Tom, On Sat, Apr 22, 2023 at 4:36=E2=80=AFPM Tom de Vries wro= te: > > On 4/17/23 18:24, WANG Rui wrote: > > We should exclude matches to the ending PC to prevent false matches wit= h the > > next function, as prologue_end is located at the end PC. > > Hi Rui, > > thanks for the bug-report-and-fix, much appreciated. > > If you might make more or larger contributions in the future, please > consider filing a copyright assignment ( > https://sourceware.org/gdb/wiki/ContributionChecklist#FSF_copyright_Assig= nment > ). Thank you for suggesting that I consider filing a copyright assignment with the FSF if I plan on making more contributions in the future. I appreciate your guidance and will definitely keep it in mind. :) Thanks Rui