Re: [PATCH] gdb/debuginfod: Improve progress updates

[Aaron Merey <amerey@redhat.com>]

On Wed, Jan 12, 2022 at 6:35 PM Patrick Monnerat via Gdb-patches
<gdb-patches@sourceware.org> wrote:
> Currently, I have a graphical throbber triggered by calls to ui_out
> do_progress_notify() method. The message is displayed in the status bar,
> not in the throbber/progressbar widget.
>
> The widget occupied by the progressbar/throbber is also used to display
> some other kind of information while not downloading.
>
> I rely on calls to ui_out methods do_progress_start(),
> do_progress_notify() and do_progress_end() to multiplex this zone.

To keep the UI simple, for each download there is a line printed
indicating the name and type of file being downloaded as well as
the size, if available. If the size is unknown then the throbber is
displayed at the end of this line. If the size is known then the
progress bar is printed on the following line.

Do you think it would be better to print the throbber on its own line?

> In do_progress_notify(), I check if the argument is negative to know if
> I must deal with a progress bar or a throbber.

I do basically the same thing by checking total > 0. If <= 0 then the
transfer size is unknown, so we display the throbber in that case.

Thanks,
Aaron