From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 3C9EC3858C3A for ; Fri, 11 Mar 2022 21:50:09 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 3C9EC3858C3A Received: from mail-yw1-f199.google.com (mail-yw1-f199.google.com [209.85.128.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-640-WRCf5mD0NhqEGuJRFEYmTw-1; Fri, 11 Mar 2022 16:50:07 -0500 X-MC-Unique: WRCf5mD0NhqEGuJRFEYmTw-1 Received: by mail-yw1-f199.google.com with SMTP id 00721157ae682-2d81518795fso80419497b3.0 for ; Fri, 11 Mar 2022 13:50:07 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=zFCz1UoTBMtvOrTE+P5U55YKl9GZuztuagGG6awOEDg=; b=o1M2DOr/oD5GkTRxVY5lVH6Vz0hAit1BEB3AwncXyudQBz0qz6QoTfh3gkBkWVIJDq k0GkfhmyTJuUpnduubK2gKb+zO4GaOYHV1OQ3OcmLQQualMiKYDz/LwZXJcZmj8uHYWn RNJJnfb1CmgabXE3oxhzaHFB7P395Q3oysqD2ApfVS12OygmUQC9wuSdmW7rfQoT49CV LjhSz8S1gwObixDvuymONtnK7TIUaLBkU6TTTbRljr6CFQKe5j7N6rl/bxNfObglRYmM WUyuRCsM5U2WjhTKAGOnziVoNqrre6k/GBkbpFRBfY3+5qEZm6RKHIo4c9g306x+W4en xACg== X-Gm-Message-State: AOAM5320Htvrq/lBUNco7iFMharE8MfjbkHlpImrtQ8OWqX5UDEtkMYr e+6DCj5M1njNP8dqkrgJ6jFOAevxmAnVOoQpHJP4tU86f4Xca51F3rG+GYN0nA7aHmcXek7sz/n 3hqR6OkXIUpPPVTh8JbffN6f5X0C/B9j958Ha X-Received: by 2002:a25:90d:0:b0:622:4bed:4f4f with SMTP id 13-20020a25090d000000b006224bed4f4fmr9765383ybj.508.1647035407221; Fri, 11 Mar 2022 13:50:07 -0800 (PST) X-Google-Smtp-Source: ABdhPJyDejUZsmHuduJvUwGOIS6kXeKH+9UCXnHgXYsZKK198xHSBQg8sYSFVZgcdpugx/zBCgQPpWNbWjBPMvrHbls= X-Received: by 2002:a25:90d:0:b0:622:4bed:4f4f with SMTP id 13-20020a25090d000000b006224bed4f4fmr9765368ybj.508.1647035406990; Fri, 11 Mar 2022 13:50:06 -0800 (PST) MIME-Version: 1.0 References: <87wnh9u4m2.fsf@tromey.com> <20220308003331.171162-1-amerey@redhat.com> <8735jomrvq.fsf@tromey.com> In-Reply-To: <8735jomrvq.fsf@tromey.com> From: Aaron Merey Date: Fri, 11 Mar 2022 16:49:56 -0500 Message-ID: Subject: Re: [PATCH 2/2] PR gdb/27570: missing support for debuginfod in core_target::build_file_mappings To: Tom Tromey Cc: Aaron Merey via Gdb-patches , Andrew Burgess , lsix@lancelot.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-5.8 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Mar 2022 21:50:10 -0000 On Fri, Mar 11, 2022 at 10:27 AM Tom Tromey wrote: > > >>>>> Aaron Merey via Gdb-patches writes: > > > gdb/corelow.c | 28 ++++++++++ > > gdb/debuginfod-support.c | 51 +++++++++++++++++++ > > gdb/debuginfod-support.h | 17 +++++++ > > gdb/gcore.in | 2 +- > > gdb/solib.c | 32 ++++++++++++ > > .../gdb.debuginfod/fetch_src_and_symbols.exp | 22 ++++++++ > > 6 files changed, 151 insertions(+), 1 deletion(-) > > This looks good to me. Thanks. Great, I'll merge it once patch 1/2 is merged. > > > + if (debuginfod_verbose > 0 && fd.get () < 0 && fd.get () != -ENOENT) > > + printf_filtered (_("Download failed: %s. " \ > > + "Continuing without executable for %ps.\n"), > > + safe_strerror (-fd.get ()), > > + styled_string (file_name_style.style (), filename)); > > I can't remember if I mentioned this before but it seems like a failure > to download should probably always be reported. Maybe this ought to be > an unconditional warning call. I will fix this in a separate patch. I think this counts as an obvious fix. Aaron