From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 31AEE3858D1E for ; Thu, 10 Nov 2022 17:21:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 31AEE3858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1668100860; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=LVUfGij7peqSApbdkkSktNr4QLIbDrNCZybekNF8NCA=; b=Ashpc9fnIhj+dsdOmav8XOamkEPWaCOiWH/SfYmwrenXP+Y4A8iLhkoqNb17ii32qxg60I +UjWRPmZhWpY1WZCXsHRVxk6ZC/Ata3eJRApbjlkroHIqfN3/yWUugGuKuDrs8E2tSaUj+ YXJYDKVce88jDaZBcxzf+adVRQUQ+YI= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-331-J-onqS3YNEGe5f7DVnfOwA-1; Thu, 10 Nov 2022 12:20:59 -0500 X-MC-Unique: J-onqS3YNEGe5f7DVnfOwA-1 Received: by mail-wm1-f71.google.com with SMTP id bg21-20020a05600c3c9500b003c2acbff422so3062053wmb.0 for ; Thu, 10 Nov 2022 09:20:59 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=LVUfGij7peqSApbdkkSktNr4QLIbDrNCZybekNF8NCA=; b=usM/e21EYxNSpHd+GYaVxY77Pr1u9br/gbgJ/r4jR29f743LSgExOTlWyWmJS582Rc OOOyMi5CqiiLp31KmNIGrtBCKap0PTuAxeB71XKze4YFiN3pR+aE0282RTwno29xUqs5 Gcv1xrppLL1LdSepm0Kj3DwdxaqNjLz6m1Cs5VS6ubNER+ERXpnSF7w1bsT86PQotD0F eGsmzLMVqRa5vXM99ST5tvu5DInrBhVcLaQLdBrfU9l/wdbS8l2iEO3Nzl3DlGQFPgSK o34d9t363j3euetB/XfISbDW/NPljpJTYXSFTteurZldJ2gObFI5HAbRM+N9AAZqxRfQ NWHg== X-Gm-Message-State: ACrzQf1PfHeSkb426Lh/x1FIJxr2D0v5heyPnQz5OEcRh1LKaFC+CtAj Jx23QiCC+ZprShbZfzOxY1kgSBjpxP9dWR1bGVpqJlmf9ASDFU6Y389G5l+NDspWb2DF4TOs6cq n6QIvizROrJYDYWrrGsaCRkYGA4x+eXfXxg4c X-Received: by 2002:a05:600c:3011:b0:3cf:9c3f:3b60 with SMTP id j17-20020a05600c301100b003cf9c3f3b60mr21455830wmh.183.1668100858192; Thu, 10 Nov 2022 09:20:58 -0800 (PST) X-Google-Smtp-Source: AMsMyM4yMKbN5nzCJnpbR5i9Dp9oCz/h1D7WMEeQ4KBDTcr8AtqutqKF7ozRxysEwOl4aBQ2ABDNq49Nbnion6qsQGk= X-Received: by 2002:a05:600c:3011:b0:3cf:9c3f:3b60 with SMTP id j17-20020a05600c301100b003cf9c3f3b60mr21455826wmh.183.1668100857997; Thu, 10 Nov 2022 09:20:57 -0800 (PST) MIME-Version: 1.0 References: <875ygdaqu8.fsf@tromey.com> <20221026031738.161771-1-amerey@redhat.com> <87mt8z28xy.fsf@tromey.com> In-Reply-To: <87mt8z28xy.fsf@tromey.com> From: Aaron Merey Date: Thu, 10 Nov 2022 12:20:46 -0500 Message-ID: Subject: Re: [PATCH v4] gdb/debuginfod: Improve progress updates To: Tom Tromey Cc: Aaron Merey via Gdb-patches X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-5.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Wed, Nov 9, 2022 at 3:02 PM Tom Tromey wrote: > > This patch is ok. Thanks Tom, pushed as commit 27859c6b9d73. I made a small change to this patch before pushing. If gdb's width is set to unlimited, we now just print a static description of the download. No progress bar will be printed, same as if the screen width was too narrow for the progress bar or batch mode was enabled. I updated the commit message to reflect this change. Previously if gdb's width was unlimited we'd set the progress bar width to maximum (4k characters), however this caused some visual noise in the gdb.debuginfod test log. To avoid any unintentionally huge progress bars I think it's better to only display them when a definite screen width is known. Aaron