Re: [PATCH] gdb/debuginfod: Prevent prompt for continue during downloading.

[Aaron Merey <amerey@redhat.com>]

On Mon, Feb 13, 2023 at 9:18 AM Tom Tromey <tom@tromey.com> wrote:
>
> >>>>> "Aaron" == Aaron Merey via Gdb-patches <gdb-patches@sourceware.org> writes:
>
> Aaron> However the on-demand downloading work creates new situations where
> Aaron> a large series of downloads might happen outside fetch_inferior_event.
> Aaron> For example, "break client.c:50" could download the .debug_line and
> Aaron> .debug_line_str of each shared library to search for the filename
> Aaron> "client.c". Then it downloads debuginfo for each match, all of which
> Aaron> happens outside of fetch_inferior_event.
>
> Aaron> Setting pagination_enabled=false in debuginfod_*_query prevents the
> Aaron> prompt durings the downloads but lines_printed keeps increasing.
> Aaron> If lines_allowed is exceeded then after the download you get an (IMO)
> Aaron> annoying prompt:
>
> I think this is what the user has requested, though.
> The pager can easily be disabled, but if we let code work around it,
> there's not really any way to ask for it to be enabled again.

Fair point, although some users (myself included) may want promptless
debuginfod output without having to completely disable the pager. Maybe
avoiding line counting in these cases should be done through
'set debuginfod verbose'?  In any case I think the debuginfod_*_query
functions should at least disable pagination.

> Aaron> Adding a count_lines_printed flag gives us another way to fine-tune
> Aaron> when the prompt shows up.  It keeps prompt behavior around debuginfod
> Aaron> output consistent whether or not the inferior is running.
>
> This is an internal distinction but it seems to me that to the user, gdb
> output is just gdb output and can't really be differentiated by its
> origin.

Inconsistent behavior due to an internal distinction could make the
behavior even more perplexing to some users.

Aaron