From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 84B663858C27 for ; Mon, 13 Feb 2023 20:23:43 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 84B663858C27 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1676319823; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=f1qoaQfP0InWXgZZUxINg6SVjTF9FE6kKIOqn9EqswA=; b=gIyf9A9QEnmX45DhVjqAUEuq3DQs1FzfouP6iaVbgiSbzi/K8kPFkTbNihYXHqSM2KksCt Zp0phhE6s/KswrlJsS2Gh/36eg7vNDVqyTujgfxjSIJ6L/OxGvbaSsR5cWdXelgS5CbWL9 YetG+TMQ3/01TreEdVVfyGTOgzjyqpM= Received: from mail-pf1-f198.google.com (mail-pf1-f198.google.com [209.85.210.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-659-wth9tg82NGywebUBCQr6ng-1; Mon, 13 Feb 2023 15:23:38 -0500 X-MC-Unique: wth9tg82NGywebUBCQr6ng-1 Received: by mail-pf1-f198.google.com with SMTP id t6-20020a056a0021c600b005a8b508aecdso2134962pfj.20 for ; Mon, 13 Feb 2023 12:23:37 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=f1qoaQfP0InWXgZZUxINg6SVjTF9FE6kKIOqn9EqswA=; b=BXcJkvFYmkcJbuI4qp7YzobUeBNx0XPfnsNDh46nenva344JS504cAt9ziBGSL/y2Y aY+HzZ8cmiOqT6S6uK3X9/5z8OIqWxRnrs9hPztdwgwbHtRzWSwXKE5KXxwXnI5t/h9e hFU/KbWePs+K6dcNbqbVnFIZ2JdS0m7ZJfHjjOgHyM4P/p8hSszP01pxd9LnZXCowXgO rvVICp0ujYATxi35a7nR2DyWt3n47lIEAwWjZRTeVbAsv3Mwj5yiunkDRX0cDJZNHLR1 Yuz0T6zRQ7qnOw/PAm2P7T+oXUxAzQNxuPhN4G6QocVHLxa/1eGJTNZ9w0EQRVnPG3ZL kBcw== X-Gm-Message-State: AO0yUKU1RpUxLZ8NthodXu0LJDd2n90mUwCSwbjm5CNdMzRm3KcpACvo 1A8TIp/ykq2rZDbb6uK+j8BP2JXkKAzWMAakQ86nhejHhmKQU+FnXr+XrjH0QcCRPRmILeVs+Dn oqa2tPocoWshMgCMDH0bKPJBoadoIqM6qmHlDv8kkxb2e X-Received: by 2002:aa7:9808:0:b0:5a8:51a7:a8d3 with SMTP id e8-20020aa79808000000b005a851a7a8d3mr3184658pfl.34.1676319816356; Mon, 13 Feb 2023 12:23:36 -0800 (PST) X-Google-Smtp-Source: AK7set/LQ6AMYqsGFlm5pOGaT8Qjpk/jYVL07Wda6kqv5EITWNNcC6eENLTsDETL6XZX9RMzl1lN9YHgiSav6uwrazc= X-Received: by 2002:aa7:9808:0:b0:5a8:51a7:a8d3 with SMTP id e8-20020aa79808000000b005a851a7a8d3mr3184656pfl.34.1676319816077; Mon, 13 Feb 2023 12:23:36 -0800 (PST) MIME-Version: 1.0 References: <20230128040601.2927632-1-amerey@redhat.com> <87a622itys.fsf@tromey.com> <87edran5qf.fsf@tromey.com> <87a61omd35.fsf@tromey.com> <871qmtwsx4.fsf@tromey.com> In-Reply-To: <871qmtwsx4.fsf@tromey.com> From: Aaron Merey Date: Mon, 13 Feb 2023 15:23:25 -0500 Message-ID: Subject: Re: [PATCH] gdb/debuginfod: Prevent prompt for continue during downloading. To: Tom Tromey Cc: Aaron Merey via Gdb-patches X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Mon, Feb 13, 2023 at 9:18 AM Tom Tromey wrote: > > >>>>> "Aaron" == Aaron Merey via Gdb-patches writes: > > Aaron> However the on-demand downloading work creates new situations where > Aaron> a large series of downloads might happen outside fetch_inferior_event. > Aaron> For example, "break client.c:50" could download the .debug_line and > Aaron> .debug_line_str of each shared library to search for the filename > Aaron> "client.c". Then it downloads debuginfo for each match, all of which > Aaron> happens outside of fetch_inferior_event. > > Aaron> Setting pagination_enabled=false in debuginfod_*_query prevents the > Aaron> prompt durings the downloads but lines_printed keeps increasing. > Aaron> If lines_allowed is exceeded then after the download you get an (IMO) > Aaron> annoying prompt: > > I think this is what the user has requested, though. > The pager can easily be disabled, but if we let code work around it, > there's not really any way to ask for it to be enabled again. Fair point, although some users (myself included) may want promptless debuginfod output without having to completely disable the pager. Maybe avoiding line counting in these cases should be done through 'set debuginfod verbose'? In any case I think the debuginfod_*_query functions should at least disable pagination. > Aaron> Adding a count_lines_printed flag gives us another way to fine-tune > Aaron> when the prompt shows up. It keeps prompt behavior around debuginfod > Aaron> output consistent whether or not the inferior is running. > > This is an internal distinction but it seems to me that to the user, gdb > output is just gdb output and can't really be differentiated by its > origin. Inconsistent behavior due to an internal distinction could make the behavior even more perplexing to some users. Aaron