From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 8D1913858D33 for ; Wed, 17 Jan 2024 17:50:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 8D1913858D33 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 8D1913858D33 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1705513812; cv=none; b=rZNZ4MTN3TMn0W9avSZuVAh7sd+fpulZ69RoXSuA7fnMgNji1dN4OjXBf9Vt+NN25W/oCk+5kPCuxpKOqdD72Gge7IKE5wo7yZD+5DUQm3rnXWxDp6H0UrxDRxwbpOM6OKs2yBooBUCjNQO+ffePMSzP9KF3Wh6G3JiL1G/AEkI= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1705513812; c=relaxed/simple; bh=d/Jj89W+GZXNq5QMrHfSqjnQG6pwl5e+g5FGmVinynw=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=NrQbXHZ+29Z7uO606kAF01ZhcKhjq0IURuuPJQL4jtzchV5Qzuxh888fKnavwYOjyxarxzKpKfDL4NPFhoEQENcEVy3Y087M4O/7G4omRsjb6VNOFOblWTkXCAzikTBu2rUQke4bzj4iZUmZ9Ofz0lI42yBHq9UbvBo4wPx+3QU= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1705513810; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=saVrrGALV+eGmwhRibFEDdLTeYyF9pMlMvswahJjF98=; b=f3huR6YkiJ+seqJFyc/04/ADxSv8W1+mh6/Od9x8EcEGrYmHTH2ruQ14JLKi+TGglkChU5 X+ilADnhYYnJWbVfcUC+9CvXQb137iw2AYEWTBmSYOJhD0UnY9ETnP0TZVkE6PnmsMnJq8 xoqrAxxnKzDic7ai95FzE7W9WylxDz4= Received: from mail-pj1-f71.google.com (mail-pj1-f71.google.com [209.85.216.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-619-CXqf3zVlMYeHYqELRAARFA-1; Wed, 17 Jan 2024 12:50:08 -0500 X-MC-Unique: CXqf3zVlMYeHYqELRAARFA-1 Received: by mail-pj1-f71.google.com with SMTP id 98e67ed59e1d1-28b88d79b87so7917154a91.1 for ; Wed, 17 Jan 2024 09:50:08 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705513807; x=1706118607; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=saVrrGALV+eGmwhRibFEDdLTeYyF9pMlMvswahJjF98=; b=eIdrlz90ArtwJ8YLthYYpvcaVLvd+JLs4Tmezpmu0EUotUJGeHeqOu9rVsoxkBgUi7 sBzQf8GmZ+l7Xun/adjEutI2rLmgVuT3S7Q7ePfYenUfpMSn0zzvPe9+o9PmK0phndp3 8Kd8WZK1VO5Okzo6LKVxrp+fGNk+RWX/ZCVNj7USdZvKoFUGOtNEbbs409oEAWFDDopX 7n9KaMbuzbllLyWiA2ZFf3Esx+bdWf3yKxqYZ3dIJ/J/ee7BfdNGr+c01Di5MgFdw6oP d8DdkVdQyGrdilHJV8nUJvNAn/xvP0n0gw3wg8bHiLqNa8A1zbRgajWouatX/knHqTeg IDoA== X-Gm-Message-State: AOJu0YzcskhaOVB174e/uiJhNBIP1jXUq9Wm6XMrsilh8OBBwVTp+SL6 Qtfp/JaYJ344zp75KW6ggMVwz3BMKGMST3UBTD7HlMRnMw6Gu7dnFvgLlM0m9iBnFzlQaKKJ8zX YEtdX99BaUAGin2Xr/sav5fFFVLvdQaS3/uLT2qRfE+Opwn6kWWSV1+8= X-Received: by 2002:a17:90a:fe0a:b0:290:1477:9a99 with SMTP id ck10-20020a17090afe0a00b0029014779a99mr100088pjb.71.1705513807091; Wed, 17 Jan 2024 09:50:07 -0800 (PST) X-Google-Smtp-Source: AGHT+IELCaXb3xJwdCL5lHUzSHfK01JhiUsEBw/V6yY/3Zu1QuDUhx5L/FpcPbIxMDq93TEoZdD6iemfHzigRnCZG0I= X-Received: by 2002:a17:90a:fe0a:b0:290:1477:9a99 with SMTP id ck10-20020a17090afe0a00b0029014779a99mr100081pjb.71.1705513806822; Wed, 17 Jan 2024 09:50:06 -0800 (PST) MIME-Version: 1.0 References: <20231028002008.1105723-1-amerey@redhat.com> <20231028002008.1105723-2-amerey@redhat.com> <87mstxexmg.fsf@linaro.org> In-Reply-To: <87mstxexmg.fsf@linaro.org> From: Aaron Merey Date: Wed, 17 Jan 2024 12:49:55 -0500 Message-ID: Subject: Re: [PATCH 1/4 v7] gdb: Buffer output streams during events that might download debuginfo To: Thiago Jung Bauermann Cc: gdb-patches@sourceware.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-6.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Thiago, On Tue, Dec 26, 2023 at 11:29=E2=80=AFAM Thiago Jung Bauermann wrote: > > Nice feature! Just a few small nits: Thanks for reviewing this patch set. I've updated the patch set with your suggestions. The revised patches have been posted here: https://sourceware.org/pipermail/gdb-patches/2024-January/205953.html > > --- a/gdb/testsuite/gdb.python/py-objfile.exp > > +++ b/gdb/testsuite/gdb.python/py-objfile.exp > > @@ -135,7 +135,7 @@ gdb_test "p main" "=3D {} $hex
" \ > > gdb_py_test_silent_cmd "python objfile.add_separate_debug_file(\"${bin= file}\")" \ > > "Add separate debug file file" 1 > > > > -gdb_py_test_silent_cmd "python sep_objfile =3D gdb.objfiles()\[0\]" \ > > +gdb_py_test_silent_cmd "python sep_objfile =3D gdb.objfiles()\[1\]" \ > > "Get separate debug info objfile" 1 > > Does the fact that this testcase needed change mean that there was an > API break? In my opinion it doesn't and this patch is ok. I think it > would be too much to guarantee a specific ordering of the returned > objfiles. > > But I'm mentioning it anyway because perhaps someone has a different > view? I agree that it's too much to guarantee a specific ordering of the objfiles list. I did not change objfile ordering in the revised patches. Aaron