From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id F2A613858405 for ; Thu, 24 Mar 2022 19:04:35 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org F2A613858405 Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-347-2Rivs95AM6CAQVbf-dI2BA-1; Thu, 24 Mar 2022 15:04:34 -0400 X-MC-Unique: 2Rivs95AM6CAQVbf-dI2BA-1 Received: by mail-qk1-f197.google.com with SMTP id c19-20020a05620a0cf300b005f17891c015so3674398qkj.18 for ; Thu, 24 Mar 2022 12:04:34 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=49TyuerRF2Qn5v467Qa4HuS6Kwad+Xj82oNtn8jc23s=; b=ZMymKvTrouAtYM3pTCbEb/9MND8jil5QIUqvJ+v2qT3oKYOOvlq4LW0mT+YGRdVnBD ZzghsEVMDecIUCWYpooiWqCrJCjGxpgZBMLXFr7QExDXjTlIEuUcFhGs3EXvscFhmSph +AdvFUSay9cjNi9q2W2WzlkVM2iblTgGg+JYOm7vLfzUn5YXWNFapSfhnexfyVOMrMmY cU7amW+/goRYsIktK2tgC5+6TJAcXRg84D7ogoDgSdGnNUS1ockAMJ/8xLYXspPOqmuG uP8Q6PAcDtGdnm+PraL3heTmsJP07GiduRCbrU6JrMeOvAcyYfda990PsTCtHdtQ/TVF XuPA== X-Gm-Message-State: AOAM5329paTFQrjPpA/g5cpPGsyQMo0G/7YLqF7/wGeHrDOs8f9tyIF8 OnCL1dd6qeBnlK5sLbp/A7ckCsX/4lDShvZUiQZ5qvqHGHXw0g9Vxl7Klcv7VBvMiDqXY9sDXDb kcSlk/LgdZ2hy56qoS59RzQPI6ZNnA13Lh3V5 X-Received: by 2002:a05:620a:1181:b0:60d:f3ab:595f with SMTP id b1-20020a05620a118100b0060df3ab595fmr4144926qkk.275.1648148673655; Thu, 24 Mar 2022 12:04:33 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyZspJiVmN5lF/T6R+LQxqIMCizPX3IvMpfwqgx8+Ar+KhuNmeY1v9r02mFSEIIPtADp+Rfvgf9BZHMqzsECms= X-Received: by 2002:a05:620a:1181:b0:60d:f3ab:595f with SMTP id b1-20020a05620a118100b0060df3ab595fmr4144899qkk.275.1648148673239; Thu, 24 Mar 2022 12:04:33 -0700 (PDT) MIME-Version: 1.0 References: <5ed305d0-3650-a9f9-e128-22f873cd96a0@redhat.com> <20220323180616.29957-1-amerey@redhat.com> In-Reply-To: From: Aaron Merey Date: Thu, 24 Mar 2022 15:04:22 -0400 Message-ID: Subject: Re: [PATCH] Remove download size from debuginfod progress messages To: Simon Marchi Cc: Keith Seitz , gdb-patches@sourceware.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-6.1 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 Mar 2022 19:04:37 -0000 Hi Simon, On Thu, Mar 24, 2022 at 11:26 AM Simon Marchi wrote: > I'm fine with an interim patch, but I'd really like to see the progress > bar back, I enjoy it :)! > > I haven't been involved in those dicussions so I don't know what the > plan is. But typically progress bars have an "undefined total" mode > where you can still tell that the operation is progressing (bytes are > being received), you just don't what percentage of the total. That is probably what we'll end up doing. The progress bar will return! > But really, is it a problem for GDB master to print "~0.00 MB", until > the "real" fix is merged? It's not like it's causing a crash or > anything like that? Or is it something you want to push to the GDB 12 > branch? We received a request to fix this issue and thought it would be best to patch it here first before addressing it downstream. > The patch LGTM in any case, if that's the route you want to take. Thanks. Pushed as commit b0e0d830d9. Aaron