From: Aaron Merey <amerey@redhat.com>
To: Bruno Larsen <blarsen@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] gdb/linespec.c: Fix missing source file during breakpoint re-set.
Date: Thu, 13 Oct 2022 20:47:50 -0400 [thread overview]
Message-ID: <CAJDtP-Q__ka2azo3g3+xgHf-=eHviCpMrJ7JMXKV8sNrruaKkQ@mail.gmail.com> (raw)
In-Reply-To: <c2c9851e-1760-ea7f-f2d5-85804bdb8525@redhat.com>
On Thu, Oct 13, 2022 at 3:59 AM Bruno Larsen <blarsen@redhat.com> wrote:
> extra ']' at the end
>
> Also, would be nice to have a small comment mentioning that there could
> be an error when resetting the breakpoint, so we have some context when
> looking at this test in the future.
>
> With these changes, I'm ok with the patch going in, but I can't approve
> it for pushing. Don't forget to add the tag to the commit :)
>
> Reviewed-By: Bruno Larsen <blarsen@redhat.com>
Thanks Bruno, fixed.
next prev parent reply other threads:[~2022-10-14 0:48 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-07 23:44 Aaron Merey
2022-10-10 16:06 ` Bruno Larsen
2022-10-12 20:49 ` Aaron Merey
2022-10-13 7:59 ` Bruno Larsen
2022-10-14 0:47 ` Aaron Merey [this message]
2022-10-21 17:07 ` Aaron Merey
2023-01-06 23:56 ` [PING*2][PATCH] " Aaron Merey
2023-01-09 19:27 ` Tom Tromey
2023-01-10 1:15 ` Aaron Merey
2023-02-01 17:37 ` Andrew Burgess
2023-01-09 19:27 ` [PATCH] " Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJDtP-Q__ka2azo3g3+xgHf-=eHviCpMrJ7JMXKV8sNrruaKkQ@mail.gmail.com' \
--to=amerey@redhat.com \
--cc=blarsen@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).