From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 69CF23858C56 for ; Fri, 14 Oct 2022 00:48:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 69CF23858C56 Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-672-W05o5ILUMxy3jYkPewOdlw-1; Thu, 13 Oct 2022 20:48:03 -0400 X-MC-Unique: W05o5ILUMxy3jYkPewOdlw-1 Received: by mail-wm1-f72.google.com with SMTP id i64-20020a1c3b43000000b003c6d18a7ee5so357954wma.6 for ; Thu, 13 Oct 2022 17:48:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Vh5ehIZaEMCDgNSxUp59rQ6eQbRkWvYDPiNZ0Alf6hA=; b=kVb9lW0P3N+hd3VfmAFPXgOVm6I7At/Uf/oIP2w9ITOMfoF57+/dl5+e/Ds+tvXhAo bAULRzek/WmyiLymK7V2j7CJnCoKSW7yGYZz1W2cnGWRCQ2r5LhoOX62FROuFTqqxLJU P0X+DvvX6gexqi0f/Eno+hIVTUAnKub6ijV9YEglhzq9PngGHYWUb0GTp47CfiSIrvWd 5J1fFJpKb4UBOrDIOwrY2SuuaHcu6qnV951rvyhwjebgp3jMTxXC9HeGniTzM/XYrvbm +ds8acYmMuE9TVfnKTBBu6ljgwjsEinYJDMQg5M+6uyOvB1FS2eNIs60Nd6V5hBm+z4q BVsA== X-Gm-Message-State: ACrzQf1w7dZwFhwnsnZRJUDqX+/qU2mcIgW9GPb3J+WyYckh4J075a+k x8Q8MG++j+YGxXD/LQ7Oejh7UoSf0vkr0tn9pSP5DTc7U1V/mc3FLjj9K5HPgytGetWGH9PJS7j t3eMQALQLu+CCM0Jh8ghQcgqLNrAWnJMomFjV X-Received: by 2002:a05:600c:1c08:b0:3c6:e398:64e0 with SMTP id j8-20020a05600c1c0800b003c6e39864e0mr1634522wms.2.1665708482299; Thu, 13 Oct 2022 17:48:02 -0700 (PDT) X-Google-Smtp-Source: AMsMyM67Le5I63lVSFXZEGcRy+ClkFjG7VWiSrAi3b1+A192eWzWtLLG9oLV/17Tv7vIhtT/r5zcTv+kuCHRqZ4qRlw= X-Received: by 2002:a05:600c:1c08:b0:3c6:e398:64e0 with SMTP id j8-20020a05600c1c0800b003c6e39864e0mr1634517wms.2.1665708482074; Thu, 13 Oct 2022 17:48:02 -0700 (PDT) MIME-Version: 1.0 References: <20221007234428.12845-1-amerey@redhat.com> <20221012204916.467707-1-amerey@redhat.com> In-Reply-To: From: Aaron Merey Date: Thu, 13 Oct 2022 20:47:50 -0400 Message-ID: Subject: Re: [PATCH] gdb/linespec.c: Fix missing source file during breakpoint re-set. To: Bruno Larsen Cc: gdb-patches@sourceware.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-5.3 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 14 Oct 2022 00:48:06 -0000 On Thu, Oct 13, 2022 at 3:59 AM Bruno Larsen wrote: > extra ']' at the end > > Also, would be nice to have a small comment mentioning that there could > be an error when resetting the breakpoint, so we have some context when > looking at this test in the future. > > With these changes, I'm ok with the patch going in, but I can't approve > it for pushing. Don't forget to add the tag to the commit :) > > Reviewed-By: Bruno Larsen Thanks Bruno, fixed.