From: Aaron Merey <amerey@redhat.com>
To: Andrew Burgess <aburgess@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 3/6 v4] gdb: Buffer output streams during events that might download debuginfo
Date: Fri, 7 Jul 2023 21:19:02 -0400 [thread overview]
Message-ID: <CAJDtP-QzvVPcdmLbmqG+UFubQ2uR5rD9e9MExU=0GJWkGC7Pew@mail.gmail.com> (raw)
In-Reply-To: <871qhjls85.fsf@redhat.com>
Thanks Andrew, I'll post a revision with the tweaks you suggested.
On Fri, Jul 7, 2023 at 10:19 AM Andrew Burgess <aburgess@redhat.com> wrote:
>
> > +/* On construction, redirect gdb_stdout and gdb_stderr to buffer_files.
> > + Replace occurances of gdb_stdout and gdb_stderr in M_UIOUT with these
> > + buffer_files. On destruction restore M_UIOUT, gdb_stdout and gdb_stderr. */
> > +
> > +class ui_out_buffer_pop
>
> I confess that I've confused by this name. What does the 'pop' mean here?
I was trying to convey that this object handles the insertion and
removal (pop) of buffer_files from the given ui_out. There is a similar
object ui_out_redirect_pop that I modelled this name after.
Aaron
next prev parent reply other threads:[~2023-07-08 1:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-09 0:02 Aaron Merey
2023-07-03 17:38 ` [PING][PATCH " Aaron Merey
2023-07-07 14:19 ` [PATCH " Andrew Burgess
2023-07-08 1:19 ` Aaron Merey [this message]
2023-07-19 14:32 ` [PING*2][PATCH " Aaron Merey
2023-08-02 15:50 ` [PATCH " Andrew Burgess
2023-08-04 0:10 ` Aaron Merey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJDtP-QzvVPcdmLbmqG+UFubQ2uR5rD9e9MExU=0GJWkGC7Pew@mail.gmail.com' \
--to=amerey@redhat.com \
--cc=aburgess@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).