From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 2FD703858CDA for ; Tue, 10 Jan 2023 01:16:03 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 2FD703858CDA Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1673313362; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=4IZ1V1oftVAeVq45heJ2QXxiaoCVumb2vwqhJEFaXlM=; b=UBlTttdKXyzzYxedbEvPexz42C0+OAOVHLAEYrz6QV/9qQf+1uqA+3Ewg6wqTcPvyH3Pel IHt+C8ZtmeQOfb9ALFCWgveMOF/IvT2BT11yyhmH4Rm20YpC24QCvPlgXT+mZjP3O7SDDT PZwB0ogfENOwpsT8imbdzXS2hqoIUdY= Received: from mail-pf1-f199.google.com (mail-pf1-f199.google.com [209.85.210.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-549-qFXxEP2qP9SN5RkVWtmDYw-1; Mon, 09 Jan 2023 20:16:01 -0500 X-MC-Unique: qFXxEP2qP9SN5RkVWtmDYw-1 Received: by mail-pf1-f199.google.com with SMTP id bq10-20020a056a000e0a00b00581221976c0so4308765pfb.10 for ; Mon, 09 Jan 2023 17:16:01 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=4IZ1V1oftVAeVq45heJ2QXxiaoCVumb2vwqhJEFaXlM=; b=sTReixpdKQBGDQ1rk6PYJEAk2eHU8qI/QlD9vqSKLMkdEvyXop/cqYIi6Jjzwa/f71 Ma43ATFmYCBqZZSi5ydW4J27xgHfplb6QSex9SvlpIc1rMqDvekYd1NuulJiWYWRxkn0 ACKVa9N2w6YLm7RZGkb+mLUFt8S45qDgSu1/v+Tp0Pc952mKFEPLYOahVtroZCR9qbmp WHIHpV/gQM59P/f/MWCNw7nS2qbdJW8ooCgFAV8qtR6ITuX9pDziOEWnuG1VtyuQiryN MTag3wv6f5FlDdGwwlXv7G2gapCD6Rff8QtVV9g7H8KBvDFEkmU8HTIvzcgE1Xd/B+i0 py+w== X-Gm-Message-State: AFqh2kocP98h2YgTxn/edoX5MnU3A9GkraXyD7PbH45AEidcn1/xku79 GznvoCwDrLIkcY4z5A6dlfdFm9OykK98mh77/ZrISkKnlIyDfiTwy0/oijzgORPsy9l8zGitA+z 3hlpUktQyCgyMFqzY2jbXeLbDOb3zzQjKP1+W X-Received: by 2002:a17:902:b94b:b0:189:d2e4:a8eb with SMTP id h11-20020a170902b94b00b00189d2e4a8ebmr5071055pls.167.1673313360418; Mon, 09 Jan 2023 17:16:00 -0800 (PST) X-Google-Smtp-Source: AMrXdXtYzk0CNZ3erssddIoGh9QcbLavF5kGKxIJumdRQ2LhRFfuGqGfrmWINmGHsIbSAsZgrvXeUcZ5biBGwtD9MNc= X-Received: by 2002:a17:902:b94b:b0:189:d2e4:a8eb with SMTP id h11-20020a170902b94b00b00189d2e4a8ebmr5071052pls.167.1673313360157; Mon, 09 Jan 2023 17:16:00 -0800 (PST) MIME-Version: 1.0 References: <20221021170720.27249-1-amerey@redhat.com> <20230106235607.498218-1-amerey@redhat.com> <87y1qb8q4m.fsf@tromey.com> In-Reply-To: <87y1qb8q4m.fsf@tromey.com> From: Aaron Merey Date: Mon, 9 Jan 2023 20:15:49 -0500 Message-ID: Subject: Re: [PING*2][PATCH] gdb/linespec.c: Fix missing source file during breakpoint re-set To: Tom Tromey Cc: Aaron Merey via Gdb-patches X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-5.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Mon, Jan 9, 2023 at 2:28 PM Tom Tromey wrote: > Oops, I reviewed the wrong version. > This one is ok. Thank you. Thanks Tom, pushed as commit 7dd38e31d67. On Mon, Jan 9, 2023 at 2:27 PM Tom Tromey wrote: > It's pretty hard to review a patch like this, since it's hard to know > what impact it might have. However I am mostly fine with it (see the > end), assuming you regression-tested it. Regression tested on x86_64 F36 and F37. Aaron