From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) by sourceware.org (Postfix) with ESMTP id 0A193386F002 for ; Mon, 27 Jul 2020 16:11:17 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 0A193386F002 Received: from mail-vs1-f69.google.com (mail-vs1-f69.google.com [209.85.217.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-171-9x5uw4zmPhq9-OkLMklJrw-1; Mon, 27 Jul 2020 12:11:12 -0400 X-MC-Unique: 9x5uw4zmPhq9-OkLMklJrw-1 Received: by mail-vs1-f69.google.com with SMTP id w8so774805vsl.21 for ; Mon, 27 Jul 2020 09:11:12 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=yl36WutfoRs9XjKbGpmWAHBn0fwWKP8r3SXNNHULfJc=; b=YVigL8jv2qfYDNmBBLs0o/Xqb7pDeGrvP09PbNw5RNAGkl52VWbOQHGuDY6HpRF+k4 9KsEjBZZTw9NqUAGUJanKBCIZ5E4BnEtPWkofkfMOWRUPi6ugNEVcqNFR1gTszWLb/vM hOBddqXfyxf9IGvcZBcwLf0GY9Jov2b8NmafqApzwdxqL2ADy86w0PcVMHu9Xbz0j9QY phakVn5ouz3KOcsQIjVO/QpGkgSdtyZoF1nBYw2VHX/YzZ3P1BhbLMFKQJbUp9eCARZk FkZtwJhN7cp0t6NuWa6PCdA24YAdMTmXTS8bFUV/miiUeWW+ujWk3jnzdRCU8gbhOvGB GvJg== X-Gm-Message-State: AOAM531X1gr22ZdE9yxxEydVROotBw9JlvVzV7ooLynnlnkbf1o6TFVN dzEOjSFNGWGVIhmePXgfAHW9N40H4JXZ/wUWfWqsn6QwJkLw4AjIjB5e5Z8gDRpHObDPdw2+sBF 2VJqv11T41Wp562MnYGuajLeUkYjgezK7kLOd X-Received: by 2002:ab0:348c:: with SMTP id c12mr17216422uar.89.1595866272425; Mon, 27 Jul 2020 09:11:12 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwpGx3klyI/l6YQHCHzFq6KV2HXvprBmFAAcrA/s4Nx+qL5+iO9pLKUxpp0wnVB0MTWdEMUMl8BJxeLRyJhw5w= X-Received: by 2002:ab0:348c:: with SMTP id c12mr17216404uar.89.1595866272185; Mon, 27 Jul 2020 09:11:12 -0700 (PDT) MIME-Version: 1.0 References: <20200502022903.175852-1-amerey@redhat.com> <3d9da16939fa6b503188033b56d30531e03d5d2a.camel@redhat.com> <87a72ino27.fsf@tromey.com> <64517fee-8b8f-84b2-a116-c3d146ff1119@simark.ca> <87eep4hp3s.fsf@tromey.com> In-Reply-To: From: Aaron Merey Date: Mon, 27 Jul 2020 12:11:01 -0400 Message-ID: Subject: Re: [PATCH] config/debuginfod.m4: Restore AC_CHECK_LIB check To: "H.J. Lu" Cc: Tom Tromey , Simon Marchi , GCC Patches , Aaron Merey via Binutils , GDB X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=unavailable autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 27 Jul 2020 16:11:18 -0000 On Mon, Jul 27, 2020 at 11:32 AM H.J. Lu wrote: > > On Sat, Jul 25, 2020 at 9:01 AM H.J. Lu wrote: > > This caused: > > > > https://sourceware.org/bugzilla/show_bug.cgi?id=26301 > > > > It is quite normal to have debuginfod headers without libdebuginfod on > multilib OSes. Restore AC_CHECK_LIB to check if libdebuginfod exists. > And always define HAVE_LIBDEBUGINFOD to 0 or 1 for > > binutils/dwarf.c:#if HAVE_LIBDEBUGINFOD > binutils/dwarf.c:#if HAVE_LIBDEBUGINFOD > binutils/dwarf.c:#if HAVE_LIBDEBUGINFOD > binutils/dwarf.h:#if HAVE_LIBDEBUGINFOD > binutils/objdump.c:#if HAVE_LIBDEBUGINFOD > binutils/objdump.c:#endif /* HAVE_LIBDEBUGINFOD */ > binutils/readelf.c:#if HAVE_LIBDEBUGINFOD > binutils/readelf.c:#endif /* HAVE_LIBDEBUGINFOD */ > gdb/top.c:#if HAVE_LIBDEBUGINFOD > > OK for master? Thanks for spotting this. Normally PKG_CHECH_MODULES would correctly detect whether the .so and header are installed and build accordingly, but when cross compiling the AC_CHECK_LIB may be needed. Aaron