From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 3B6BB385E004 for ; Mon, 21 Mar 2022 18:21:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 3B6BB385E004 Received: from mail-yb1-f197.google.com (mail-yb1-f197.google.com [209.85.219.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-639-QkCDC-V-PkenBmKA6MUzXw-1; Mon, 21 Mar 2022 14:21:52 -0400 X-MC-Unique: QkCDC-V-PkenBmKA6MUzXw-1 Received: by mail-yb1-f197.google.com with SMTP id k13-20020a25c60d000000b006339008b92fso11918692ybf.1 for ; Mon, 21 Mar 2022 11:21:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=eQTdoRSrkxryp+remMPgPYZDeMGeWN9S/kydZzIiv3Y=; b=dYXrgjIbzDV8Mt/l31kBfk6CG0o4XXGAq5kcH0OUUB1P0oCUUbeR9/tXWUVZr2M26B rHzf3TTwwlYIUOMU9QIsfpB+V54Id5VPgQ7s6I442O9NiG1nHiCuj9Hu20loyRKyd7Iy 80qUDbkDxozZMhimTsQ1DOUgy1VrX1rKg9ywtEEVYYXRAVavNaIxpefcCZ+86aNJXNNI j43M3RiuEnOxkLPRcs/1cCVKfdcqzTR1nvmZPhFFvbfomneGAZPqbkvR+AJaSXRzuix7 X/oTDutWw6m8wFDru+GJxu6h+wyg996SGDpXAW7o60znZLADzJMJf8Jh6gfQmI42zNP6 yn8A== X-Gm-Message-State: AOAM533B0crhImcFwI6QV5J9b3BBCjuozEEFeUo8vO10SXZD6BkHgtOe PvCCIOljjc54su7W3L3Z21+hROi6BKUoySumyO4etONin0ePhZcjKW76RrYbk79gq8UAcqZrKiL mzZ3rYsdx7G50GDPSBzt+z1vthrtnK+o5qq+E X-Received: by 2002:a5b:dc8:0:b0:624:a898:dea6 with SMTP id t8-20020a5b0dc8000000b00624a898dea6mr22712342ybr.600.1647886912016; Mon, 21 Mar 2022 11:21:52 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz+08p4jo/cNk5vMb5sj1QL5dDyI1dW9DJoRC8RK1IYta9kebOUs9OQxHZXFjW0ATZUjroj6cecrpc0IICoHJo= X-Received: by 2002:a5b:dc8:0:b0:624:a898:dea6 with SMTP id t8-20020a5b0dc8000000b00624a898dea6mr22712324ybr.600.1647886911809; Mon, 21 Mar 2022 11:21:51 -0700 (PDT) MIME-Version: 1.0 References: <877d90ms1o.fsf@tromey.com> <20220311214438.120149-1-amerey@redhat.com> <8735jfhymw.fsf@tromey.com> In-Reply-To: <8735jfhymw.fsf@tromey.com> From: Aaron Merey Date: Mon, 21 Mar 2022 14:21:41 -0400 Message-ID: Subject: Re: [PATCH 1/2] gdb: Add soname to build-id mapping for core files To: Tom Tromey Cc: Aaron Merey via Gdb-patches , Andrew Burgess , lsix@lancelot.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-6.1 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Mar 2022 18:21:55 -0000 On Fri, Mar 18, 2022 at 3:03 PM Tom Tromey wrote: > > >>>>> "Aaron" == Aaron Merey via Gdb-patches writes: > > Aaron> Added a check to make sure \0 exists between the start of the soname > Aaron> and the end of the section. > > Aaron> I also replaced basename with lbasename in get_cbfd_soname_build_id. > > Thanks, I think this is ok. Thanks, pushed as commit 39f53acb41 Aaron