From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id A38D33858D35 for ; Tue, 23 May 2023 15:14:13 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A38D33858D35 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1684854853; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=V3mcSYEkamUJR4NL/0eQmpeTnXnlqW1JHcM1ax5gGTI=; b=aaKng9sa67hFIOM10rgRgF2wcLA7LO29LBB490jLUEAerREeM2NUKU6MjRBP91RRfD1qKX 86XRoruAynbPs8320+OCVzDjufoR56x6lmhXK59baGZaJ1wq3sTorcJBlTbjcZEzIkqTVg VhTp+LAfSnP8JzxsV/kldCpO4W+JNNM= Received: from mail-pj1-f70.google.com (mail-pj1-f70.google.com [209.85.216.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-58-YI1iO1v4NDOVHCUTXhufsw-1; Tue, 23 May 2023 11:14:12 -0400 X-MC-Unique: YI1iO1v4NDOVHCUTXhufsw-1 Received: by mail-pj1-f70.google.com with SMTP id 98e67ed59e1d1-25338b76f79so4105420a91.3 for ; Tue, 23 May 2023 08:14:11 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684854851; x=1687446851; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=V3mcSYEkamUJR4NL/0eQmpeTnXnlqW1JHcM1ax5gGTI=; b=k7G0i3Uo+otJwAefxu/SiynuyCUf0/C5b49YutL0bGdbi7/l/xdjCJWe7cKnrIMD2O 565VLjbJAzp5aL8wt5ye3je/ChnMrzoIjhi46yDnm4u624yxFYuYzhPO7HDPZnPUn7Jh Di0DneiInTv+uvjwY7PQafkz+bu1zxWD9m0NfxVEx1YPMxd3Eyu6v3/xRI1IPBHmL4t4 2yOIPlYB5KlRNUA0oaYe8XwG1GX0NFbQ1auYS9/Dk1mMH8dTlFsJ7tBKaCgvywZy+2px PWRxf1cyiE2uyqsiBPB3CfYeLYCozI8w2ExaodPBahJShywsG/3uEDdC4JI6orG1Taq1 38Pw== X-Gm-Message-State: AC+VfDzRU9QrZkXmhGuAPEmLSWP991iJxxL/G/rr5dg2G1neIqyYjmPE 2tBsQAvidfZOG8ugCzTqC9M+aSXedfRXgM/bhnvOqVSopr1R67vSSAKFJUYQGjdTKqjAA7dpLa6 uBHe8WszF6f2FpcxLyaWVwXsOMecGg3augBAOAFp5gQepPNY= X-Received: by 2002:a17:90a:d681:b0:255:c829:b638 with SMTP id x1-20020a17090ad68100b00255c829b638mr469226pju.9.1684854850767; Tue, 23 May 2023 08:14:10 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4+p36/qcJiB5C+Bk0YPGg1AMecMO8Gz+M+pO0GNmYlRSGCA2CRP890HNtfPlEmIFBSWsp21AV15kKyTxpHm4s= X-Received: by 2002:a17:90a:d681:b0:255:c829:b638 with SMTP id x1-20020a17090ad68100b00255c829b638mr469212pju.9.1684854850457; Tue, 23 May 2023 08:14:10 -0700 (PDT) MIME-Version: 1.0 References: <831qjh104j.fsf@gnu.org> <20230519213824.117794-1-amerey@redhat.com> <831qjbtuy4.fsf@gnu.org> In-Reply-To: <831qjbtuy4.fsf@gnu.org> From: Aaron Merey Date: Tue, 23 May 2023 11:13:59 -0400 Message-ID: Subject: Re: [PATCH] gdb/cli-out.c: clear_current_line shouldn't trigger pagination prompt To: Eli Zaretskii Cc: gdb-patches@sourceware.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Sat, May 20, 2023 at 1:47=E2=80=AFAM Eli Zaretskii wrote: > > > From: Aaron Merey > > Cc: gdb-patches@sourceware.org, > > Aaron Merey > > Date: Fri, 19 May 2023 17:38:24 -0400 > > > > On Mon, May 15, 2023 at 10:27=E2=80=AFPM Eli Zaretskii w= rote: > > > > > > > From: Aaron Merey > > > > Date: Mon, 15 May 2023 17:32:48 -0400 > > > > Cc: gdb-patches@sourceware.org > > > > > > > > > I'm not sure we should rely on the fact that the final character = of > > > > > the line is never there. clear_current_line is a general-purpose > > > > > method, so it should do its job regardless. > > > > > > > > > > Can't we do something to handle the last character as well? E.g.= , > > > > > could it be possible first to delete one character, so there are > > > > > really only N-1 characters to fill with blank spaces? > > > > > > > > We could rename clear_current_line to something like clear_progress= _notify > > > > to help indicate that this is a special purpose function. We could= also > > > > just disable pagination for the duration of clear_current_line. > > > > > > I think we should do both, thanks. > > > > I revised the patch with clear_current_line renamed to clear_progress_n= otify. > > This function has been changed back to overwriting an entire line with = whitespace > > and pagination is disabled for its duration. > > Thanks. > > Acked-by: Eli Zaretskii Thanks Eli, merged as commit 6aebb6e100fb3c Aaron