From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id 0C2F8385E000 for ; Thu, 6 May 2021 17:28:00 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 0C2F8385E000 Received: from mail-vs1-f71.google.com (mail-vs1-f71.google.com [209.85.217.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-546-xD7oVqfmNpm5LW9TZkNEew-1; Thu, 06 May 2021 13:27:57 -0400 X-MC-Unique: xD7oVqfmNpm5LW9TZkNEew-1 Received: by mail-vs1-f71.google.com with SMTP id s26-20020a67c39a0000b02902274964b0a0so3048484vsj.19 for ; Thu, 06 May 2021 10:27:57 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=YXyIKMgEXJfcZPZ0sI/SGX1OZrx6SmxFj4zRmnVEeco=; b=R+QRTOuWkbEJWpfdQ/riZRgEmfgDsXJhtpna+qojTsfl89F9bPVTJhYCFc7sEVsHac BWj4iaC3vRJwOVu0Ao3o5a0l2sfskAZZ6GwEao4TZKveL3X1P/tNv5qEPJKqJIW63+Vc FdZmkekj2uBbLcPqMnM1FfBMylugSfJgP+1w9fwyeGdgqsYqiDvg5jYLDiTiY0ydya9B l3hPh0vArKRX4GrtpZmJ+AhooRyiKDbrX2961VmO8agleTXNPOmJKUWAImtM6NJ68bcC YkSR6NX5Is6UFwmRSDweKYA+49zPIc0FB/1odxBOn/FsMBJHe3pdAMSlCy/1YrhscGij uNOw== X-Gm-Message-State: AOAM532WGaGht5pdkkPrz9vA6phe1/xtKNDkGQfASFqnBawbgP9cLoyX MA5QBgaG3qk/Lsg9A2dIwZKJchpMtiEDkmKEHJSPYuwb/XZ12y7+L3SH7eUtlbzRO/mvH5ux+jS 14tGWHYrygFQXIxCK5skNZ6j+oZ/D6BS6MJAj X-Received: by 2002:ab0:77c1:: with SMTP id y1mr5356974uar.89.1620322077198; Thu, 06 May 2021 10:27:57 -0700 (PDT) X-Google-Smtp-Source: ABdhPJydcF+EjHS/VP0dgIqE5oWxazszY0JjrSZbXf1aQhIZFnC97YmJ8YatWGI2/Xcc5+0wEDOpErjkBaoc5tLURYs= X-Received: by 2002:ab0:77c1:: with SMTP id y1mr5356954uar.89.1620322077013; Thu, 06 May 2021 10:27:57 -0700 (PDT) MIME-Version: 1.0 References: <20210430235735.1371915-1-amerey@redhat.com> <87eeek1y07.fsf@redhat.com> In-Reply-To: <87eeek1y07.fsf@redhat.com> From: Aaron Merey Date: Thu, 6 May 2021 13:27:46 -0400 Message-ID: Subject: Re: [PATCH] debuginfod-support.c: Use long-lived debuginfod_client To: "Frank Ch. Eigler" Cc: Tom Tromey , gdb-patches@sourceware.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-5.4 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 06 May 2021 17:28:02 -0000 On Wed, May 5, 2021 at 8:56 PM Frank Ch. Eigler via Gdb-patches wrote: > > Will there ever be a need to finalize this object? Like, shut it down > > cleanly in some way? > > Nope (except perhaps if running gdb under valgrind?). Running gdb under valgrind appears to work properly and no debuginfod-related leaks are reported. If there aren't any other concerns then I will merge this patch with Tom's suggestion to define global_client in debuginfod_init() included. Aaron