From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id AC46D385C6FF for ; Mon, 2 Oct 2023 18:07:23 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org AC46D385C6FF Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1696270043; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=GeZtbfM58Nne5yFFyfHxeEDHW/wWSTv4MeO1FkWGMWQ=; b=DEYxyLX8EZGGeKuqrmNyadOcL6OM384ouZir+VFxRfNguQHcb0jexEZpprTUTkI58AHSjH XdKZr2GTYJkh4M2YyI8WrrnezGDxVpITMgtxdoktmzi6mjHK4MQEQR37kpQLvVx3OnEkUh dI9xZx4BydSkeh64HqMQEWRs43C9T0o= Received: from mail-pj1-f72.google.com (mail-pj1-f72.google.com [209.85.216.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-382-6QfGdmbWNYOm5SNlNdDtTg-1; Mon, 02 Oct 2023 14:07:22 -0400 X-MC-Unique: 6QfGdmbWNYOm5SNlNdDtTg-1 Received: by mail-pj1-f72.google.com with SMTP id 98e67ed59e1d1-2791b8181ffso36219a91.3 for ; Mon, 02 Oct 2023 11:07:20 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696270040; x=1696874840; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=GeZtbfM58Nne5yFFyfHxeEDHW/wWSTv4MeO1FkWGMWQ=; b=e8g1jmA4lzwnslKTYtAM+WTiLPt5OHvaBwg13WjbDGiEddRMxDlraqu7EdMkanhwTh i6RZGONNMWC5Jlq11vXF94LDnNaK+mY6Qg18U41N/zgzMqdICb1IaFLZoaQlUiwKteHm ypKoUg8TzVp6EVl9aXVoQRZxyERES0rJMPOfElg+O1Pdmc/XFtb/6oRvtTWH4SQoONKQ kIKrvNFoygsuluISCYYMkAG7ofHWUfTA/xWtqNDFbgjy7/t0Ttj0Lxj614tNu0N3zxt9 hPxpDYsVtAxdN52xb6i45Iz7qpSOJ+R/68PWdVA0un0CbqNQe03TR3MwCvvHbenF2CLj 9MZg== X-Gm-Message-State: AOJu0YwN3IXWBjTsUGCxtdNLYubtHleCADKXnwK68SQRgbFcAu0pc1FM DnJ8AvE0/GNopMy6Gw2QjQQ7IH4OpsNvb8v3+uuHZqPjhFKX3CKSQCjcMJS/S7/GxZRax6ooz4s sMjougqhYI8mf0JybpwGJbfiRHWTsHIFdecArZAIz6PwTGFA= X-Received: by 2002:a05:6a20:4327:b0:160:58f5:693b with SMTP id h39-20020a056a20432700b0016058f5693bmr11087543pzk.44.1696270039757; Mon, 02 Oct 2023 11:07:19 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFSCL+j5/dbuDU2VLoge4OzM38EKQFUyRLdO5xdF1iBmGkqS0eTaiB5Wv0d2O/ZsZBOdvBytn+NyBRdOFQfECU= X-Received: by 2002:a05:6a20:4327:b0:160:58f5:693b with SMTP id h39-20020a056a20432700b0016058f5693bmr11087522pzk.44.1696270039343; Mon, 02 Oct 2023 11:07:19 -0700 (PDT) MIME-Version: 1.0 References: <20230816044259.2675531-1-amerey@redhat.com> <20230816044259.2675531-3-amerey@redhat.com> <87y1gqup8t.fsf@redhat.com> In-Reply-To: <87y1gqup8t.fsf@redhat.com> From: Aaron Merey Date: Mon, 2 Oct 2023 14:07:08 -0400 Message-ID: Subject: Re: [PATCH 2/7 v3] gdb/debuginfod: Add debuginfod_section_query To: Andrew Burgess Cc: gdb-patches@sourceware.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-5.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Thu, Sep 28, 2023 at 2:28=E2=80=AFPM Andrew Burgess wrote: > > Aaron Merey writes: > > > > +scoped_fd > > +debuginfod_section_query (const unsigned char *build_id, > > + int build_id_len, > > + const char *filename, > > + const char *section_name, > > + gdb::unique_xmalloc_ptr *destname) > > +{ > > +#if !defined (HAVE_LIBDEBUGINFOD_FIND_SECTION) > > + return scoped_fd (-ENOSYS); > > +#else > > + > > + if (!debuginfod_is_enabled ()) > > This line is under-indented by one space :) > > Otherwise: > > Approved-By: Andrew Burgess Thanks, pushed as commit 8546d15b Aaron