From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 7804E3857BB2 for ; Tue, 11 Jul 2023 15:00:24 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7804E3857BB2 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1689087624; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+l9xGIwzFai3gNO1CnqA8aGuobdwANw4tpbGT+PDyXA=; b=ccLCrTMgctVWnyThyFzPCBi4pbLpJMOCMzT95zeBgMGg+eYoqbc0YDo2eIn7OpkmkISi4i 7a22Am+AdMbTRr6aITf9QYAPXQbS57x6qt3vgOftIwitwExjnNiNPtr8o94/Zcp/NSJSP6 pWaq9kRLFkme0FALjzdTnrBElz5/Xdk= Received: from mail-pj1-f69.google.com (mail-pj1-f69.google.com [209.85.216.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-352-XNu7YAufOZ6JifBoHe2nyA-1; Tue, 11 Jul 2023 11:00:21 -0400 X-MC-Unique: XNu7YAufOZ6JifBoHe2nyA-1 Received: by mail-pj1-f69.google.com with SMTP id 98e67ed59e1d1-262c77ffb9dso8835387a91.2 for ; Tue, 11 Jul 2023 08:00:20 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689087620; x=1691679620; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=+l9xGIwzFai3gNO1CnqA8aGuobdwANw4tpbGT+PDyXA=; b=JeIJjuXzEDkugcclm3t48J3rjt5cmUqjzuVwc883/LCStuLAGhMdhT54JWngLV01gb Sau921dRlJ4r+3iAGV4Wj27yamnP4/+5j/pTqefQ7a6Ji8zcyHQtSnVzcRDtYDokyexi AGxi8AONGHZoVH/gQOjs1YzUpYUfdNyfdP5GVmmiqADtoEycnjFkEERr+Zk8vZFE4UYC EMh8q5kM2AxjVh/zUybgnMixgCKURZYT6iwsY8Bn8RcaP/x9ikqAhozowcPGrzU6IX7l WQo9H+5bEgI8Xk1/q5gMvEOpq3BUP/JFyWwJeyP7LyGFXImN0ufdlLb0mucB20+KeCn2 vxYw== X-Gm-Message-State: ABy/qLZv+NzbVDOmZ5m0K6FTIJgBd8KImsfRi/LuCWLspaRU7BKbjk5n 52JySO4hXETb4xU5vCX2qbQwUA2RgrCk+RK5MTV9iwRSRznRi/gtGu+t/jtpNl+4FWyTHTLCflZ 97eF968Dyaf6kPVoNvCgF5M4Cb0xKXnbcN4o4 X-Received: by 2002:a17:90b:1957:b0:263:f630:228f with SMTP id nk23-20020a17090b195700b00263f630228fmr16988220pjb.23.1689087620134; Tue, 11 Jul 2023 08:00:20 -0700 (PDT) X-Google-Smtp-Source: APBJJlFNjpXORy0ksR6nIpCTC77AbNTYn1a1F9JCymCkZ8qK3vh4/RW+gZC9D56ER/9zvRf9roHfSgZTS5tv0lVeX+Q= X-Received: by 2002:a17:90b:1957:b0:263:f630:228f with SMTP id nk23-20020a17090b195700b00263f630228fmr16988202pjb.23.1689087619867; Tue, 11 Jul 2023 08:00:19 -0700 (PDT) MIME-Version: 1.0 References: <87351zls9p.fsf@redhat.com> <20230710210102.139114-1-amerey@redhat.com> <33456123-8fd6-67c5-18dc-293ead14bbed@palves.net> In-Reply-To: <33456123-8fd6-67c5-18dc-293ead14bbed@palves.net> From: Aaron Merey Date: Tue, 11 Jul 2023 11:00:08 -0400 Message-ID: Subject: Re: [PATCH 5/6 v3] gdb/debuginfod: Support on-demand debuginfo downloading To: Pedro Alves Cc: aburgess@redhat.com, gdb-patches@sourceware.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-5.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Pedro, On Tue, Jul 11, 2023 at 8:01=E2=80=AFAM Pedro Alves wrot= e: > > On 2023-07-10 22:01, Aaron Merey via Gdb-patches wrote: > > +void > > +dwarf2_gdb_index::expand_all_symtabs (struct objfile *objfile) > > +{ > > + try > > + { > > + dwarf2_base_index_functions::expand_all_symtabs (objfile); > > + } > > + catch (gdb_exception e) > > Write: > > catch (const gdb_exception &e) > > ... to avoid slicing. > > This catches QUIT exceptions as well. Did you mean gdb_exception_error i= nstead? Yes it should be gdb_exception_error. I've updated the patch with these cha= nges. Thanks, Aaron