public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Aaron Merey <amerey@redhat.com>
To: Tom de Vries <tdevries@suse.de>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH][gdb/debuginfod] Ask to cancel further downloads
Date: Thu, 29 Sep 2022 15:29:57 -0400	[thread overview]
Message-ID: <CAJDtP-Rwa2LUXYfUO0-4rSGZDGgK9GGcpdVZNbzgNhG43i=Tyw@mail.gmail.com> (raw)
In-Reply-To: <20220929082534.GA22465@delia.home>

On Thu, Sep 29, 2022 at 4:34 AM Tom de Vries <tdevries@suse.de> wrote:
> Add a new command "set debuginfod cancel one/all/ask", where:
> - "one" means ^C cancels one download,
> - "all" means ^C cancels all further downloads, and
> - "ask" means ^C asks whether to cancel all further downloads.  A "yes" implies
>   "set debuginfod cancel all", and a "no" implies "set debuginfod cancel one", so
>   the question is only asked once.
>
> Note that the behaviour as it was before this patch is equivalent to
> "set debuginfod cancel one".
>
> Instead, the new default is "set debuginfod cancel ask".
>
> Note that cancelling all further downloads implies "set debuginfod enabled off".

LGTM. It's a usability improvement and it worked as intended during testing.

Aaron


  reply	other threads:[~2022-09-29 19:30 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-29  8:25 Tom de Vries
2022-09-29 19:29 ` Aaron Merey [this message]
2022-09-30 16:15   ` Pedro Alves
2022-10-05  1:44     ` Aaron Merey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAJDtP-Rwa2LUXYfUO0-4rSGZDGgK9GGcpdVZNbzgNhG43i=Tyw@mail.gmail.com' \
    --to=amerey@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=tdevries@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).