From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id F05A53857351 for ; Thu, 29 Sep 2022 19:30:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org F05A53857351 Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-490-nbRG8ep2MC6svPl9QchCVA-1; Thu, 29 Sep 2022 15:30:10 -0400 X-MC-Unique: nbRG8ep2MC6svPl9QchCVA-1 Received: by mail-wr1-f69.google.com with SMTP id h1-20020adfa4c1000000b0022ccc7ac944so856249wrb.5 for ; Thu, 29 Sep 2022 12:30:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=y4VLQw25GLtedaCj4svGZvqcMWjNbavlyGtWyhIH5BI=; b=qb5lCvH16hzzQ3DvC8R20fQFn/XGoQsbl8Xi+/eI8Sw5GTgl//5S0KPLBwn3eVzn+R 370MqojxQdn4y1twcVB8hY9acKIOFn0kON5PjHQN83JudmRZI1ZfCPRU8U0UnoolOJZ/ 4SZndCP87TiJNPmBAawJWayrw/U76zc8ghruaVw3gpq9zgh/Iw4lmOj36/+f8ksSgu2e bLzAveikCeLKzRRBVVHXa8XYpa6KS/WLrIp7/2x9FxmznTGgKrmRWBJJ9edOmmJYxyql N9XNuQZ5taoBo8CNJy2R4pjt7Bdm6LbdTjMgtam008X0wD6yHjEvg7yRUIFVn2+Yrp6u W/gA== X-Gm-Message-State: ACrzQf3gJG1pSXB8w6GR9m5mpZAXSn2jRDWCTrZAKOTKfyDF2l5O0feo wqgiYjK9+6skRD8F6mYtKwpFUA7ryz5bNeqKid3nmkpkexUprF6maAgXH4JqDQy6g1I0EMxw7Ye 27lGEbAuK17/2ekB9767kDAuwIPq8ccIpjVgd X-Received: by 2002:a05:6000:1886:b0:22a:2944:a09 with SMTP id a6-20020a056000188600b0022a29440a09mr3570075wri.391.1664479809018; Thu, 29 Sep 2022 12:30:09 -0700 (PDT) X-Google-Smtp-Source: AMsMyM6XZWdEheS43ofrpTJ23De3b1Gp38Rx/g9ouKUjQCAETrAVepmuIPPOo7/0HQnMGVjFZrNrzt6NEiAh1jtNBvU= X-Received: by 2002:a05:6000:1886:b0:22a:2944:a09 with SMTP id a6-20020a056000188600b0022a29440a09mr3570059wri.391.1664479808839; Thu, 29 Sep 2022 12:30:08 -0700 (PDT) MIME-Version: 1.0 References: <20220929082534.GA22465@delia.home> In-Reply-To: <20220929082534.GA22465@delia.home> From: Aaron Merey Date: Thu, 29 Sep 2022 15:29:57 -0400 Message-ID: Subject: Re: [PATCH][gdb/debuginfod] Ask to cancel further downloads To: Tom de Vries Cc: gdb-patches@sourceware.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-5.7 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Sep 2022 19:30:13 -0000 On Thu, Sep 29, 2022 at 4:34 AM Tom de Vries wrote: > Add a new command "set debuginfod cancel one/all/ask", where: > - "one" means ^C cancels one download, > - "all" means ^C cancels all further downloads, and > - "ask" means ^C asks whether to cancel all further downloads. A "yes" implies > "set debuginfod cancel all", and a "no" implies "set debuginfod cancel one", so > the question is only asked once. > > Note that the behaviour as it was before this patch is equivalent to > "set debuginfod cancel one". > > Instead, the new default is "set debuginfod cancel ask". > > Note that cancelling all further downloads implies "set debuginfod enabled off". LGTM. It's a usability improvement and it worked as intended during testing. Aaron