From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 85E963882652 for ; Fri, 14 Jun 2024 18:22:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 85E963882652 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 85E963882652 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1718389380; cv=none; b=Y22ZkQgSbrTbpymimbwyQcMZOtPSF7SurHHKHga7KU6w4VU4gokqt5NMD5XRmDsU3jDt9L3Ycu3GS2gpIfYUWSA13/FvT1/hlJmBrkbWn58+YZBEJ+32fdbYKCH+TmkReMBXcz4B+TmNI+FIpyGjBNbq9JZpBxumf3K1dUW6gY8= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1718389380; c=relaxed/simple; bh=MWyY3lQEBUvXKn98QVOwNZJrxFN5nuaMdhy8LyXKbSU=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=SavF6wH4820dVQ8DXuKkB7fceFGe+uUYe61z6YnAnhXrn+Qu5K8qZuS+mVdWc0ZGuCUsznKMNvchLcYKqSvmGrJLixigGupqwTbaqL2qPTcxlzwOLK4PGQRaINbVeyPC76Raf/avq/hjz5yctW7DBc9p5zkVqPdXvy6SBfPG5y8= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1718389379; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=lEzxBVi1RQIiME17duCsddF6P9weo+IBacgPbkeOjKE=; b=dhgz0v8fWqne65m+zBW+AhWknn3/1IxYDRJB5nxlHc2MgNSkHMdgjt9clMTl8Uw8/oszWF 23KqFpPrWxXs3QLB9kg3UWDcs1B9+66pY/KI2P8JlAtPnoD/aRb/rzcnjJY2exTZnkLuGs hsHlNhwbEpeKFluwEDomCA5wrqs7uIM= Received: from mail-il1-f197.google.com (mail-il1-f197.google.com [209.85.166.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-314-IuYIC94yMSKVC8KjL2Mlyw-1; Fri, 14 Jun 2024 14:22:56 -0400 X-MC-Unique: IuYIC94yMSKVC8KjL2Mlyw-1 Received: by mail-il1-f197.google.com with SMTP id e9e14a558f8ab-375a26a094dso22726785ab.0 for ; Fri, 14 Jun 2024 11:22:56 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718389376; x=1718994176; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=lEzxBVi1RQIiME17duCsddF6P9weo+IBacgPbkeOjKE=; b=MFpceumve2OOnItQQPz1hBzeLIEt0hJZpkZPZ5NigM7p5K8HGC+8xC+poE1ASGK6Ah /bGnuOmGhlEJsFiZ22n17V7gAqukDUnA9kij3kIHv7bhuJuJK/Hs7j4TmqXuapAp5DXU 5TO7nYAdXGQPT6P+WOfULzI4h4mm/7Ob2n+/ZbFYh7FLij+pV3/rPDOlKcG97NQ5holb YsQEOLe0nnO5rNat7/PqQ1dpZRuyycc3GoGGiCw/avvS/Wr0b/feFJ+JVpvPyaPz4PgM NCeSkgXS4ql6WB/DhlBXJlckD4qCpoPtS1Tb/M9iBKwfuhQTVsdNGgn6FpHKiaVjYFZ2 wmHw== X-Forwarded-Encrypted: i=1; AJvYcCUk6fTcxWzL0oORsX8IPgIqfqo0EFxQn1p3S1VflLeTU6xzhZdIrA+TqYTvfzrmbK+MLdAjbMjzeHeqzKI4ExzUzQsisoJtBOuysg== X-Gm-Message-State: AOJu0Yz4ouB2n+7UhF+xA5ycRIg57cSGsWlNp7jnRKc2wmeSwL2z87I7 UBJ+hcIZ+A+W2yVpiFKHagts27N4UNe9+hOONvU5i3cHccKmFf429u5sMJGciLYT9+8aB9UHqSw cLbpWJU+X1VO5VkN3ul/nBqxYh3SITefkHPwe3GaUmQOq0Fi6+1kzeRk1iD/UyaRfAtQDV4nnr5 cldkyAi0EEdeIv8Nt+hM0FQZAYI4kqxHnEpv4SQ6FtBsQ= X-Received: by 2002:a05:6e02:17c7:b0:375:c461:eb67 with SMTP id e9e14a558f8ab-375e0e9ed6bmr36729885ab.28.1718389375730; Fri, 14 Jun 2024 11:22:55 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHy2SdUKjvIARaLSvdqIkiWhQZbR16U5HaE4K+gbIOdIO3woywrqQMc65tHwNuwzoQe+2M/IpmIoLGbEdsyYFU= X-Received: by 2002:a05:6e02:17c7:b0:375:c461:eb67 with SMTP id e9e14a558f8ab-375e0e9ed6bmr36729765ab.28.1718389375457; Fri, 14 Jun 2024 11:22:55 -0700 (PDT) MIME-Version: 1.0 References: <87o787aenj.fsf@redhat.com> <20240611205612.986851-1-amerey@redhat.com> <86y17a1v63.fsf@gnu.org> In-Reply-To: <86y17a1v63.fsf@gnu.org> From: Aaron Merey Date: Fri, 14 Jun 2024 14:22:44 -0400 Message-ID: Subject: Re: [PATCH v4] gdb/debuginfod: Ctrl-C asks to cancel further downloads To: aburgess@redhat.com Cc: Eli Zaretskii , gdb-patches@sourceware.org, mliska@suse.cz, tdevries@suse.de, keiths@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-5.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Wed, Jun 12, 2024 at 3:23=E2=80=AFAM Eli Zaretskii wrote: > > > From: Aaron Merey > > Cc: gdb-patches@sourceware.org, > > mliska@suse.cz, > > tdevries@suse.de, > > keiths@redhat.com, > > Aaron Merey , > > Eli Zaretskii > > Date: Tue, 11 Jun 2024 16:56:12 -0400 > > > > I changed the user_data constructor to call target_terminal::is_ours > > since this results in slightly less code duplication. > > > > I've updated patch below with this change as well as UI text change > > that Keith suggested. > > Thanks, the documentation parts are okay. > > Reviewed-By: Eli Zaretskii Ok to merge? Aaron