From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 60A383860004 for ; Mon, 21 Mar 2022 18:23:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 60A383860004 Received: from mail-yb1-f199.google.com (mail-yb1-f199.google.com [209.85.219.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-205-dS_HI2DwODyHUt62RgDGgQ-1; Mon, 21 Mar 2022 14:23:02 -0400 X-MC-Unique: dS_HI2DwODyHUt62RgDGgQ-1 Received: by mail-yb1-f199.google.com with SMTP id b12-20020a056902030c00b0061d720e274aso12647362ybs.20 for ; Mon, 21 Mar 2022 11:23:02 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=DJfOCDPU/fegXQ26Vp/0vArZW2k2wKPHyjBd10EdHbc=; b=wSq1uEyXTHiaU66SoQkQv1YChGf1XJ32F/ANcgHXpbjJy7Fngwe7zleHJvC5C38K2p ZWvLPDTXOv25lmMIjfu39bx+GoJoQX3Dt+rpGziWADUGRAy6BDFu2U4b5szy76APQxgS Ax2bX1Dx8DoqlxvcMFBFZQJZ6SSz25q16lFYzBTlgg5PdQF4S3TAfwLYhIM1GvrA9QRf u8d+FK9cvkdgxFUyY93OHRjCw557FAqjSklJT1fEKDlqY4M+HF/lE7xEyBMFc9KWbDV+ +2kJE6cfNzQNBkPcHYAyAwruWrnLvMlIYBnJbvZMAc+A0A4VLrg6UhearQC25CVPfUUh t60g== X-Gm-Message-State: AOAM532N0zMFNxa20mPUtY5g/RQY/lw0/L0sIYpaLBv4ODE/7qaBgE0D n4VLAY1b2JFujP/6aOxU2XzGg8VQmsJ9h/9U79Toao1CkbUgD2CbbXMk3SIn6orHpMBs/yHD/UY zTtECvlKbLGrIyPDXqDubY5lZYddkW1n6ZzAk X-Received: by 2002:a81:1695:0:b0:2e5:c6d8:5f04 with SMTP id 143-20020a811695000000b002e5c6d85f04mr21534165yww.127.1647886982107; Mon, 21 Mar 2022 11:23:02 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwotZF2XuG7UAAiKj0iZlV0Ly3V5q/u/UMxQqJovmZWNFif6k6T3zFhiMz1KrzBPC91kAzWp6e0JDxKtEcpKVE= X-Received: by 2002:a81:1695:0:b0:2e5:c6d8:5f04 with SMTP id 143-20020a811695000000b002e5c6d85f04mr21534141yww.127.1647886981917; Mon, 21 Mar 2022 11:23:01 -0700 (PDT) MIME-Version: 1.0 References: <87wnh9u4m2.fsf@tromey.com> <20220308003331.171162-1-amerey@redhat.com> <8735jomrvq.fsf@tromey.com> In-Reply-To: From: Aaron Merey Date: Mon, 21 Mar 2022 14:22:51 -0400 Message-ID: Subject: Re: [PATCH 2/2] PR gdb/27570: missing support for debuginfod in core_target::build_file_mappings To: Tom Tromey Cc: Aaron Merey via Gdb-patches , Andrew Burgess , lsix@lancelot.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-6.0 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Mar 2022 18:23:07 -0000 On Fri, Mar 11, 2022 at 4:49 PM Aaron Merey wrote: > > On Fri, Mar 11, 2022 at 10:27 AM Tom Tromey wrote: > > > > >>>>> Aaron Merey via Gdb-patches writes: > > > > > gdb/corelow.c | 28 ++++++++++ > > > gdb/debuginfod-support.c | 51 +++++++++++++++++++ > > > gdb/debuginfod-support.h | 17 +++++++ > > > gdb/gcore.in | 2 +- > > > gdb/solib.c | 32 ++++++++++++ > > > .../gdb.debuginfod/fetch_src_and_symbols.exp | 22 ++++++++ > > > 6 files changed, 151 insertions(+), 1 deletion(-) > > > > This looks good to me. Thanks. > > Great, I'll merge it once patch 1/2 is merged. Pushed as commit b91f93a02c9c Aaron