From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 3696F385772D for ; Thu, 1 Jun 2023 22:36:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3696F385772D Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1685658979; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=cOsdn69CzpEPWd7jKMBTCnSsCT3WbqyobZPVspbnekE=; b=feREw1h7LKu1w8BTwTLyS1fPB4xFFWL8Jo58ysYGv8+U/Ce8/1GxDYRkr53PmXT09uEKgF ghznhDsab8kBnVAbZN6RSydTOM+Smo1ZYtKZXd6sOKVUJ0pswhweEUMA1QWz97hyWEiDZI RYsC8OchqUYhDe+uAqBZ6cMPrGnU3D8= Received: from mail-oo1-f72.google.com (mail-oo1-f72.google.com [209.85.161.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-620-3_vNlaYxOE-i9imfh7Ofpw-1; Thu, 01 Jun 2023 18:36:18 -0400 X-MC-Unique: 3_vNlaYxOE-i9imfh7Ofpw-1 Received: by mail-oo1-f72.google.com with SMTP id 006d021491bc7-5554ec49629so1021963eaf.2 for ; Thu, 01 Jun 2023 15:36:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685658978; x=1688250978; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=cOsdn69CzpEPWd7jKMBTCnSsCT3WbqyobZPVspbnekE=; b=kC/+wNvghbzlUnLTU9nVwXMrjMjnW7TTU6qvRln4NbJFyd3kb5U1sefD42D6djbnYF 8GlQTvOqQA+NnJkbky6crxWLKX04j7rF0YVXPCrcl8hGlNIy5EpHNcXsxNyDViUhGiZp XJNle9lHqXZV6Zn6mr6jE02GqvGj538yOG2/TMOJP0SxEIKK5o1xLJX0Qo6QEtlZRpBp /N5SPiQR0tWToW66tIyBGVjU8VyzEZshf7F3TUOyuXGq9+yyoxuqcOwdAVuc8lHEupLi cuDMciaWtfUBLEdBD1hu+DqLAFJWb5FOfPpE2lfUTvyLRk7WZY3FjhD0FK/gskK2tZDS 1hBA== X-Gm-Message-State: AC+VfDyxcKRFeQ+zsk86rIY0i0apfstUBTzbdgFr2Rr1BuA9RkARO3CQ Vt05VYb01DE44l0svVwIVqV9YOxcGYaE22/+qB/x19gHXOe54725lD6m7mVT2qM9Hs4QGD34AhX ic01mwMwdvzz8a1y/eX4VCi50PCtpiICiibGp X-Received: by 2002:a05:6358:9924:b0:123:6953:6754 with SMTP id w36-20020a056358992400b0012369536754mr5087669rwa.21.1685658978206; Thu, 01 Jun 2023 15:36:18 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4dkmDmlKUIMAyy8PPt2gyDgn4yRLxlgtExTrqGQtK6MTy8wJPHd6E1gJ+JeduFwdfngmclIuRyUkKS4mLi0cM= X-Received: by 2002:a05:6358:9924:b0:123:6953:6754 with SMTP id w36-20020a056358992400b0012369536754mr5087651rwa.21.1685658977895; Thu, 01 Jun 2023 15:36:17 -0700 (PDT) MIME-Version: 1.0 References: <20230601014347.3367489-1-amerey@redhat.com> <20230601014347.3367489-4-amerey@redhat.com> <83a5xjemgp.fsf@gnu.org> In-Reply-To: <83a5xjemgp.fsf@gnu.org> From: Aaron Merey Date: Thu, 1 Jun 2023 18:36:06 -0400 Message-ID: Subject: Re: [PATCH 3/6 v3] gdb: Buffer gdb_stdout during events that might download deferred debuginfo To: Eli Zaretskii Cc: gdb-patches@sourceware.org, aburgess@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-11.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Thu, Jun 1, 2023 at 2:15=E2=80=AFAM Eli Zaretskii wrote: > > diff --git a/gdb/debuginfod-support.c b/gdb/debuginfod-support.c > > index 6d0521b64e2..548e8c5f76b 100644 > > --- a/gdb/debuginfod-support.c > > +++ b/gdb/debuginfod-support.c > > @@ -168,7 +168,8 @@ progressfn (debuginfod_client *c, long cur, long to= tal) > > > > if (check_quit_flag ()) > > { > > - gdb_printf ("Cancelling download of %s %s...\n", > > + ui_file *outstream =3D buffer_file::get_unbuffered_stream (gdb_s= tdout); > > + gdb_printf (outstream, "Cancelling download of %s %s...\n", > > data->desc, styled_fname.c_str ()); > > A nit: this is a user-level message, so I think it should be in _(). Thanks Eli, fixed. Aaron