From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id AFE7C3857346 for ; Wed, 19 Jul 2023 14:33:23 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org AFE7C3857346 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1689777202; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=nM17iHS82WbaeAuCh2mp9vkZCgWNPx3EX1Vn/r+EcQs=; b=CTmJcqC1IGweKVIJ3WJzrLsY/zq5JvsEEpzSuCbXJ6fVk+8tA/CeXAs2/O/l5mv2/Wq0yb SfLC4PLiYJcnr3fhCDL8y1DOXub1Dy/uG4Q1x4DK+YApSRikAnpJ5q9IxfLEtRq1EIgC/5 gW025Obawv7rj/x2Vpguu5A+kSmNNu8= Received: from mail-pg1-f199.google.com (mail-pg1-f199.google.com [209.85.215.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-122-VXHr7inHPYSbb-J0Pg8x7g-1; Wed, 19 Jul 2023 10:33:21 -0400 X-MC-Unique: VXHr7inHPYSbb-J0Pg8x7g-1 Received: by mail-pg1-f199.google.com with SMTP id 41be03b00d2f7-55c76ff0bfeso3282062a12.2 for ; Wed, 19 Jul 2023 07:33:20 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689777200; x=1690382000; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=nM17iHS82WbaeAuCh2mp9vkZCgWNPx3EX1Vn/r+EcQs=; b=DY0ozR1WdooC8UwNt1kig+Z4z2kvpTPS+aUFPQGfnPdbeIkAYxpNkBaU3p5yHVvRFe YaukrV4r0rDWtSLI1DFDG/m48YgEF/IEzpnVIY2CV6bYliwOFL8x08mmLsvav0soKV3c /R204KvExtChakbq3PATYtAl2YUUHGy5cYHpVSPZPQvlx5+ExaanT//pre4HKKQxN5tV WMlk99JduvM+iHS1VvD5Bed15iRzLszYh2dx0g9dQVVKZF9tzj95lY+iAPqynHLrFe+K UPbGYPuK1/5U8t8RAL3/Vyy/a6Ij8+bGnUIatpRUYgqoJ/t20Z4MgJZOX1b9h12GozWa 6krA== X-Gm-Message-State: ABy/qLa4GHejRLgqcIyipIVucQotXtuuECcsY2E2o7Pp+2ByfxuNs5gw HzwLPewQ3hjo//bY0kOwZOKQdwh2RXbiKzJyd1PNzaHnCE+8+fnVeTpwjr+axOVqu4nEGZh6yUj 5RZEF+ni+20RslE82Sz3VE/DELJruokPtiLQO X-Received: by 2002:a17:90a:fc97:b0:25e:8d74:76f3 with SMTP id ci23-20020a17090afc9700b0025e8d7476f3mr1777631pjb.29.1689777199995; Wed, 19 Jul 2023 07:33:19 -0700 (PDT) X-Google-Smtp-Source: APBJJlGRm/z4b1s8m2nHd9H0+9VINI/9ZNlNm3fKkAeDHoAiREbQCkqInq2Ntu42ft6VEdjl3g4M3/GYLnqcTfGwm0E= X-Received: by 2002:a17:90a:fc97:b0:25e:8d74:76f3 with SMTP id ci23-20020a17090afc9700b0025e8d7476f3mr1777620pjb.29.1689777199694; Wed, 19 Jul 2023 07:33:19 -0700 (PDT) MIME-Version: 1.0 References: <87351zls9p.fsf@redhat.com> <20230710210102.139114-1-amerey@redhat.com> <33456123-8fd6-67c5-18dc-293ead14bbed@palves.net> In-Reply-To: From: Aaron Merey Date: Wed, 19 Jul 2023 10:33:08 -0400 Message-ID: Subject: [PING][PATCH 5/6 v3] gdb/debuginfod: Support on-demand debuginfo downloading To: Andrew Burgess Cc: Pedro Alves , gdb-patches@sourceware.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-5.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Mon, Jul 10, 2023 at 5:01=E2=80=AFPM Aaron Merey wro= te: > > On Fri, Jul 7, 2023 at 10:18=E2=80=AFAM Andrew Burgess wrote: > > proc enable_section_downloads { } { > > global gdb_prompt > > > > set cmd "maint set debuginfod download-sections on" > > set msg "enable section downloads" > > > > return [gdb_test_multiple $cmd $msg { > > -re -wrap ".*not compiled into GDB.*" { > > return 0 > > } > > -re -wrap "^" { > > return 1 > > } > > -re -wrap "" { > > fail "$gdb_test_name (unexpected output)" > > return 0 > > } > > }] > > } > > > > would do the job, though I don't currently have a machine with a recent > > enough version of debuginfod installed to fully test this, but somethin= g > > like this should do the job. > > Thanks Andrew, this works on my machine. I've updated the patch below wit= h > this change. On Tue, Jul 11, 2023 at 11:00=E2=80=AFAM Aaron Merey wr= ote: > > On Tue, Jul 11, 2023 at 8:01=E2=80=AFAM Pedro Alves wr= ote: > > > > Write: > > > > catch (const gdb_exception &e) > > > > ... to avoid slicing. > > > > This catches QUIT exceptions as well. Did you mean gdb_exception_error= instead? > > Yes it should be gdb_exception_error. I've updated the patch with these c= hanges. Is this patch ready for merging with the above changes? Aaron