From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 9B6C9385C424 for ; Wed, 19 Jul 2023 14:32:52 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 9B6C9385C424 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1689777171; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=FsmCa96GqrMJLbkO4MRxW9fAwKnd4UvzuuZ9zfxTs6k=; b=SkTjvcnnRUajv4N0uP8DK6zYaQNEpDspmL58NYASIDpMTfKbgdfx2ZoOfE8lZIi2ADv67y +LYP/IKVwYaMI+3DjLUowz+H8fARkMy4gOgOEPKmZYKDfgQKdukutf1/2aQTdOLqGpgftX 4MyB2WdNLczeaq7AnmelvI/vKhCRYt4= Received: from mail-pj1-f70.google.com (mail-pj1-f70.google.com [209.85.216.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-470-GYu5n_IqMFWptBTyqV_muQ-1; Wed, 19 Jul 2023 10:32:50 -0400 X-MC-Unique: GYu5n_IqMFWptBTyqV_muQ-1 Received: by mail-pj1-f70.google.com with SMTP id 98e67ed59e1d1-263fd992ab2so573609a91.1 for ; Wed, 19 Jul 2023 07:32:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689777169; x=1690381969; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=FsmCa96GqrMJLbkO4MRxW9fAwKnd4UvzuuZ9zfxTs6k=; b=CP7xS/Z8bip036q164jX5D+o0/NXZrYp8ScpWIUlZAOi+d6Gq4mFYPkLFxi6Rv1orF oqW3i8MtIobzyG0Be6jPioSuWC8H7dYio68jvAZLE47kzSgv06w8Dhzvz4ITKtgg+M84 cztfF5iwoWBb9LyJzX5/ONmmuojOQ1dYhX1ldwcDCDxqQmV3d2Plh3439L+Myy9pHqR1 xqVrWsaLhtEaeTIf+VlFzblo9qfaEB/ql+d6VM34vkOOOkz5PlzPN7r0gzXTlfAlUbin M4dIy3p1l5tISOf0kOxYcRSJJOCWAys/d4L78dFOSUl0g9FkZfGxmcJ0i/3YAayrCLtr 6q6Q== X-Gm-Message-State: ABy/qLZ4drJPVhaPGDhJreLw3aK94Kru1KMPuDBlTURZt7Z85oMIypiT EsHWthTSQTjVuBMOHDJ4NiUGKM3141y1yvtVdR5irrpFaYCszI9VntfZfn7Y/1hhmj9PWN79Mbd ZBwkH+0vD8u2flHnA24xPOJEazTBkDq5NnEuAyQYOifYL X-Received: by 2002:a17:90a:17ab:b0:265:d7ac:55b1 with SMTP id q40-20020a17090a17ab00b00265d7ac55b1mr3298738pja.4.1689777169487; Wed, 19 Jul 2023 07:32:49 -0700 (PDT) X-Google-Smtp-Source: APBJJlGdO0FjyUhTlnXeSkWIgOKN4XNmUMevx/uiA9uQg1KiwB+lJez1brWN9TrH0HIdK06lWcbw1ev0WhH1ZS29HA8= X-Received: by 2002:a17:90a:17ab:b0:265:d7ac:55b1 with SMTP id q40-20020a17090a17ab00b00265d7ac55b1mr3298715pja.4.1689777169102; Wed, 19 Jul 2023 07:32:49 -0700 (PDT) MIME-Version: 1.0 References: <20230609000246.3070-1-amerey@redhat.com> <871qhjls85.fsf@redhat.com> In-Reply-To: <871qhjls85.fsf@redhat.com> From: Aaron Merey Date: Wed, 19 Jul 2023 10:32:38 -0400 Message-ID: Subject: [PING*2][PATCH 3/6 v4] gdb: Buffer output streams during events that might download debuginfo To: Andrew Burgess Cc: gdb-patches@sourceware.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Fri, Jul 7, 2023 at 10:19=E2=80=AFAM Andrew Burgess wrote: > > To fix this we accumulate writes to gdb_stdout and gdb_stderr in > > buffer_file objects. Debuginfod progress messages skip the buffers > > and print to gdb_stdout immediately. This ensures progress messages > > print first, followed by uninterrupted frame/thread/stop info: > > > > (gdb) backtrace > > [...] > > Downloading separate debug info for /lib64/libpython3.11.so.1.0 > > #8 0x00007fbe8af7d7cf in pygi_invoke_c_callable (function_cache=3D= 0x561221b224d0, state=3D... > > I have started taking a look at this, but I'm not going to finish today, > so I thought I send the minor nits I'd spotted so far, Ping Thanks, Aaron