From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 611453858D32 for ; Sat, 11 Feb 2023 02:14:17 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 611453858D32 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1676081657; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=6zcZq/FnCNzqh+JNxQhXu+Ph1kNVzxdxtHmzBYBbDcY=; b=SaDYF2vyYJJ+M0Xo4/MxWtUkr1cm1g1eq2Dlyut5PfCOa/ZDo98mtI7HSxHLPJeYcOvl1t Crsm5AOVrTPD10+KmhiZmuLf9iAQ0AcXT7Bs8AwM7IzaZA6c7uKPdnsfat0s6H2QftadHL 8pNbNfvqySj2dWiJhxgoyd6xNCNU7YU= Received: from mail-pf1-f198.google.com (mail-pf1-f198.google.com [209.85.210.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-60-kHxQy20fN8GkgKQiLdjlUQ-1; Fri, 10 Feb 2023 21:14:15 -0500 X-MC-Unique: kHxQy20fN8GkgKQiLdjlUQ-1 Received: by mail-pf1-f198.google.com with SMTP id cp14-20020a056a00348e00b005a858f5c99bso3398029pfb.22 for ; Fri, 10 Feb 2023 18:14:15 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=6zcZq/FnCNzqh+JNxQhXu+Ph1kNVzxdxtHmzBYBbDcY=; b=1Rrzpev/F2IT4nzZ4Lsaa2kGzElyRoV8EyObi4etuQdmEN+jy9TqelD4WUII2IlPJc 31dJaiSdmKOCyEBqoJrMd9C6ORvMGxkDfY30OoznWo24GEHlkrE/KJ6sbE+tP2/zPpuT JQGjNCno+7YAPRUJi9CBJlas6uSuO9PGYoHFdIlPoHePKL4EnUXUz2G2P5fyh/0iAxRw qgfQVAm5iWhDKSo5Hy9kmSm2iqNTUNzYAgRxNlJU8hre8tsIuJHzlwR9I/f1KtdlM9+h EEGi3SzjwUAt+BTCmKxNepZWaixcCns+Qq4f52ykM/jtJHtamrhf8qmdj5GWTwj2BBEc u+FQ== X-Gm-Message-State: AO0yUKUDnBiAi2vzmkT65ei3+WqgD016gWo4OutGP8zDSP+lwkC1AHTe +kRHhLYIpSsRJhYlQiQvToN70wZAMLhUGWNANF7yqZl3jG1kS/32MZlhooSSXLBp0eGVmtMVvrz aAkAVjHYFsHQ4afQZuVc0MD0gkmulusWCrQWW/YQhWNowzEI= X-Received: by 2002:a17:90a:7384:b0:230:815:ff39 with SMTP id j4-20020a17090a738400b002300815ff39mr2668133pjg.141.1676081654553; Fri, 10 Feb 2023 18:14:14 -0800 (PST) X-Google-Smtp-Source: AK7set/N6YuLaC5BCFnSVJmvS+x8iGGIzDhYcir9GSo0+W3iZiQl5YW4Z1lc0TEfz3idcPHlz0qusfrGUGHz/E2NVtQ= X-Received: by 2002:a17:90a:7384:b0:230:815:ff39 with SMTP id j4-20020a17090a738400b002300815ff39mr2668129pjg.141.1676081654381; Fri, 10 Feb 2023 18:14:14 -0800 (PST) MIME-Version: 1.0 References: <20230210015942.3180401-1-amerey@redhat.com> <20230210015942.3180401-3-amerey@redhat.com> <871qmxzipp.fsf@tromey.com> In-Reply-To: <871qmxzipp.fsf@tromey.com> From: Aaron Merey Date: Fri, 10 Feb 2023 21:14:03 -0500 Message-ID: Subject: Re: [PATCH 2/2] gdb/source: Fix open_source_file error handling To: Tom Tromey Cc: Aaron Merey via Gdb-patches , keiths@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Fri, Feb 10, 2023 at 9:41 AM Tom Tromey wrote: > > >>>>> "Aaron" == Aaron Merey via Gdb-patches writes: > > Aaron> Fix this by having open_source_file return a negative errno if it fails > Aaron> to open a source file. Use this value to generate the error message > Aaron> instead of errno. > > Thanks for doing this. Thanks, pushed as commit 8cc96ee4169f63191 Aaron