From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id CD20E3858D39 for ; Thu, 10 Mar 2022 20:22:57 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org CD20E3858D39 Received: from mail-yb1-f199.google.com (mail-yb1-f199.google.com [209.85.219.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-602-CiPPjLaONVyLvstiFzpXlw-1; Thu, 10 Mar 2022 15:22:54 -0500 X-MC-Unique: CiPPjLaONVyLvstiFzpXlw-1 Received: by mail-yb1-f199.google.com with SMTP id n66-20020a254045000000b0062883b59ddbso5438179yba.12 for ; Thu, 10 Mar 2022 12:22:54 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=9gB+ENwFC1rnkBj6S/kE8vWwXsdXm7AjMywUjUHtfbk=; b=GCE5z+lNxXg7UhhBwF9lzDeO2vueEEvxoitxRUrXbQ/imu0QaJ+zRmDGh7P1FDDfC9 ELdyLHIEB6TJn9SB0en4gyoUGI5UV5Cf7GJeY1E162VvhsT01XmmSp0NQs44Ya9ixPi7 tQxSlnv1oc1pIOLt0w5GetfOEyxmAl0tWAtXblbmOUqv4lCf2kptWrW9ZG18KP6ioecs hSxfw2LB9jYfeus+QzcWyTZsYFsUXjjccbe04QqNyzvTV/ufHbGtmeeqVZ/+dUnmXhlz iP82dFkpyIyxITh3ZxSNuBWUDx53eC585z2H3FDkE0t/tTE3XB9a3nBWtdLz2o9U8ZaJ 6Khg== X-Gm-Message-State: AOAM530P4SjRLvDsA+TJewuUYXQd1qKzKylTUegPhBBjrcYde2EU7v4K +kg1lhOcqnFXVYMNKB7RV4OrXVa2JrgtHgHyNiJasuhVKcFP0SNtClHDiFnk17ZGWS1NKS9cDr0 Vw2oCxqc+sm3gNvqxoCEXuPkd8B4aNvnVWN4U X-Received: by 2002:a0d:edc7:0:b0:2d8:2ec:2e87 with SMTP id w190-20020a0dedc7000000b002d802ec2e87mr5561674ywe.209.1646943774101; Thu, 10 Mar 2022 12:22:54 -0800 (PST) X-Google-Smtp-Source: ABdhPJwYwmfrCs7NoJaRgxescQ/caEyOYmaToTcghskUkCcO4HkAcfp2wTq6aIC3Ht+QFnaoFCSvThhnS4dMo38ZPvY= X-Received: by 2002:a0d:edc7:0:b0:2d8:2ec:2e87 with SMTP id w190-20020a0dedc7000000b002d802ec2e87mr5561660ywe.209.1646943773928; Thu, 10 Mar 2022 12:22:53 -0800 (PST) MIME-Version: 1.0 References: <87o82lu2xy.fsf@tromey.com> <20220308224136.173615-1-amerey@redhat.com> <02e57ea2-29bb-1a93-da39-7b58621f0944@palves.net> In-Reply-To: From: Aaron Merey Date: Thu, 10 Mar 2022 15:22:43 -0500 Message-ID: Subject: Re: [PATCH] gdb: Try searching for auto-load script using .gnu_debuglink To: Pedro Alves Cc: Tom Tromey , gdb-patches@sourceware.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-5.7 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 Mar 2022 20:22:58 -0000 On Thu, Mar 10, 2022 at 3:16 PM Aaron Merey wrote: > > Hi Pedro, > > On Thu, Mar 10, 2022 at 1:26 PM Pedro Alves wrote: > > > > On 2022-03-08 22:41, Aaron Merey via Gdb-patches wrote: > > > + auto_load_debug_printf > > > + ("auto-load: Stripped .exe suffix, retrying with \"%s\".", > > > + realname.get ()); > > > + > > > > With "auto-load:" in the fmt, doesn't gdb print "auto-load" twice? > > This was fixed in the second version of the patch I posted: > > On Tue, Mar 8, 2022 at 5:41 PM Aaron Merey wrote: > > + auto_load_debug_printf > > + ("Debug filename mismatch, retrying with \"%s\".", > > + p_realname.c_str ()); > > The first version repeated "auto-load" because I based the message > on a pre-existing call to auto_load_debug_printf in auto_load_objfile_script > which contains a repeated "auto-load". That should be fixed and I will post > a patch for this. Sorry Pedro, I mistook the function call you quoted for the call I added and later fixed. The repeated auto-load you quoted was copied verbatim from a pre-existing call to auto_load_debug_printf and was not fixed in the patch that was merged. But like I said I will post a fix for this. Aaron