From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 10598385842B for ; Mon, 7 Mar 2022 17:50:45 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 10598385842B Received: from mail-yw1-f198.google.com (mail-yw1-f198.google.com [209.85.128.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-568-SQRdnPsiMiSPz4sIzIpUpg-1; Mon, 07 Mar 2022 12:50:43 -0500 X-MC-Unique: SQRdnPsiMiSPz4sIzIpUpg-1 Received: by mail-yw1-f198.google.com with SMTP id 00721157ae682-2dbf4238d6bso138051527b3.2 for ; Mon, 07 Mar 2022 09:50:43 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=PEdtE+SFa7kk22gjROzJ5BbR2ZDIOt2nSmkY+IiHQHI=; b=f3fVvybconMdunLHxhOIxSMTuOrIdsbdAd/Ppc1ghr7/sPPntem8pfVU4F575rLHRw oTceTj7cyoyn4MCLrWSoXQUPUxm/Q7iFd6KfGZMabn8klkK/ihrI0pJeWrI/fEZ6LQug REVByKd/9mpAVTy19+H5jgMeZ+IoU6Ik/X0dZB4rKS0hhy6d7+ZaRnVKG4QwF8tIRNXw hosuBUtG+N46z/VkadDf6CNYAUXwJxEIrNGnB2cHuxDECTbSNKhEhe70nJLj5MZkv2QM Rtix4V7LB6/6qryG3XKEa/poSWYwnNga2VSpETSapNv7ms6BPb6ntTvuSVrVoj2D0WuZ Jgcg== X-Gm-Message-State: AOAM531SePieBELfeEVWZqGpNPlcQDzsBNtWqAh7Fyd8WPiBnj6/Gikb NKTrl2dLmjfxdogF9t5AsQaCQYYPHBFiJZNzsDXcQnJrnCgeC++Ki6qvHfvgtpMf2BzBI+Rwlm6 AMHJsHSxKx+BnZj/eyPe/7yFc/8PUlCOT9l7a X-Received: by 2002:a25:90d:0:b0:622:4bed:4f4f with SMTP id 13-20020a25090d000000b006224bed4f4fmr8883584ybj.508.1646675442909; Mon, 07 Mar 2022 09:50:42 -0800 (PST) X-Google-Smtp-Source: ABdhPJwhc112waI1qmMV4izSQf5eoBa3lDx5QoQ6Ox38IPU0J7tpdYwdDY4QN6ujao7ploPscZCM372z0GkXq069zd8= X-Received: by 2002:a25:90d:0:b0:622:4bed:4f4f with SMTP id 13-20020a25090d000000b006224bed4f4fmr8883573ybj.508.1646675442700; Mon, 07 Mar 2022 09:50:42 -0800 (PST) MIME-Version: 1.0 References: <20220304193015.1940131-1-tromey@adacore.com> In-Reply-To: <20220304193015.1940131-1-tromey@adacore.com> From: Aaron Merey Date: Mon, 7 Mar 2022 12:50:31 -0500 Message-ID: Subject: Re: [PATCH] Simplify the ui-out progress API To: Tom Tromey Cc: gdb-patches@sourceware.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-5.9 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Mar 2022 17:50:46 -0000 Hi Tom, On Fri, Mar 4, 2022 at 2:30 PM Tom Tromey wrote: > I noticed that 'progress' is a method on ui-out, but it seems to me > that it would be better if the only API were via the progress_meter > class. This patch makes this change, changing progress to be a method > on the meter itself. LGTM. I agree that it's better to use progress_meter for this API. This change should be fine even if we were to implement progress handling in a ui_out derived class. Aaron