From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id D93C138582AD for ; Fri, 16 Sep 2022 21:32:31 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org D93C138582AD Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-583-XDqgA_lJNvGvbJnfBzhMSg-1; Fri, 16 Sep 2022 17:32:30 -0400 X-MC-Unique: XDqgA_lJNvGvbJnfBzhMSg-1 Received: by mail-wm1-f70.google.com with SMTP id h4-20020a1c2104000000b003b334af7d50so490445wmh.3 for ; Fri, 16 Sep 2022 14:32:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=G+IFGnAmz9eYLOswyVHDbaitzB5l0G45+LFAiK6gNmY=; b=Ac8xqjb6UzECp2TgrS7CAn0o6H3ceuxhjPX0rkkPOmnWgX+JSwPU1OagI2tQ1KFWOG xP0vnl28leNn3uJWcE61t1uwM8a+bjxvXsU0hyKZTy2WAPZ2C9Yk2STcTb3DZ7sB3QYO vSshL9HL54TokkN9z1UEGUOUm8zRcBDgsJQZLmxPQklDGw/0ePnA7QGN3fV5SYbNQzj5 lU6xyRgSxAN388mlhaLyz+dU/2meORWhFxzUy8hklsrw2zxE28jKXADiWjT92c9KSnSa HLmYtdbI8NNYquEpvbCeW3Xy1gfN7SnPeEVdKEDZXGA0g8mUPjiocDpsfaCSVnVZyeZh KZGg== X-Gm-Message-State: ACrzQf1MMdnSMMNlnGCW7Kl5ygioAAU94u8RVZXbAq2UthuZLfmqg+HZ GCeotb7/60fWHppia0IA/3HYeIQewY55DaH6+z7lb6YBPYSY3/tptR96guPuzqAczxYEjZew/BG Wim2iibdX2sQtkWBCwP4aEUv+Qp4+9VKPNuX1 X-Received: by 2002:a05:6000:154a:b0:22a:b8eb:ba53 with SMTP id 10-20020a056000154a00b0022ab8ebba53mr3996273wry.594.1663363949101; Fri, 16 Sep 2022 14:32:29 -0700 (PDT) X-Google-Smtp-Source: AMsMyM6vlZhFmVzhE3iaYwT12z3LWJmaUKFQpsAF02PYThHPDR8MDsGbEpCu4lqyE27e6GYeLkB4TN1jJNDa7yUlQWA= X-Received: by 2002:a05:6000:154a:b0:22a:b8eb:ba53 with SMTP id 10-20020a056000154a00b0022ab8ebba53mr3996268wry.594.1663363948936; Fri, 16 Sep 2022 14:32:28 -0700 (PDT) MIME-Version: 1.0 References: <20220907135136.602656-1-aburgess@redhat.com> In-Reply-To: <20220907135136.602656-1-aburgess@redhat.com> From: Aaron Merey Date: Fri, 16 Sep 2022 17:32:17 -0400 Message-ID: Subject: Re: [PATCH] gdb/testsuite: add a debuginfod-support.exp helper library To: Andrew Burgess Cc: gdb-patches@sourceware.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-5.9 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 Sep 2022 21:32:33 -0000 Hi Andrew, On Wed, Sep 7, 2022 at 9:51 AM Andrew Burgess via Gdb-patches wrote: > > We currently have a single test for GDB's debuginfod support, this is > gdb.debuginfod/fetch_src_and_symbols.exp, this script does all the > setup, starts debuginfod, and then does the testing. > > This commit tries to split the existing script in two, there is a new > library lib/debuginfod-support.exp, which contains a helper functions > related to running debuginfod tests. All the code in the new library > is basically copied from the existing test case (which is why I > retained the copyright date range on the new library), with some minor > adjustments to try and make the code a little more generic. > > One change I made, for example, is the library offers functions to > shut down debuginfod, previously we just relied on expect shutting > down debuginfod when dejagnu completed. > > The existing test script is updated to make use of the new library > code, and this test is still passing for me. The only change in the > test results is a single test where I changed the name to remove the > port number from the test name - the port number can change from run > to run, so could make it hard to compare test results. > > I have also done a little light house keeping on the original test > script, updating and adding new comments, and making use of > proc_with_prefix in a couple of places. Thanks for cleaning this up. The debuginfod tests all pass for me with this patch applied on F36. The server process correctly terminates once the tests are finished, even if I ctrl-c part way through. Aaron