From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 220E43858D39 for ; Wed, 24 May 2023 19:05:47 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 220E43858D39 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1684955146; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=yfvxCXQJDLJuYLswntSXOAv1ClH4YiJGrpx6MotMDmk=; b=NJw6A0nc/9kjBq2WfRnRTDKsa0hN4Y6DyYbFv+3ztx+ZrJ2/ScuRxrL1Zg9cIeQLv+xR/7 tJJzXJjVJqnXxe4DQmoxbW6Si9X0I29htI/3YWm/+eECmEIdONFFBO9k15DDqRH7ZhhMKB qUZhSFYh7ToRnoSY4XN0tk7L667A09M= Received: from mail-pj1-f72.google.com (mail-pj1-f72.google.com [209.85.216.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-544-t1gIgsldP82cWRdVNc8eqw-1; Wed, 24 May 2023 15:05:45 -0400 X-MC-Unique: t1gIgsldP82cWRdVNc8eqw-1 Received: by mail-pj1-f72.google.com with SMTP id 98e67ed59e1d1-25345cf3343so429035a91.0 for ; Wed, 24 May 2023 12:05:45 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684955144; x=1687547144; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=yfvxCXQJDLJuYLswntSXOAv1ClH4YiJGrpx6MotMDmk=; b=UJRItI2bYAzv9czLIGbe2gm7epnBH4ZpIdxkqRATn+pTxCaQMTwjspcwzqxcRs2Sjq wMcL9lvtpYdixoF+L7YsxGVWmJ6aBYSSkE24r9EoRKV7Kg2rCnGV4zoejB5S85RRRGAr h95OFYPym+wE+txpmSAXXSNntCLJnPKiXmQUBOHTAYzrPVHA6WG1nREafPqmR0jHvUsv JeUUmBxWJYEy6u17HwXkVsch0trhZzAjEB8TJYQXcl6bemw+r8WdV7FWGm3ShzUVM3w+ EfdHJXt75SsdUjwBDHbtvfsYO/Hk1WMCZYtUpdWyWlNdytc4InP+O3z/D/7oGjS9i6Lk HNSA== X-Gm-Message-State: AC+VfDyklvVQT0Ie9HxSfrvSSs0TyEiCMvq07KHhM7KS/ow72Cke6TSK qH//ZvkcUYHyqMZneRx4sUstJOYNTUmBOyi5JE+H08QiRi+CqS/VL+8ivHi3PUQgA+7FFZ24esK TogQB6GCQAz8kNhMcPKek2f7mMMWXC/hKx2w9 X-Received: by 2002:a17:90a:fc92:b0:250:ab4f:59b1 with SMTP id ci18-20020a17090afc9200b00250ab4f59b1mr16624986pjb.11.1684955144544; Wed, 24 May 2023 12:05:44 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6VvN4VOHTPt6gUc+7mVr3NW8bnjeReTTDTh2gQUeq4H+yQ94O7OdUJmEQ99B108DJZLPa8tna6BKtDh9CpSo4= X-Received: by 2002:a17:90a:fc92:b0:250:ab4f:59b1 with SMTP id ci18-20020a17090afc9200b00250ab4f59b1mr16624972pjb.11.1684955144225; Wed, 24 May 2023 12:05:44 -0700 (PDT) MIME-Version: 1.0 References: <20230417180556.1213862-1-amerey@redhat.com> <87v8gi6p7p.fsf@redhat.com> In-Reply-To: <87v8gi6p7p.fsf@redhat.com> From: Aaron Merey Date: Wed, 24 May 2023 15:05:33 -0400 Message-ID: Subject: Re: [PATCH 4/7 v2] gdb: Buffer output during print_thread and print_frame_info To: Andrew Burgess Cc: Aaron Merey via Gdb-patches , tom@tromey.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-5.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Wed, May 24, 2023 at 5:41=E2=80=AFAM Andrew Burgess wrote: > > I guess I would have expected some new tests in this commit. Is there > any reason why we couldn't write a test here? My rationale was that existing tests which check the correctness of frame a= nd thread printing should suffice. However we are missing a test checking that debuginfod progress output does not occur within frame/thread info (like the example in the commit message describes). I will include a test for this to the patch that adds section downloading s= ince progress messages during frame/thread printing can only occur with section downloads. Aaron