From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id C4E5A385843A for ; Mon, 1 Nov 2021 17:39:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org C4E5A385843A Received: from mail-vk1-f197.google.com (mail-vk1-f197.google.com [209.85.221.197]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-172-QnEbOR5zM5a3PcuSSXISBQ-1; Mon, 01 Nov 2021 13:39:49 -0400 X-MC-Unique: QnEbOR5zM5a3PcuSSXISBQ-1 Received: by mail-vk1-f197.google.com with SMTP id r17-20020ac5cb11000000b002dcd7f5e560so6007269vkl.15 for ; Mon, 01 Nov 2021 10:39:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=z4NYQVK3aHtTDRqu6zQy6uz8Pqd9KplVUdasnUP+N68=; b=TJk590gf3V1txVE21Q5OGiADUH5rSF1eq6Lvl4oU5UVNeX8zK+qUHJBS2H4vNQ/Hfr 2oQGmfrmbLdnkZbFOcRvPk/GynHkZpnwtb70UVgMWhdvgUmaxGyY5DR5Nd276kfs0bdY 1jnz0N8fsf8qmqwtxxX4Tji5ffYMab6RWRJHpFucXxejc4vioyrJ+lJr2JTnMPk6ZFoN UmI8vshEWfsHO0KGWv3fGkToSpKeMX7C5bvDU2g0V4O31lAr1jg+1+iPNRJG6GO8DGUA Ei1sEV9G3vdo7oU32miwe8K3GRyEZR9he3rzf7RotL6TDQ0YL0MLVVyvpoKWD8XYcuqc bN9Q== X-Gm-Message-State: AOAM533RlgwdCNO7EK9ZIHKCHYoqntr1UOyILRViztVt+7QSLCaonDWj ORUcHEcvP8QQWpXCAnXEpPIvO9r87qNuI3WToGrGQwszR27uwiPKmpdu5qAo+05HqGoOlv/iOxQ dE01SuxIvQWeTiH662yp1LaashRC6x3alVEY0 X-Received: by 2002:ab0:2a8b:: with SMTP id h11mr13410420uar.98.1635788388519; Mon, 01 Nov 2021 10:39:48 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyIMXwqaDOFrATcXAYYI3Q6euaROjEoSirF2RSBa7k5d1tZZyi3YdlXer7ebgkpuG2x/0AQ2eEL1LyfFJVcYQ0= X-Received: by 2002:ab0:2a8b:: with SMTP id h11mr13410382uar.98.1635788388264; Mon, 01 Nov 2021 10:39:48 -0700 (PDT) MIME-Version: 1.0 References: <20211028221823.574570-1-amerey@redhat.com> <6137615d-9b33-8e24-4d81-5aa998d7fc1b@polymtl.ca> <5f8f0251-99a9-d4f2-69ae-fe2ad68c838f@polymtl.ca> In-Reply-To: From: Aaron Merey Date: Mon, 1 Nov 2021 13:39:37 -0400 Message-ID: Subject: Re: [PATCH 1/2] gdb: add set/show commands for managing debuginfod To: Simon Marchi Cc: Simon Marchi , gdb-patches@sourceware.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-6.4 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 Nov 2021 17:39:53 -0000 Hi Simon, On Mon, Nov 1, 2021 at 11:52 AM Simon Marchi wrote: > > On 2021-10-30 10:43 p.m., Simon Marchi via Gdb-patches wrote: > > I'm considering fixing this for the index-cache (deprecating the old > > commands, but keeping them as aliases of the new ones). If you agree, I > > could do the same with "set debuginfo" too. > > > > Simon > > > > I sent a patch series changing the index-cache commands here: > > https://sourceware.org/pipermail/gdb-patches/2021-November/182990.html > > Please let met know what you think. That patch set is definitely an improvement. I think you're right that 'set/show debuginfod enabled on/off' is better than needing a 'show debuginfod status' command that has no corresponding set command. I also like that setting getters/setters now return scalars by value. Do you think we need to keep and deprecate the existing 'set debuginfod on/off/ask' and 'show debuginfod status' commands? Personally I'd rather just replace them considering how recently they were added. Aaron