From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pj1-x102f.google.com (mail-pj1-x102f.google.com [IPv6:2607:f8b0:4864:20::102f]) by sourceware.org (Postfix) with ESMTPS id B659E3858C62 for ; Sat, 22 Oct 2022 06:41:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org B659E3858C62 Received: by mail-pj1-x102f.google.com with SMTP id f8-20020a17090a664800b00212464cd49fso4901017pjm.4 for ; Fri, 21 Oct 2022 23:41:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=CT15ic4VDF5L/flusw2obsgM3HakspvYUFblnKWsD10=; b=Zzxx6KhESHQkSrCIDqVKCSuGEEq66Q8lpS5Zax6fezKEe0tnwZYLrlXAejieSygfis 8C0RNkdLfOI+VSVmJghm5ZpsbKmxEAphMxw1wosO5riIkkBQ5ab0WRyJibOufF5dPNmG ixXXT/Oc5cMZ5NXw/utp1TXY86R6T5LTDzLX/JHgp3GOC4aMxBn1cO5VlLcGxnDjx9eB +I1JIgcTBQNIX9l8vwYNZLae2Pz7IL68U3m//V+JwHwgsSwhRHMKeGjBrTeyLHkQmyt7 8oHLVvEdQaGbA13NxAEhU6XTk9/vjl9z+bMpQMZpJMrVA61pXi8mHuT30b3hrTYOoB/X Mfaw== X-Gm-Message-State: ACrzQf302nYSgJUDmDq9aClYfVvlHI0E/ASdGcGkUpMWt9lqjI2dVEur zKjAMD1NHkzGeXMsa5vFp4Bfi4KfWqbIkB0cvA== X-Google-Smtp-Source: AMsMyM6dttDseczEdH6cS4CdYWDenLdKVEl5iAENgfNh6glq9I36LYSbR8dXt+8E/nIyRFxc6yFbvDVn0nyHFv7M8WU= X-Received: by 2002:a17:902:d2c6:b0:17f:348f:cf91 with SMTP id n6-20020a170902d2c600b0017f348fcf91mr23247655plc.2.1666420913668; Fri, 21 Oct 2022 23:41:53 -0700 (PDT) MIME-Version: 1.0 References: <20220528115509.3865342-1-ptsneves@gmail.com> <20220603160139.136115-1-ptsneves@gmail.com> <20220603160139.136115-4-ptsneves@gmail.com> <83wndxbtwn.fsf@gnu.org> <8ed127eb-221b-2b85-1019-1968060f68bc@palves.net> <83y1u0dfjm.fsf@gnu.org> <2ad190e6-7892-d3f6-3426-46878c87a4fa@palves.net> <83o7uwdaq8.fsf@gnu.org> In-Reply-To: From: Paulo Neves Date: Sat, 22 Oct 2022 08:41:42 +0200 Message-ID: Subject: Re: [PATCH v3 4/4] gdb/python doc: Move unwinder skeleton code To: Pedro Alves Cc: Eli Zaretskii , gdb-patches@sourceware.org X-Spam-Status: No, score=-8.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, HTML_MESSAGE, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 22 Oct 2022 06:41:57 -0000 Thank you very much Paulo Neves On Fri, 21 Oct 2022 at 23:07, Pedro Alves wrote: > Hi, > > On 2022-09-30 6:37 p.m., Eli Zaretskii wrote: > >> Cc: ptsneves@gmail.com, gdb-patches@sourceware.org > >> From: Pedro Alves > >> Date: Fri, 30 Sep 2022 17:41:50 +0100 > >> > >> diff --git a/gdb/doc/python.texi b/gdb/doc/python.texi > >> index 2692211f388..4a7b047c3e0 100644 > >> --- a/gdb/doc/python.texi > >> +++ b/gdb/doc/python.texi > >> @@ -2861,21 +2861,21 @@ class MyUnwinder(Unwinder): > >> > >> @end smallexample > >> > >> -@subheading Registering a Unwinder > >> +@subheading Registering an Unwinder > >> > >> -An object file, a program space, and the @value{GDBN} proper can have > >> -unwinders registered with it. > >> +Object files and program spaces can have unwinders registered with > >> +them. In addition, you can also register unwinders globally. > >> > >> -The @code{gdb.unwinders} module provides the function to register a > >> +The @code{gdb.unwinders} module provides the function to register an > >> unwinder: > >> > >> @defun gdb.unwinder.register_unwinder (locus, unwinder, replace=False) > >> -@var{locus} is specifies an object file or a program space to which > >> -@var{unwinder} is added. Passing @code{None} or @code{gdb} adds > >> -@var{unwinder} to the @value{GDBN}'s global unwinder list. The newly > >> -added @var{unwinder} will be called before any other unwinder from the > >> +@var{locus} specifies which unwinder list the @var{unwinder} is > >> +prepended to. It can be either an object file, a program space, or > >> +@code{None}, in which case the unwinder is registered globally. The > >> +newly added @var{unwinder} will be called before any other unwinder > from the > >> same locus. Two unwinders in the same locus cannot have the same > >> -name. An attempt to add a unwinder with already existing name raises > >> +name. An attempt to add an unwinder with an already existing name > raises > >> an exception unless @var{replace} is @code{True}, in which case the > >> old unwinder is deleted. > >> @end defun > > > > That's fine, but let's avoid passive tense where we can (and make the > > sentence easier to grasp while at that). So: > > > > @var{locus} specifies to which unwinder list to prepend the > > @var{unwinder}. > > > > Finally done, and merged. > > Thanks, > Pedro Alves > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pj1-x102f.google.com (mail-pj1-x102f.google.com [IPv6:2607:f8b0:4864:20::102f]) by sourceware.org (Postfix) with ESMTPS id B659E3858C62 for ; Sat, 22 Oct 2022 06:41:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org B659E3858C62 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pj1-x102f.google.com with SMTP id f8-20020a17090a664800b00212464cd49fso4901017pjm.4 for ; Fri, 21 Oct 2022 23:41:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=CT15ic4VDF5L/flusw2obsgM3HakspvYUFblnKWsD10=; b=aZpcR9T08g4rXi0pDV5R/sgrcr/ZmWnfaG6Nutivd8vAhaAusGjcNldfKAQndmu+ig bQf3pQ4PnaljX72YmcUcfmTsiZ3Xt34W9Q8lXamnNXIc0StA8RWHkuTSoONPpvCQjUcM PzBpjRHx60pmlbmEJnMWd9rqt2mxZOXB1ZAQn/mp3rYTbvLd+K9qc4WRe8YNwqYV5EQQ +XmPmyZ3GrHT8jStVcXrcjne3mE83YgsRq5uvRBFCnEayKLm7sR3rDxnb04JA7b2XF/Z cTB7K8OEozwHrSwJ8UhdAMnHzfQj4fdPGpJ7JbhcVsK4vcESJLDPT/37h2qrAkftyRvM gFtg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=CT15ic4VDF5L/flusw2obsgM3HakspvYUFblnKWsD10=; b=Zzxx6KhESHQkSrCIDqVKCSuGEEq66Q8lpS5Zax6fezKEe0tnwZYLrlXAejieSygfis 8C0RNkdLfOI+VSVmJghm5ZpsbKmxEAphMxw1wosO5riIkkBQ5ab0WRyJibOufF5dPNmG ixXXT/Oc5cMZ5NXw/utp1TXY86R6T5LTDzLX/JHgp3GOC4aMxBn1cO5VlLcGxnDjx9eB +I1JIgcTBQNIX9l8vwYNZLae2Pz7IL68U3m//V+JwHwgsSwhRHMKeGjBrTeyLHkQmyt7 8oHLVvEdQaGbA13NxAEhU6XTk9/vjl9z+bMpQMZpJMrVA61pXi8mHuT30b3hrTYOoB/X Mfaw== X-Gm-Message-State: ACrzQf302nYSgJUDmDq9aClYfVvlHI0E/ASdGcGkUpMWt9lqjI2dVEur zKjAMD1NHkzGeXMsa5vFp4Bfi4KfWqbIkB0cvA== X-Google-Smtp-Source: AMsMyM6dttDseczEdH6cS4CdYWDenLdKVEl5iAENgfNh6glq9I36LYSbR8dXt+8E/nIyRFxc6yFbvDVn0nyHFv7M8WU= X-Received: by 2002:a17:902:d2c6:b0:17f:348f:cf91 with SMTP id n6-20020a170902d2c600b0017f348fcf91mr23247655plc.2.1666420913668; Fri, 21 Oct 2022 23:41:53 -0700 (PDT) MIME-Version: 1.0 References: <20220528115509.3865342-1-ptsneves@gmail.com> <20220603160139.136115-1-ptsneves@gmail.com> <20220603160139.136115-4-ptsneves@gmail.com> <83wndxbtwn.fsf@gnu.org> <8ed127eb-221b-2b85-1019-1968060f68bc@palves.net> <83y1u0dfjm.fsf@gnu.org> <2ad190e6-7892-d3f6-3426-46878c87a4fa@palves.net> <83o7uwdaq8.fsf@gnu.org> In-Reply-To: From: Paulo Neves Date: Sat, 22 Oct 2022 08:41:42 +0200 Message-ID: Subject: Re: [PATCH v3 4/4] gdb/python doc: Move unwinder skeleton code To: Pedro Alves Cc: Eli Zaretskii , gdb-patches@sourceware.org Content-Type: multipart/alternative; boundary="0000000000009b07de05eb99da14" X-Spam-Status: No, score=-8.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,HTML_MESSAGE,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Message-ID: <20221022064142.paPUK-YIxCBOErNWu3REkjzms3N33SSlCos96WyQTfA@z> --0000000000009b07de05eb99da14 Content-Type: text/plain; charset="UTF-8" Thank you very much Paulo Neves On Fri, 21 Oct 2022 at 23:07, Pedro Alves wrote: > Hi, > > On 2022-09-30 6:37 p.m., Eli Zaretskii wrote: > >> Cc: ptsneves@gmail.com, gdb-patches@sourceware.org > >> From: Pedro Alves > >> Date: Fri, 30 Sep 2022 17:41:50 +0100 > >> > >> diff --git a/gdb/doc/python.texi b/gdb/doc/python.texi > >> index 2692211f388..4a7b047c3e0 100644 > >> --- a/gdb/doc/python.texi > >> +++ b/gdb/doc/python.texi > >> @@ -2861,21 +2861,21 @@ class MyUnwinder(Unwinder): > >> > >> @end smallexample > >> > >> -@subheading Registering a Unwinder > >> +@subheading Registering an Unwinder > >> > >> -An object file, a program space, and the @value{GDBN} proper can have > >> -unwinders registered with it. > >> +Object files and program spaces can have unwinders registered with > >> +them. In addition, you can also register unwinders globally. > >> > >> -The @code{gdb.unwinders} module provides the function to register a > >> +The @code{gdb.unwinders} module provides the function to register an > >> unwinder: > >> > >> @defun gdb.unwinder.register_unwinder (locus, unwinder, replace=False) > >> -@var{locus} is specifies an object file or a program space to which > >> -@var{unwinder} is added. Passing @code{None} or @code{gdb} adds > >> -@var{unwinder} to the @value{GDBN}'s global unwinder list. The newly > >> -added @var{unwinder} will be called before any other unwinder from the > >> +@var{locus} specifies which unwinder list the @var{unwinder} is > >> +prepended to. It can be either an object file, a program space, or > >> +@code{None}, in which case the unwinder is registered globally. The > >> +newly added @var{unwinder} will be called before any other unwinder > from the > >> same locus. Two unwinders in the same locus cannot have the same > >> -name. An attempt to add a unwinder with already existing name raises > >> +name. An attempt to add an unwinder with an already existing name > raises > >> an exception unless @var{replace} is @code{True}, in which case the > >> old unwinder is deleted. > >> @end defun > > > > That's fine, but let's avoid passive tense where we can (and make the > > sentence easier to grasp while at that). So: > > > > @var{locus} specifies to which unwinder list to prepend the > > @var{unwinder}. > > > > Finally done, and merged. > > Thanks, > Pedro Alves > > --0000000000009b07de05eb99da14--