From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qk1-x735.google.com (mail-qk1-x735.google.com [IPv6:2607:f8b0:4864:20::735]) by sourceware.org (Postfix) with ESMTPS id 9B97A3840C33 for ; Tue, 9 Jun 2020 15:04:09 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 9B97A3840C33 Received: by mail-qk1-x735.google.com with SMTP id c14so21052007qka.11 for ; Tue, 09 Jun 2020 08:04:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=snsynCkYXhoyCDBDTXJ5DVrZEy6fvHBeUaabro01ETY=; b=SXZ9/k6X5cTPcat5LzHyFXBSId7z/aphBs24kNLkzbnD70KDzo5OBIIGdS3Ow6kr2g R3PE7VsN8FRmuq2ccIi6zdUfr8cHNnmkBfXSiDmui9jUFRP8wZgvuvy2UG4iG4yAmC6Q 0UyrCRIPi74Wh+uuA77DLFT03my02uA0X+9gK2wWXngXDCIvKP7hu7pwHJQ2nxlVPkMA Ps5lBdvhZD699Wnc7Ez33AGIE37cDmWKRNBaeMj45RYJO1fMQ45Y905RJ3FTbPhppF4Y y+yVJ8dAC8WQyBjqfSJ688BbfbgYPWO2IeqnaOLtLd3Iy0TcaUz7QZpFq/yS7CSPrb0I CxWQ== X-Gm-Message-State: AOAM533WyMA4aHxwjOv7va50MsldgDXtmHFD9woD80DExAh8Yx5EuM22 wPNi8RuEnTW1xP+LlKwFt/CxJR2jKLTJg+coXnA= X-Google-Smtp-Source: ABdhPJyWHNtVrgsmC/04MjXsYGhPgwkZyzQUHrDmiz+4Hd8kYwwe49i8UEMrMNrdsMRK+ssIzfqFAGVDXrdRsCQMyrY= X-Received: by 2002:a37:448a:: with SMTP id r132mr27583430qka.156.1591715049274; Tue, 09 Jun 2020 08:04:09 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Phi Debian Date: Tue, 9 Jun 2020 17:03:58 +0200 Message-ID: Subject: Re: TUI enhancement suggestion. To: Pedro Alves Cc: gdb-patches@sourceware.org Content-Type: multipart/mixed; boundary="000000000000189a4c05a7a80a74" X-Spam-Status: No, score=-7.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, HTML_MESSAGE, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 09 Jun 2020 15:04:11 -0000 --000000000000189a4c05a7a80a74 Content-Type: text/plain; charset="UTF-8" Here is the patch I made, I spotted a little typo in a comment, I leave it in there for now, and provide this as a demonstrator. I never submitted a patch so I don't really know the best practice, I cutted it on top of 9.2 (latest pull) then the patch) I used $ git format-patch -1 HEAD Cheers, Phi --000000000000189a4c05a7a80a74 Content-Type: text/x-patch; charset="US-ASCII"; name="0001-Implement-point-underline.patch" Content-Disposition: attachment; filename="0001-Implement-point-underline.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_kb820pti0 RnJvbSAzOTVhZTQxNGYzOTVkNThiZDA3YTQ0MDc3ZDQ1ODY1MTI5MjRkNDUxIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQaGkgPHBoaUBrZXJuZWwtdG9vbHMuY29tPgpEYXRlOiBUdWUs IDkgSnVuIDIwMjAgMTE6NTk6NDcgKzAyMDAKU3ViamVjdDogW1BBVENIXSBJbXBsZW1lbnQgcG9p bnQgdW5kZXJsaW5lCgotLS0KIGdkYi90dWkvdHVpLWlvLmMgICAgICAgIHwgMTggKysrKysrKysr KysrKysrKysrCiBnZGIvdHVpL3R1aS1pby5oICAgICAgICB8ICAzICsrKwogZ2RiL3R1aS90dWkt d2luLmMgICAgICAgfCAzMSArKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrCiBnZGIvdHVp L3R1aS13aW4uaCAgICAgICB8ICAzICsrKwogZ2RiL3R1aS90dWktd2luc291cmNlLmMgfCAgNCAr Ky0tCiBnZGIvdWktc3R5bGUuaCAgICAgICAgICB8IDE1ICsrKysrKysrKysrKysrLQogNiBmaWxl cyBjaGFuZ2VkLCA3MSBpbnNlcnRpb25zKCspLCAzIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBh L2dkYi90dWkvdHVpLWlvLmMgYi9nZGIvdHVpL3R1aS1pby5jCmluZGV4IGU3YThhYzc3YmMuLjdk Y2M3NmJhYjggMTAwNjQ0Ci0tLSBhL2dkYi90dWkvdHVpLWlvLmMKKysrIGIvZ2RiL3R1aS90dWkt aW8uYwpAQCAtMjk0LDYgKzI5NCw3IEBAIHR1aV9hcHBseV9zdHlsZSAoV0lORE9XICp3LCB1aV9m aWxlX3N0eWxlIHN0eWxlKQogICAvKiBSZXNldC4gICovCiAgIHdhdHRyb24gKHcsIEFfTk9STUFM KTsKICAgd2F0dHJvZmYgKHcsIEFfQk9MRCk7CisgIHdhdHRyb2ZmICh3LCBBX1VOREVSTElORSk7 CiAgIHdhdHRyb2ZmICh3LCBBX0RJTSk7CiAgIHdhdHRyb2ZmICh3LCBBX1JFVkVSU0UpOwogICBp ZiAobGFzdF9jb2xvcl9wYWlyICE9IC0xKQpAQCAtMzMwLDYgKzMzMSwxMCBAQCB0dWlfYXBwbHlf c3R5bGUgKFdJTkRPVyAqdywgdWlfZmlsZV9zdHlsZSBzdHlsZSkKICAgICBjYXNlIHVpX2ZpbGVf c3R5bGU6Ok5PUk1BTDoKICAgICAgIGJyZWFrOwogCisgICAgY2FzZSB1aV9maWxlX3N0eWxlOjpV TkRFUkxJTkU6CisgICAgICB3YXR0cm9uICh3LCBBX1VOREVSTElORSk7IAorICAgICAgYnJlYWs7 CisKICAgICBjYXNlIHVpX2ZpbGVfc3R5bGU6OkJPTEQ6CiAgICAgICB3YXR0cm9uICh3LCBBX0JP TEQpOwogICAgICAgYnJlYWs7CkBAIC00MjMsNiArNDI4LDE5IEBAIHR1aV9zZXRfcmV2ZXJzZV9t b2RlIChXSU5ET1cgKncsIGJvb2wgcmV2ZXJzZSkKICAgdHVpX2FwcGx5X3N0eWxlICh3LCBzdHls ZSk7CiB9CiAKKwordm9pZAordHVpX3NldF9wb2ludF9tb2RlIChXSU5ET1cgKncsIGJvb2wgbW9k ZSkKK3sgdWlfZmlsZV9zdHlsZSBzdHlsZSA9IGxhc3Rfc3R5bGU7CisgIGlmKHBvaW50X3VuZGVy bGluZT09MCkKKyAgeyB0dWlfc2V0X3JldmVyc2VfbW9kZSh3LG1vZGUpOworICB9CisgIGlmKHBv aW50X3VuZGVybGluZT09MSkKKyAgeyBzdHlsZS5zZXRfdW5kZXJsaW5lKG1vZGUpOworICAgIHR1 aV9hcHBseV9zdHlsZSAodywgc3R5bGUpOworICB9ICAKK30KKwogLyogUHJpbnQgTEVOR1RIIGNo YXJhY3RlcnMgZnJvbSB0aGUgYnVmZmVyIHBvaW50ZWQgdG8gYnkgQlVGIHRvIHRoZQogICAgY3Vy c2VzIGNvbW1hbmQgd2luZG93LiAgVGhlIG91dHB1dCBpcyBidWZmZXJlZC4gIEl0IGlzIHVwIHRv IHRoZQogICAgY2FsbGVyIHRvIHJlZnJlc2ggdGhlIHNjcmVlbiBpZiBuZWNlc3NhcnkuICAqLwpk aWZmIC0tZ2l0IGEvZ2RiL3R1aS90dWktaW8uaCBiL2dkYi90dWkvdHVpLWlvLmgKaW5kZXggZjI4 Y2Y0ZTEyZC4uOGFhODFiNDNkOCAxMDA2NDQKLS0tIGEvZ2RiL3R1aS90dWktaW8uaAorKysgYi9n ZGIvdHVpL3R1aS1pby5oCkBAIC01MSw2ICs1MSw5IEBAIGV4dGVybiBnZGI6OnVuaXF1ZV94bWFs bG9jX3B0cjxjaGFyPiB0dWlfZXhwYW5kX3RhYnMgKGNvbnN0IGNoYXIgKik7CiAvKiBFbnRlci9s ZWF2ZSByZXZlcnNlIHZpZGVvIG1vZGUuICAqLwogZXh0ZXJuIHZvaWQgdHVpX3NldF9yZXZlcnNl X21vZGUgKFdJTkRPVyAqdywgYm9vbCByZXZlcnNlKTsKIAorLyogRW50ZXIvbGVhdmUgcG9pbnQg KGV4ZWMpIHZpZGVvIG1vZGUuICAqLworZXh0ZXJuIHZvaWQgdHVpX3NldF9wb2ludF9tb2RlIChX SU5ET1cgKncsIGJvb2wgbW9kZSk7CisKIC8qIEFwcGx5IFNUWUxFIHRvIHRoZSB3aW5kb3cuICAq LwogZXh0ZXJuIHZvaWQgdHVpX2FwcGx5X3N0eWxlIChXSU5ET1cgKncsIHVpX2ZpbGVfc3R5bGUg c3R5bGUpOwogCmRpZmYgLS1naXQgYS9nZGIvdHVpL3R1aS13aW4uYyBiL2dkYi90dWkvdHVpLXdp bi5jCmluZGV4IGE3ODgzN2ZlNjguLjU0MzM2ZTEzMzcgMTAwNjQ0Ci0tLSBhL2dkYi90dWkvdHVp LXdpbi5jCisrKyBiL2dkYi90dWkvdHVpLXdpbi5jCkBAIC04MjMsNiArODIzLDI5IEBAIHR1aV9z aG93X2NvbXBhY3Rfc291cmNlIChzdHJ1Y3QgdWlfZmlsZSAqZmlsZSwgaW50IGZyb21fdHR5LAog ICBwcmludGZfZmlsdGVyZWQgKF8oIlRVSSBzb3VyY2Ugd2luZG93IGNvbXBhY3RuZXNzIGlzICVz LlxuIiksIHZhbHVlKTsKIH0KIAorCitib29sIHBvaW50X3VuZGVybGluZSA9IGZhbHNlOworCisv KiBDYWxsYmFjayBmb3IgInNldCB0dWkgcG9pbnQtdW5kZXJsaW5lIi4gICovCisKK3N0YXRpYyB2 b2lkCit0dWlfc2V0X3BvaW50X3VuZGVybGluZSAoY29uc3QgY2hhciAqaWdub3JlLCBpbnQgZnJv bV90dHksCisJCQlzdHJ1Y3QgY21kX2xpc3RfZWxlbWVudCAqYykKK3sKKyAgaWYgKFRVSV9TUkNf V0lOICE9IG51bGxwdHIpCisgICAgVFVJX1NSQ19XSU4tPnJlZmlsbCAoKTsKK30KKworLyogQ2Fs bGJhY2sgZm9yICJzaG93IHR1aSBjb21wYWN0LXNvdXJjZSIuICAqLworCitzdGF0aWMgdm9pZAor dHVpX3Nob3dfcG9pbnRfdW5kZXJsaW5lIChzdHJ1Y3QgdWlfZmlsZSAqZmlsZSwgaW50IGZyb21f dHR5LAorCQkJIHN0cnVjdCBjbWRfbGlzdF9lbGVtZW50ICpjLCBjb25zdCBjaGFyICp2YWx1ZSkK K3sKKyAgcHJpbnRmX2ZpbHRlcmVkIChfKCJUVUkgc291cmNlIHBvaW50IHVuZGVybGluZSBpcyAl cy5cbiIpLCB2YWx1ZSk7Cit9CisKKwogLyogU2V0IHRoZSB0YWIgd2lkdGggb2YgdGhlIHNwZWNp ZmllZCB3aW5kb3cuICAqLwogc3RhdGljIHZvaWQKIHR1aV9zZXRfdGFiX3dpZHRoX2NvbW1hbmQg KGNvbnN0IGNoYXIgKmFyZywgaW50IGZyb21fdHR5KQpAQCAtMTEyMCw2ICsxMTQzLDE0IEBAIHRo ZSBsaW5lIG51bWJlcnMgYW5kIHVzZXMgbGVzcyBob3Jpem9udGFsIHNwYWNlLiIpLAogCQkJICAg dHVpX3NldF9jb21wYWN0X3NvdXJjZSwgdHVpX3Nob3dfY29tcGFjdF9zb3VyY2UsCiAJCQkgICAm dHVpX3NldGxpc3QsICZ0dWlfc2hvd2xpc3QpOwogCisgIGFkZF9zZXRzaG93X2Jvb2xlYW5fY21k ICgicG9pbnQtdW5kZXJsaW5lIiwgY2xhc3NfdHVpLAorCQkJICAgJnBvaW50X3VuZGVybGluZSwg XygiXAorU2V0IHdoZXRoZXIgdGhlIFRVSSBzb3VyY2UgcG9pbnQgbGluZSBpcyB1bmRlcmxpbmUu IiksIF8oIlwKK1Nob3cgd2hldGhlciB0aGUgVFVJIHNvdXJjZSBwb2ludCBsaW5lIGlzIHVuZGVy bGluZS4iKSwgXygiXAorVGhpcyB2YXJpYWJsZSBjb250cm9scyB3aGV0aGVyIHRoZSBUVUkgc291 cmNlIHBvaW50IGxpbmUgaXMgdW5kZXJsaW5lZC5cbiIpLAorCQkJICAgdHVpX3NldF9wb2ludF91 bmRlcmxpbmUsIHR1aV9zaG93X3BvaW50X3VuZGVybGluZSwKKwkJCSAgICZ0dWlfc2V0bGlzdCwg JnR1aV9zaG93bGlzdCk7ICAKKwogICB0dWlfYm9yZGVyX3N0eWxlLmNoYW5nZWQuYXR0YWNoICh0 dWlfcmVoaWdobGlnaHRfYWxsKTsKICAgdHVpX2FjdGl2ZV9ib3JkZXJfc3R5bGUuY2hhbmdlZC5h dHRhY2ggKHR1aV9yZWhpZ2hsaWdodF9hbGwpOwogfQpkaWZmIC0tZ2l0IGEvZ2RiL3R1aS90dWkt d2luLmggYi9nZGIvdHVpL3R1aS13aW4uaAppbmRleCBlMzc5MTg0NjMwLi5kNWZiZmM1ZmVhIDEw MDY0NAotLS0gYS9nZGIvdHVpL3R1aS13aW4uaAorKysgYi9nZGIvdHVpL3R1aS13aW4uaApAQCAt NTcsNCArNTcsNyBAQCBzdHJ1Y3QgY21kX2xpc3RfZWxlbWVudCAqKnR1aV9nZXRfY21kX2xpc3Qg KHZvaWQpOwogLyogV2hldGhlciBjb21wYWN0IHNvdXJjZSBkaXNwbGF5IHNob3VsZCBiZSB1c2Vk LiAgKi8KIGV4dGVybiBib29sIGNvbXBhY3Rfc291cmNlOwogCisvKiBXaGV0aGVyIHVuZGVybGlu ZSBwb2ludCBsaW5lIHNob3VsZCBiZSB1c2VkLiAgKi8KK2V4dGVybiBib29sIHBvaW50X3VuZGVy bGluZTsKKwogI2VuZGlmIC8qIFRVSV9UVUlfV0lOX0ggKi8KZGlmZiAtLWdpdCBhL2dkYi90dWkv dHVpLXdpbnNvdXJjZS5jIGIvZ2RiL3R1aS90dWktd2luc291cmNlLmMKaW5kZXggZGIwYWRkOTk2 OC4uYzlmNDkzMjkyYSAxMDA2NDQKLS0tIGEvZ2RiL3R1aS90dWktd2luc291cmNlLmMKKysrIGIv Z2RiL3R1aS90dWktd2luc291cmNlLmMKQEAgLTI1OCwxMiArMjU4LDEyIEBAIHR1aV9zb3VyY2Vf d2luZG93X2Jhc2U6OnNob3dfc291cmNlX2xpbmUgKGludCBsaW5lbm8pCiAKICAgbGluZSA9ICZt X2NvbnRlbnRbbGluZW5vIC0gMV07CiAgIGlmIChsaW5lLT5pc19leGVjX3BvaW50KQotICAgIHR1 aV9zZXRfcmV2ZXJzZV9tb2RlIChoYW5kbGUuZ2V0ICgpLCB0cnVlKTsKKyAgICB0dWlfc2V0X3Bv aW50X21vZGUgKGhhbmRsZS5nZXQgKCksIHRydWUpOwogCiAgIHdtb3ZlIChoYW5kbGUuZ2V0ICgp LCBsaW5lbm8sIFRVSV9FWEVDSU5GT19TSVpFKTsKICAgdHVpX3B1dHMgKGxpbmUtPmxpbmUuY19z dHIgKCksIGhhbmRsZS5nZXQgKCkpOwogICBpZiAobGluZS0+aXNfZXhlY19wb2ludCkKLSAgICB0 dWlfc2V0X3JldmVyc2VfbW9kZSAoaGFuZGxlLmdldCAoKSwgZmFsc2UpOworICAgIHR1aV9zZXRf cG9pbnRfbW9kZSAoaGFuZGxlLmdldCAoKSwgZmFsc2UpOwogCiAgIC8qIENsZWFyIHRvIGVuZCBv ZiBsaW5lIGJ1dCBzdG9wIGJlZm9yZSB0aGUgYm9yZGVyLiAgKi8KICAgeCA9IGdldGN1cnggKGhh bmRsZS5nZXQgKCkpOwpkaWZmIC0tZ2l0IGEvZ2RiL3VpLXN0eWxlLmggYi9nZGIvdWktc3R5bGUu aAppbmRleCA0OGFiNTJkNWVhLi41NTY2ZjM4YzJmIDEwMDY0NAotLS0gYS9nZGIvdWktc3R5bGUu aAorKysgYi9nZGIvdWktc3R5bGUuaApAQCAtMTM1LDcgKzEzNSw4IEBAIHN0cnVjdCB1aV9maWxl X3N0eWxlCiAgIHsKICAgICBOT1JNQUwgPSAwLAogICAgIEJPTEQsCi0gICAgRElNCisgICAgRElN LAorICAgIFVOREVSTElORQogICB9OwogCiAgIHVpX2ZpbGVfc3R5bGUgKCkgPSBkZWZhdWx0OwpA QCAtMjEwLDYgKzIxMSwxOCBAQCBzdHJ1Y3QgdWlfZmlsZV9zdHlsZQogICAgIG1fYmFja2dyb3Vu ZCA9IGM7CiAgIH0KIAorICAvKiBTZXQgdGhlIGludGVuc2l0eSBvZiB0aGlzIHN0eWxlIHRvIGJv bGQgICovCisgIHZvaWQgc2V0X2JvbGQgKGJvb2wgbW9kZSkgCisgIHsgCisgICAgbV9pbnRlbnNp dHk9bW9kZT9CT0xEOk5PUk1BTDsKKyAgfQorCisgIC8qIFNldCB0aGUgaW50ZW5zaXR5IG9mIHRo aXMgc3R5bGUgdG8gYm9sZCAgKi8KKyAgdm9pZCBzZXRfdW5kZXJsaW5lIChib29sIG1vZGUpIAor ICB7IAorICAgIG1faW50ZW5zaXR5PW1vZGU/VU5ERVJMSU5FOk5PUk1BTDsKKyAgfQorCiAgIC8q IFJldHVybiB0aGUgaW50ZW5zaXR5IG9mIHRoaXMgc3R5bGUuICAqLwogICBpbnRlbnNpdHkgZ2V0 X2ludGVuc2l0eSAoKSBjb25zdAogICB7Ci0tIAoyLjI1LjEKCg== --000000000000189a4c05a7a80a74--