From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qv1-xf2c.google.com (mail-qv1-xf2c.google.com [IPv6:2607:f8b0:4864:20::f2c]) by sourceware.org (Postfix) with ESMTPS id D0E7E394742E for ; Thu, 11 Jun 2020 13:55:53 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org D0E7E394742E Received: by mail-qv1-xf2c.google.com with SMTP id p15so2647680qvr.9 for ; Thu, 11 Jun 2020 06:55:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ash9DdRGV0j5VT+XJan4U/bpavtl7ebrVPp6s2vRKk8=; b=fynS8Xh8fgjxt+HpMPSD9G5yFKGHeNgGNdOBnnZu6p72o1mu6Zmak/eOG2CYY2p1AN 4+3hoN6qxCkiB5Ko8p48QA84MGlNPsLqhc/U8pxOK6cgCUvVtlZX0ucW/63acsAwW6qG JfVJIGCZ+ss/YfrKy+327XAwTGbsiybr2kPYNdVy3dc64rkmEln+HwpqLpmW3I6h7DUu J8j/WcPSzL4bnvxl6ra0pSHJNo+NZsD9gOa/MV3BpGLweWYpOD8bVJQzgvAgzFnM0vsj szFSvOZB9Dfl0JH/RXbtrMD3CXHTNCZQjWC6Z+Pr0Cyiujs67IsVAclfKf8g2mWqeiFA Fd/Q== X-Gm-Message-State: AOAM531WX3lc6jSXCB+99NfAMvkdRlD8PwJmkO3CcfRAQY29cYJaevVY Vi2A3YN7+10xfkYKNGGydA5Lg5UE26crMtnEkc4M/6Pc X-Google-Smtp-Source: ABdhPJzljvPFkQuRVTv88Oe7iijxizSWooMmd97sQXPRTumYjtp29s/pcxok8SjcWeB6hLWkWBzyHhokiv+Wvix8Uq0= X-Received: by 2002:a05:6214:11f0:: with SMTP id e16mr7794978qvu.37.1591883753430; Thu, 11 Jun 2020 06:55:53 -0700 (PDT) MIME-Version: 1.0 References: <38b5d874-cdf2-50e7-dc76-aed3fee20334@redhat.com> In-Reply-To: <38b5d874-cdf2-50e7-dc76-aed3fee20334@redhat.com> From: Phi Debian Date: Thu, 11 Jun 2020 15:55:42 +0200 Message-ID: Subject: Re: TUI enhancement suggestion. To: Pedro Alves Cc: gdb-patches@sourceware.org X-Spam-Status: No, score=-2.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, HTML_MESSAGE, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 11 Jun 2020 13:55:54 -0000 Ok I got the big picture, the little patch I made was more a demonstrator than a final patch, I don't know the review process. As soon as I can I redo one, with our remarks. Regarding the underline going up to printf I made it on purpose as I find it less intrusive, underlinie space is simple, while underlining text (source) can render less readable again (like colors), so it is something I can spot quickly but not too intrusive. I use very tall xterm, spotting the underline in the space part is very easy easier thanjust the little > before the line number.. That was the reasoning... Yet I admit, when there is no styling it should works too so I will look again :) I can't work too much on this unfortunately so it may be a while since I come black to this. Cheers