From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id D17813858C39 for ; Mon, 27 Nov 2023 12:27:37 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D17813858C39 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org D17813858C39 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701088059; cv=none; b=nXQu4Ss6nWJAaaIPMeA0KZulmb6JpUq/jOWXyjGn/M2A+TKbanC1Mc3m2b1F9OiB6FPflVBaHPbIjsIdzotF3ynt8sR+91v8Evu680tiWkWwTw48Bb2HfXsroX6aJkTIGf76mdBBDeAAS+rJuvTx3mq5mVAT823Jx1puMbM5I/c= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701088059; c=relaxed/simple; bh=GTvJ2zXjXIDmKRocpi+PZMvisG3dSBEnWkThIXNZqwA=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=aN0ClPXvPtQC8JAnoviUITFwb4Gm0hSV2kGRebY4SsWuoNZnAZFZx+xns0AfPX0ewnbZHpU0yCSDYHbFbFU/y6Kg0hJ4NAWOKIYhCc9jDmxBMzHc/QmTjYd/2qgw1cJQgLFUK/B1LBDjK8Trc5E0sA5AkicvpySIKDFn2CUSPsQ= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1701088057; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=/KPaW747v+FHVNFWjr1MRe8K0Tq1UxgHJoY6x1KIgXY=; b=F0Pkmx55Im1SDh+3P+QJKP5ClRlp+F0ZUEYhltlIEo9YJP1Y1ZEZeuob1sS6GlagX/XQWd nt/tovvbowmInajrsR40Im1dWyWybKgFvxm2DJtDdkd7kTchQO7PzhmEWN00Rd1h/bAVXC vOKl1XbPPUfeE+YWjYJt2rdnCsVrfBA= Received: from mail-pj1-f71.google.com (mail-pj1-f71.google.com [209.85.216.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-660-j-SpXnmqMp6Yvb1QjcQfkQ-1; Mon, 27 Nov 2023 07:27:34 -0500 X-MC-Unique: j-SpXnmqMp6Yvb1QjcQfkQ-1 Received: by mail-pj1-f71.google.com with SMTP id 98e67ed59e1d1-285adda4d3dso2472993a91.3 for ; Mon, 27 Nov 2023 04:27:34 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701088053; x=1701692853; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=/KPaW747v+FHVNFWjr1MRe8K0Tq1UxgHJoY6x1KIgXY=; b=W6vYE9g20b/1smqbvmFrq8w/7XrQA4D4hrCDssRCpXx7mR3k4KVVk45fFKMBpGQt54 igwtajhMdS1sMYbt6+tEPO4Roro+oaxNUXwGW3uNdq5y54DZtNoY/3//jS5+oMs4+dYk sGybfU6Tkfya1xn3ObNS1j1QemVcONpYxI2XPbHbjbFXbaYE17c5qAr6dRsIZiInHWPy xrEVvG0sQPaRx55AXSmTW+1tPiXktBcA0Ml/oELqwQuslLsdpcprLuhqzMIwkvoxrbWQ uohoN+cgZPeAdbY8W0Ytbh2AvewSVSO4M0G4hUdRgb5GPZq5xzME1DdIZY48um7AjgvG PmpQ== X-Gm-Message-State: AOJu0Yx/0txt/8kCXpj0kJKreKwvAIxhqqzJ+86ry+7RlKqqtlBGzYxy vsxQbnIq8Dl6YGqjtA7mpyWQHrXc72sd3AKqsdHvs/9Tw+V8Q4sYNVNljUpTSyQzEf/njK8jfbY l9uBnykpzi6PnPyFFoZoz7ehAlCRxEM5rAE69/SPm4k1FDeK8 X-Received: by 2002:a17:90b:3883:b0:285:a0ae:6a65 with SMTP id mu3-20020a17090b388300b00285a0ae6a65mr6838922pjb.17.1701088053096; Mon, 27 Nov 2023 04:27:33 -0800 (PST) X-Google-Smtp-Source: AGHT+IEDUKZ2UpcX2qoemqpTnlK2HqcPRwWzu86o3UDLYGiiSM5N8duqCx+GwqswAYUoMppk/daFJ4ifHrRe0SMrwlE= X-Received: by 2002:a17:90b:3883:b0:285:a0ae:6a65 with SMTP id mu3-20020a17090b388300b00285a0ae6a65mr6838902pjb.17.1701088052780; Mon, 27 Nov 2023 04:27:32 -0800 (PST) MIME-Version: 1.0 References: <20231126075250.31557-1-tdevries@suse.de> In-Reply-To: <20231126075250.31557-1-tdevries@suse.de> From: Alexandra Petlanova Hajkova Date: Mon, 27 Nov 2023 13:27:21 +0100 Message-ID: Subject: Re: [PATCH v2] [gdb/tui] Show regs when switching to regs layout To: Tom de Vries Cc: gdb-patches@sourceware.org, Tom Tromey X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: multipart/alternative; boundary="0000000000001e3178060b216d64" X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,HTML_MESSAGE,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --0000000000001e3178060b216d64 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Sun, Nov 26, 2023 at 8:52=E2=80=AFAM Tom de Vries wro= te: > When starting gdb in CLI mode, running to main and switching into the TUI > regs > layout: > ... > $ gdb -q a.out -ex start -ex "layout regs" > ... > we get: > ... > +---------------------------------+ > | | > | [ Register Values Unavailable ] | > | | > +---------------------------------+ > ... > > Fix this by handling this case in tui_data_window::rerender. > > Tested on x86_64-linux. > > PR tui/28600 > Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=3D28600 > --- > I can confirm I can see this issue on ppc64le Fedora Rawhide and this patch > fixes this. I'm able to see the Register group now > when running "gdb/gdb -q /bin/ls -ex start -ex "layout regs"". I can also confirm this change does not introduce any regressions. --0000000000001e3178060b216d64--