From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id E74243858C53 for ; Thu, 24 Aug 2023 08:58:09 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E74243858C53 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1692867489; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=7NtgdAZFHGhG81FC9r4hjM6075LE2mYanRZGFggkwgI=; b=VrYEWqmco2nm9z0pstvpV2g+35RJSd/7fx25tmOWqOOgK7qAKey+cZpuvgdeG1BJx6Jfpc jzJ7E3RAiLHn7DcmaQgaYUlDIptTzFlVmN7+z8mRqvg+nspLDO+qs4R2qfl2KNjrkOSBqK VYRNg2hsG03KRUeUq6G+7QlOtFLrf3M= Received: from mail-pj1-f72.google.com (mail-pj1-f72.google.com [209.85.216.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-137-JZJdtwu3OIm0W1JML7HOog-1; Thu, 24 Aug 2023 04:56:58 -0400 X-MC-Unique: JZJdtwu3OIm0W1JML7HOog-1 Received: by mail-pj1-f72.google.com with SMTP id 98e67ed59e1d1-26d43d10ce5so8497319a91.3 for ; Thu, 24 Aug 2023 01:56:58 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692867417; x=1693472217; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=7NtgdAZFHGhG81FC9r4hjM6075LE2mYanRZGFggkwgI=; b=lYkEZYhB8dXLPBzvqfZRtUPYy4xph2OeF2ULS18n53Z4yI1Tuw8ea57/trOL50l0j8 f7QFEWEzsSknKiMrHOpdUiRscRczq2/hXFN/7x8wwGjqNdKGcn5VKLKibkNwkmlDohpO atoyrr9xnPhnlW6F4ndu3kb5LAbDqHZf4ugRg9ao5NoYFUCCGTdw2bG3hcdrlW7R0oBE GnyUfqyTAwgOpqnVgXsQZspoW+3gwNfh0NYABgBxyOa8EY7xL1Vpq/QJTRJuO8tIxQ3g AHXBlnHvKkTX/LWKROjgMYDnB63hRlJ/ZZn0AROpV9hGbC1dlRa2ESyHwdmtPDrreo7H DaOw== X-Gm-Message-State: AOJu0Yw55K7Vy5nfmbr1zEvglC10wYkFTXPoiTrTwD38e0g5x1yl7ZX5 x8QxcSL8P+NHnNU5MpG2TsVfk7VvDLXuDah3gK0Bnthe3E7aCGbBK6N4lcHHwWkXuPLONNCaP3t 3V4tdDVdIjtZ6tqWDpsVACRLTkGM+Qifw8bXRND6VfcZyIQ== X-Received: by 2002:a17:90b:108d:b0:268:1e51:3496 with SMTP id gj13-20020a17090b108d00b002681e513496mr13845353pjb.21.1692867417609; Thu, 24 Aug 2023 01:56:57 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHizwlnRTgk1Gu8/TmLG2E0BkRNEU4KMGU9H1EpyqUvDn/gZQLTQMuDQ01Zs4Sh11vplL9Ved4rBEp/YNhVU/o= X-Received: by 2002:a17:90b:108d:b0:268:1e51:3496 with SMTP id gj13-20020a17090b108d00b002681e513496mr13845345pjb.21.1692867417319; Thu, 24 Aug 2023 01:56:57 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Alexandra Petlanova Hajkova Date: Thu, 24 Aug 2023 10:56:46 +0200 Message-ID: Subject: Re: [PATCH 03/10] gdb: improve show text and help text for 'remote exec-file' To: Andrew Burgess Cc: gdb-patches@sourceware.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: multipart/alternative; boundary="0000000000000fc6760603a7692f" X-Spam-Status: No, score=-3.9 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,HTML_MESSAGE,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --0000000000000fc6760603a7692f Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, Aug 16, 2023 at 5:56=E2=80=AFPM Andrew Burgess via Gdb-patches < gdb-patches@sourceware.org> wrote: > The current behaviour for 'show remote exec-file' is this: > > (gdb) show remote exec-file > > (gdb) set remote exec-file /abc > (gdb) show remote exec-file > /abc > (gdb) > > The first output, the blank line, is just GDB showing the default > empty value. > > This output is not really inline with GDB's more full sentence style > output, so in this commit I've updated things, the output is now: > > (gdb) show remote exec-file > The remote exec-file is unset, the default remote executable will be > used. > (gdb) set remote exec-file /abc > (gdb) show remote exec-file > The remote exec-file is "/abc". > (gdb) > > Which I think is more helpful to the user. > > I have also updated the help text for this setting. Previously we had > a set/show header line, but no body text, now we have: > > (gdb) help show remote exec-file > Show the remote pathname for starting inferiors. > This is the path, on the remote target, used when starting an inferior, > for example with the "run", "start", or "starti" commands. > This setting is only useful when debugging a remote target, otherwise, > this setting is not used. > (gdb) > > Which is hopefully more helpful. > > I really like the change in behaviour. Showing the blank line for the default remote exec-file is confusing. The more verbose help is also much more informative. I think more verbose is almost always better. I can confirm this change causes no regressions on ppc64le Fedora-Rawhide. --0000000000000fc6760603a7692f--