From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 3CDEF3858D1E for ; Tue, 18 Apr 2023 12:21:06 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3CDEF3858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1681820465; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=W1s23sXOmrc7Pi+v+nFk3mFluLS8Jd4FpGbgS99OVOE=; b=QUjjIKiO0Cy+mllBoSIRNxOoua6NOdFvzBfzETYoiABF/iELn+PbVJZNOqwZgJ5WMARVJk Zg5uTZyB8T9a+NCfkxpAIx5qnGtOj5GGInTecyjUAxmLNn1vjbHBGCFJEUayUp8W9sSKc+ +2Uyj9QWnFKasAkABUq1UzDm6Yty1P4= Received: from mail-pj1-f71.google.com (mail-pj1-f71.google.com [209.85.216.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-46-B1mRUx4sNkqmWANtE3_E8g-1; Tue, 18 Apr 2023 08:21:04 -0400 X-MC-Unique: B1mRUx4sNkqmWANtE3_E8g-1 Received: by mail-pj1-f71.google.com with SMTP id 98e67ed59e1d1-2473f8329f7so1497402a91.1 for ; Tue, 18 Apr 2023 05:21:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681820463; x=1684412463; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=W1s23sXOmrc7Pi+v+nFk3mFluLS8Jd4FpGbgS99OVOE=; b=kk7tP90eng9LaMatnnNP8RAFn+blzMkQ5jKIaT4Chqq+QyPzu25atOcNB2kfoniWBS w2nzF9mk463Yxxf66Cz1fXEIAA5WIBNC6EJLOY5Emj+w2j2zpf1nW/7qj8MuS5nNUKka ZMKAOJhhkpPEc3eUF1ifWTkaXeBq40n2jetQA0y6wMErOowa1/bP5Nr3OGAAyzAcOaxS e5NEynMMh3fToTzjH0CUv4wYk0PvfpQMzgPtOePnSdgqV8sLCZpots4p0Rw6rXsl6nqF 0mh3hPNtydhu/SFFOz0P7dkmdz1jXsFWPc9O0k3jpKfO/f1JUoT/7FkrE+sGT6OOv1XA XOpw== X-Gm-Message-State: AAQBX9du/Cm+wUfqGN47QvMxkja3hrcNdZlQp+uB6xOaqCSkLUSEYjMS 0jWqapU0UcEFe9TExuh9tm/baSv/P/IWFgSTOqZ/iSCLuF5pCvGZQjVOpUpxI7gGeIvu8jCPlxt 41cXA5yeUEtPPhpnOq6UZy7XxzSXaKLyeArW1naystceodA== X-Received: by 2002:a17:90b:808:b0:23b:38b2:f0bd with SMTP id bk8-20020a17090b080800b0023b38b2f0bdmr1780898pjb.15.1681820463275; Tue, 18 Apr 2023 05:21:03 -0700 (PDT) X-Google-Smtp-Source: AKy350bH6ch1iT29/cQZtGudXEu/uD9T0wagsqXbmysEn0WvkNSiLjF2I/tNdB2hyoFXs1ZgGy6Gtpr1Pa32P/md09c= X-Received: by 2002:a17:90b:808:b0:23b:38b2:f0bd with SMTP id bk8-20020a17090b080800b0023b38b2f0bdmr1780879pjb.15.1681820462948; Tue, 18 Apr 2023 05:21:02 -0700 (PDT) MIME-Version: 1.0 References: <20230320145638.1202335-1-ahajkova@redhat.com> <87jzya4jya.fsf@tromey.com> In-Reply-To: <87jzya4jya.fsf@tromey.com> From: Alexandra Petlanova Hajkova Date: Tue, 18 Apr 2023 14:20:51 +0200 Message-ID: Subject: Re: [PATCH v2] Use styled_string when defering warnings when loading separate debug files To: Tom Tromey Cc: =?UTF-8?Q?Alexandra_H=C3=A1jkov=C3=A1_via_Gdb=2Dpatches?= X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: multipart/alternative; boundary="0000000000004539b705f99b5774" X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,HTML_MESSAGE,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --0000000000004539b705f99b5774 Content-Type: text/plain; charset="UTF-8" I think instead of a std::vector, what I meant was just use > a single string_file. > > The caller can make it, using something like: > > string_file file (gdb_stderr->can_emit_style_escape ()); > > Alexandra> + string_file warnings (true); > > ... since I think 'true' isn't always correct. > When is it not true? > > Alexandra> + warnings.printf ("\"%ps\":separate debug info file has > no debug info", > Alexandra> + styled_string (file_name_style.style (), > Alexandra> + bfd_get_filename > (abfd.get ()))); > > Then this printf can either add a 'warning:' prefix like warning() does, > or we can add an overload of "warning" that takes a ui_file as its first > parameter. > So you would prefer me to use a single string_file instead of a vector of those. That means I'll have just a single string and I'll be appending each new warning to it? I used a vector because I don't know how to easily split the warnings when printing them. Do you mean I should add an overload of a "warning" that would be capable of splitting strings? But why is such a solution better then simply using a vector of string_file? Thank you for the review, Alexandra --0000000000004539b705f99b5774--