From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 067523853D3D for ; Mon, 10 Jul 2023 12:46:21 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 067523853D3D Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1688993181; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=4bOSS7zBtWMRqWlZTI9Bs5s0vLXhktji12wpZcMni/8=; b=GTX4cuxBf8Ud4vlZ7xPH3p5on5jqdQfOwRqBakHnObtHEiTBgsfMu2V9gmCdNfI8q+nKY+ tDsgPWPs0lJl3N/oJ1Xi243VSBeZFeQ/r5aGd0UPnexwMa5+psKV0ksTA4pldE3O4pojFC WIYoRwZ5kUP8/welZoljvelcVcLqXSM= Received: from mail-oo1-f69.google.com (mail-oo1-f69.google.com [209.85.161.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-393-TnneiB66O6iwuiWyAu_2NQ-1; Mon, 10 Jul 2023 08:46:20 -0400 X-MC-Unique: TnneiB66O6iwuiWyAu_2NQ-1 Received: by mail-oo1-f69.google.com with SMTP id 006d021491bc7-565d30b4311so3344472eaf.1 for ; Mon, 10 Jul 2023 05:46:20 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688993179; x=1691585179; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=4bOSS7zBtWMRqWlZTI9Bs5s0vLXhktji12wpZcMni/8=; b=iCWHsU6ZvsXqpBj0POir+8jKNGQP6VuiEU2mKpFrBEVvqwB+jEWdunsemU4gWzpWSL naebzBshfi1S4Wst98DKT3VwcwrszziS45GOVXf4aA9D+W62q714JsfxLVr/BrL/Dw4S k9IUFTSGDNWqUAjxEA/bGtTat1is3vMKPQxu3G9ACtn8lLIpswo5dWjyVYoVJyqS0Dsk wwkXV6OpHao7ahydui2dwSbkVsZh3Pd+0i+LHswfGlDNOGeSFzOMwbHutajlUEyJP5Ah 5H5iMF47+r2iJtdWraCczyIPdcQq/1zp9CJomWUe2kj6OrW8w/U4N4y7ezhi87aKlYeO Tj+w== X-Gm-Message-State: ABy/qLYP55lAs1CM5LYhKsAaCPrcLswBdO6qBKaVFIVISW4bAB+/ItAn g97ZJvY0rPhNfNglGxaZAlShVhckDEfR0xX15F/g/lNVlSkjoKjDd8WgntElYvviUOuUwmnqGUe +YQvdPZHdMtG9N+1HqxcHjHU0bErT0+w5UBvipKABpBqvVA== X-Received: by 2002:a05:6870:b52b:b0:1b3:dc5b:13c7 with SMTP id v43-20020a056870b52b00b001b3dc5b13c7mr14424545oap.43.1688993179334; Mon, 10 Jul 2023 05:46:19 -0700 (PDT) X-Google-Smtp-Source: APBJJlGA5+Q5zTqB9lUnco7lfz6o+aq7pCiasbTls7ESxl7Ymxpd26apUgeBV2DTsmKVk8I+dtfFRdTR9rI5YNjsJwM= X-Received: by 2002:a05:6870:b52b:b0:1b3:dc5b:13c7 with SMTP id v43-20020a056870b52b00b001b3dc5b13c7mr14424535oap.43.1688993179023; Mon, 10 Jul 2023 05:46:19 -0700 (PDT) MIME-Version: 1.0 References: <20230703030458.1192525-1-zhiyong.yan@windriver.com> In-Reply-To: <20230703030458.1192525-1-zhiyong.yan@windriver.com> From: Alexandra Petlanova Hajkova Date: Mon, 10 Jul 2023 14:46:07 +0200 Message-ID: Subject: Re: [PATCH] gdbserver: Install single-step breakpoint for a pending thread whose last_resume_kind is resume_step To: zhiyong.yan@windriver.com Cc: gdb-patches@sourceware.org, tom@tromey.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: multipart/alternative; boundary="00000000000076cca50600215ec1" X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,HTML_MESSAGE,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --00000000000076cca50600215ec1 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, Jul 3, 2023 at 5:05=E2=80=AFAM wrote: > From: Zhiyong Yan > > Gdb should not assume pending threads always generate =E2=80=9Ca non-gdbs= erver > trap event=E2=80=9D, for example =E2=80=9CSignal 17=E2=80=9D event could = happen. Now that > resume_stopped_resumed_lwps() -> may_hw_step() assumes that the break poi= nt > must already exist, resume_one_thread() should ensure the software breaki= ng > point is installed although the thread is pending. > > Signed-off-by: Zhiyong Yan zhiyong.yan@windriver.com > Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=3D30387 I can confirm this patch causes no regression Fedora-Rawhide, ppc64le. --00000000000076cca50600215ec1--