From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id EAEE838582A5 for ; Thu, 1 Feb 2024 12:44:27 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org EAEE838582A5 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org EAEE838582A5 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1706791472; cv=none; b=WlpmdzNlN3VuwwTfpmwDyKMLyIv415NIWe9AGuUGVAIc54d4+W1dR7mBOEA0qsF0DdVIiVXNKUqtKrxRyqtKXE2WQnZvo75t/ECn3U2hCZZxP0WnJZTUOVzfMdKt9I2wl2U0GpuRWhX/Td9RkapXjQStcu6s7q9nnNoUfhIxqmE= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1706791472; c=relaxed/simple; bh=hfUwy8X7nfoZti+B2ZnBILHVMshek0xYVd8GMWUsPEA=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=ezZ8KcB2ziY7qP8W/9Lx1nXzD2yPLae6uJ/jWlppJQQhP54bvwHyqUNAnABPlI0y1WeBuyxDggELC5sBmzO7grdTtCQadd+jMWQONexZM8g2TmyWubfKr3qj81lpDdwkmnVcwjDZtkIj00lLDz7MmGEAIgm0FHKhTuqYvMKMIBg= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1706791467; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=l3qEITwjJ+Nn/uRIoVpBpshG8Pkw4prjusMfEwpK/Mk=; b=WYcvHtl/y/mXiShpofjl9h0v7jxJnH4uY8UhvfmE+apgmzOO83TFB04OMqV4PTyG6r6zCh 3DvrDmQQtXq+bA2dvm56Cp1zD3IwnpNQGt4eo8dkjqt58oEiEpk88f3C2t/pv/k1JKtZKp BV7dL2cf+KXRjBxv/uDfjo8sCSwdGOc= Received: from mail-pj1-f69.google.com (mail-pj1-f69.google.com [209.85.216.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-151-vuK9m1Y6Nuy9m4k26aeIyw-1; Thu, 01 Feb 2024 07:44:26 -0500 X-MC-Unique: vuK9m1Y6Nuy9m4k26aeIyw-1 Received: by mail-pj1-f69.google.com with SMTP id 98e67ed59e1d1-295ced898c2so745093a91.3 for ; Thu, 01 Feb 2024 04:44:25 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706791465; x=1707396265; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=l3qEITwjJ+Nn/uRIoVpBpshG8Pkw4prjusMfEwpK/Mk=; b=fwKNx+6da+Am5Vx8cD/EIZggTmxlIi1uHW9WpzCozPa14/v2NXsW0IQicQCvWHfnEs 0VHNAI/3D/bmiQ7U+9lnibRlGqxxOtL+hAnrJue9SabHUFpVeTDJB0mG4VP0nFToomom nfUydMp6DG9ZU/fJ/s4MX6nCbHSkOxRYyeSrGbusvMbmxQAorXlbMjOsd1Qoy1viBv9j k/a8OAi0V3fui7XzE7kIS5UNavBU3yz9nB2HoLvWGpteCW8MBHdnFhhhNdZt2bZC0je4 tkaLqXMUGfV23s+pVv5QAi3dNrBONTCrYTtvbHa1qz4YEOloa8ccPm61iwo5PJXe7tgE vbAA== X-Gm-Message-State: AOJu0YysenbJEpBp2MHiXNkBN0L00PWdAEASK6F97xGV0RMJFLzJOtHB ja4mpqkoykutjkAEqve7AWMFrcch4dn5We/+vE2BJ9MJPQcmRe7GNySLTxplxxiQTIhzmaXBcuN UMm/h9KIYhTItHgRPb6uOH5MciJj+QnomqgkqNXmPBjZ4gEltgRZJuVHXJstGWO1wvg7+fzvoZc Xm9oXK7FjA8CKOgG3C1dBXwtxZRRx82b8S4jx2Tb+PSQ== X-Received: by 2002:a17:90a:f0c4:b0:296:2578:a54c with SMTP id fa4-20020a17090af0c400b002962578a54cmr556956pjb.38.1706791464890; Thu, 01 Feb 2024 04:44:24 -0800 (PST) X-Google-Smtp-Source: AGHT+IGFU5g+TeJs4SNTzTD/DuQCUCvclEysXfAj9ufc2w/2OPxq1TLLHlFsgznF0buKTPEDN4+YaY/YuShG2+EQjnI= X-Received: by 2002:a17:90a:f0c4:b0:296:2578:a54c with SMTP id fa4-20020a17090af0c400b002962578a54cmr556932pjb.38.1706791464541; Thu, 01 Feb 2024 04:44:24 -0800 (PST) MIME-Version: 1.0 References: <20240129164622.628652-1-tromey@adacore.com> In-Reply-To: <20240129164622.628652-1-tromey@adacore.com> From: Alexandra Petlanova Hajkova Date: Thu, 1 Feb 2024 13:44:13 +0100 Message-ID: Subject: Re: [PATCH] Rename SEARCH_ALL To: Tom Tromey Cc: gdb-patches@sourceware.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: multipart/alternative; boundary="000000000000f331c90610515ad3" X-Spam-Status: No, score=-11.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,HTML_MESSAGE,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --000000000000f331c90610515ad3 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, Jan 29, 2024 at 5:47=E2=80=AFPM Tom Tromey wro= te: > The constant SEARCH_ALL conflicts with a define in a Windows header. > This patch renames the constant to SEARCH_ALL_DOMAINS to avoid the > conflict. > > Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=3D31307 > --- > gdb/ada-lang.c | 2 +- > gdb/compile/compile-cplus-symbols.c | 2 +- > gdb/python/py-symbol.c | 2 +- > gdb/symfile-debug.c | 4 ++-- > gdb/symmisc.c | 2 +- > gdb/symtab.c | 2 +- > gdb/symtab.h | 4 ++-- > 7 files changed, 9 insertions(+), 9 deletions(-) > > diff --git a/gdb/ada-lang.c b/gdb/ada-lang.c > index f1d01ec7aa3..52bae581af6 100644 > --- a/gdb/ada-lang.c > +++ b/gdb/ada-lang.c > @@ -13533,7 +13533,7 @@ class ada_language : public language_defn > NULL, > NULL, > SEARCH_GLOBAL_BLOCK | SEARCH_STATIC_BLOCK, > - SEARCH_ALL); > + SEARCH_ALL_DOMAINS); > > I can confirm this change does not introduce any regressions for aarch64 Fedora Rawhide. --000000000000f331c90610515ad3--