From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 651CC3858CDA for ; Wed, 12 Oct 2022 22:02:41 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 651CC3858CDA Received: from mail-pf1-f198.google.com (mail-pf1-f198.google.com [209.85.210.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-331-ZQ_JNJ_7OdWOOuddAKzYVQ-1; Wed, 12 Oct 2022 18:02:39 -0400 X-MC-Unique: ZQ_JNJ_7OdWOOuddAKzYVQ-1 Received: by mail-pf1-f198.google.com with SMTP id y15-20020aa78f2f000000b00562674456afso115964pfr.9 for ; Wed, 12 Oct 2022 15:02:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=rdKN0/gEceyuZjrnOhbhcXae2nzfpiHBCIuVrYDNN0Y=; b=bSfVOAhFZX5IfoMWeAoB/pSSlXElD0jFxzwL/sMCOzkRKMNIXhMec+5Q9kpCk8PUfp f3wj166/kZycJCJzfRDDxaGW6/05xKktRp6hFGqxbiuclI2zsKW4Qs4cTUedHja0G7wu nJVlMtbkchRHzCSb+vfTXTQojI/RgJuiR7mZqwQVtfMYCthJjMNnM+6aGoy9f0iaYZV5 jMdSsy0RlfY5thco07JC3AhRVHIgNRvBYd+1sXWcZv7rn8NRyf5A5Motgk+j8yjgECCU 7xLxcoayfbwoD6v+5kOY1JMfs59aiLJHkmx7o/2sQyMAn3jlqgARtKFRBOJxl4Y93DW+ l3yA== X-Gm-Message-State: ACrzQf0lMQGmQZG3flXtca4zF0swMaKETga+WQ47/Ua4Xrg2nCVQogTD GFDKyyDoeuaOEpSu+8/sN5IvZk3uZhwMpfd2R+beNnXCUSW5soWIotEcb6h+V5jf1+4ecUfG7Nv C4G/GcpSYxZJkYGNiopoNbPLKX8fkWopglBv1KQ== X-Received: by 2002:a65:45c1:0:b0:461:5855:8d86 with SMTP id m1-20020a6545c1000000b0046158558d86mr18005023pgr.436.1665612158703; Wed, 12 Oct 2022 15:02:38 -0700 (PDT) X-Google-Smtp-Source: AMsMyM6F8JFJfXNM+gaX2EK4D7dOMH4zQ0rKGc94HBxXbyC815zceoatugoZQm9yN2DH9tAd9Fe2yKO+LlDHuTLDUgw= X-Received: by 2002:a65:45c1:0:b0:461:5855:8d86 with SMTP id m1-20020a6545c1000000b0046158558d86mr18005011pgr.436.1665612158441; Wed, 12 Oct 2022 15:02:38 -0700 (PDT) MIME-Version: 1.0 References: <20221012185327.370210-1-amerey@redhat.com> In-Reply-To: <20221012185327.370210-1-amerey@redhat.com> From: Alexandra Petlanova Hajkova Date: Thu, 13 Oct 2022 00:02:27 +0200 Message-ID: Subject: Re: [PING*3][PATCH v4] gdb: Improve debuginfod progress updates To: Aaron Merey Cc: gdb-patches@sourceware.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-Spam-Status: No, score=-3.0 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, HTML_MESSAGE, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 12 Oct 2022 22:02:43 -0000 On Wed, Oct 12, 2022 at 8:54 PM Aaron Merey via Gdb-patches < gdb-patches@sourceware.org> wrote: > Hi, > > I made a couple small adjustments to this patch to ensure it builds > on the main branch. Otherwise the original v4 patch follow: > > v3 can be found here: > https://sourceware.org/pipermail/gdb-patches/2022-February/185798.html > > Changes from v3 include a simplified progress update API and display. > Truncation of the progress update message has been removed as well. > > If the download size is known, a progress bar is displayed along with > the percentage of completion and the total download size. > > Downloading separate debug info for /lib/libxyz.so > [############ ] 25% (10.01 MB) > > If the download size is not known, a progress indicator is displayed > with a ticker ("###") that moves across the screen at a rate of 1 tick > every 0.5 seconds. > > Downloading separate debug info for /lib/libxyz.so > [ ### ] > > I think this version addresses all the concernes from the previous > iterations and I > confirm it applies on top of the current master cleanly, it should be good to go. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 651CC3858CDA for ; Wed, 12 Oct 2022 22:02:41 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 651CC3858CDA Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1665612160; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=rdKN0/gEceyuZjrnOhbhcXae2nzfpiHBCIuVrYDNN0Y=; b=HcF8D6zGXHaJPoNXkbYjXA4LwEM6qhq+KcrD+GnkH0B6BDg8hhXBWQpd4PEfCotrP1yhnG mVm8GgRegZNgWmp2dDdWeL5XxE6pBq4WJcMT33Rtc6BG/GuO7t4dlNmmc9Hk+t0ib6PLoI ePysbdH0b8PlVZ16aufvE53MqQtL+28= Received: from mail-pf1-f198.google.com (mail-pf1-f198.google.com [209.85.210.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-331-ZQ_JNJ_7OdWOOuddAKzYVQ-1; Wed, 12 Oct 2022 18:02:39 -0400 X-MC-Unique: ZQ_JNJ_7OdWOOuddAKzYVQ-1 Received: by mail-pf1-f198.google.com with SMTP id y15-20020aa78f2f000000b00562674456afso115964pfr.9 for ; Wed, 12 Oct 2022 15:02:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=rdKN0/gEceyuZjrnOhbhcXae2nzfpiHBCIuVrYDNN0Y=; b=bSfVOAhFZX5IfoMWeAoB/pSSlXElD0jFxzwL/sMCOzkRKMNIXhMec+5Q9kpCk8PUfp f3wj166/kZycJCJzfRDDxaGW6/05xKktRp6hFGqxbiuclI2zsKW4Qs4cTUedHja0G7wu nJVlMtbkchRHzCSb+vfTXTQojI/RgJuiR7mZqwQVtfMYCthJjMNnM+6aGoy9f0iaYZV5 jMdSsy0RlfY5thco07JC3AhRVHIgNRvBYd+1sXWcZv7rn8NRyf5A5Motgk+j8yjgECCU 7xLxcoayfbwoD6v+5kOY1JMfs59aiLJHkmx7o/2sQyMAn3jlqgARtKFRBOJxl4Y93DW+ l3yA== X-Gm-Message-State: ACrzQf0lMQGmQZG3flXtca4zF0swMaKETga+WQ47/Ua4Xrg2nCVQogTD GFDKyyDoeuaOEpSu+8/sN5IvZk3uZhwMpfd2R+beNnXCUSW5soWIotEcb6h+V5jf1+4ecUfG7Nv C4G/GcpSYxZJkYGNiopoNbPLKX8fkWopglBv1KQ== X-Received: by 2002:a65:45c1:0:b0:461:5855:8d86 with SMTP id m1-20020a6545c1000000b0046158558d86mr18005023pgr.436.1665612158703; Wed, 12 Oct 2022 15:02:38 -0700 (PDT) X-Google-Smtp-Source: AMsMyM6F8JFJfXNM+gaX2EK4D7dOMH4zQ0rKGc94HBxXbyC815zceoatugoZQm9yN2DH9tAd9Fe2yKO+LlDHuTLDUgw= X-Received: by 2002:a65:45c1:0:b0:461:5855:8d86 with SMTP id m1-20020a6545c1000000b0046158558d86mr18005011pgr.436.1665612158441; Wed, 12 Oct 2022 15:02:38 -0700 (PDT) MIME-Version: 1.0 References: <20221012185327.370210-1-amerey@redhat.com> In-Reply-To: <20221012185327.370210-1-amerey@redhat.com> From: Alexandra Petlanova Hajkova Date: Thu, 13 Oct 2022 00:02:27 +0200 Message-ID: Subject: Re: [PING*3][PATCH v4] gdb: Improve debuginfod progress updates To: Aaron Merey Cc: gdb-patches@sourceware.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: multipart/alternative; boundary="00000000000009c4b505eadd8d1f" X-Spam-Status: No, score=-3.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,HTML_MESSAGE,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Message-ID: <20221012220227.iuKw9U5fFf-2j6To9JV0obgkDFGpfOzWvB9If-bKAro@z> --00000000000009c4b505eadd8d1f Content-Type: text/plain; charset="UTF-8" On Wed, Oct 12, 2022 at 8:54 PM Aaron Merey via Gdb-patches < gdb-patches@sourceware.org> wrote: > Hi, > > I made a couple small adjustments to this patch to ensure it builds > on the main branch. Otherwise the original v4 patch follow: > > v3 can be found here: > https://sourceware.org/pipermail/gdb-patches/2022-February/185798.html > > Changes from v3 include a simplified progress update API and display. > Truncation of the progress update message has been removed as well. > > If the download size is known, a progress bar is displayed along with > the percentage of completion and the total download size. > > Downloading separate debug info for /lib/libxyz.so > [############ ] 25% (10.01 MB) > > If the download size is not known, a progress indicator is displayed > with a ticker ("###") that moves across the screen at a rate of 1 tick > every 0.5 seconds. > > Downloading separate debug info for /lib/libxyz.so > [ ### ] > > I think this version addresses all the concernes from the previous > iterations and I > confirm it applies on top of the current master cleanly, it should be good to go. --00000000000009c4b505eadd8d1f--