From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 4C6583858D38 for ; Mon, 12 Feb 2024 17:19:57 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 4C6583858D38 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 4C6583858D38 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1707758400; cv=none; b=gewzlKVrR6LrmumFvk8toyPUv02u269z4L5hui/G9l95qR4xQjk+LNwldPhK9vGkmaBrYrmdp+M7fudZCST6VcNtK0Y1QVr1k/ftmvi0jHdrjDTXti4z7QcWZroWMcsrdLjW3vZ1SgzzRpA3a0cYfbXo30KY0qxOGDIqHtz7Sec= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1707758400; c=relaxed/simple; bh=ejpQslvcxi+17Uj4Y232bQR2ekUzeA0yGQ+GsgHXBks=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=jg+Kl+DkBecpOykg9+1sVBLq4Y8iatPARSaCQ6UemWsmCwVCffgo/dapZzCRbQroAeCTlgypORHIbtuo5Wnc6qU61GB8KEVgwbPqc/52CxKP6YTF3F0l/w8ElgZhoOeASayVshHb4G35VOQKisxdJT/mJ+AGsM7x+muKHYMThMc= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1707758397; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ejpQslvcxi+17Uj4Y232bQR2ekUzeA0yGQ+GsgHXBks=; b=MGyS215dh4hYJyUrZRMg5jUi+ySHuzVx1Sfn3XudVKpJDyosgaWZdx9HDXajOTwy7knkec LAnb2oOWlKAbwsfwbpQDCKLG0E8C8GPs5V/JczLpV/DwYq9zg8UFJcyu7fw9/JmEQBbTcn ILYBiFTPZmrom+qUk5jv4BF+IjrBIpw= Received: from mail-pj1-f72.google.com (mail-pj1-f72.google.com [209.85.216.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-392-jYI5s5QJMVyQ4MrziuqyHA-1; Mon, 12 Feb 2024 12:19:43 -0500 X-MC-Unique: jYI5s5QJMVyQ4MrziuqyHA-1 Received: by mail-pj1-f72.google.com with SMTP id 98e67ed59e1d1-296f586bdc7so3331374a91.3 for ; Mon, 12 Feb 2024 09:19:43 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707758382; x=1708363182; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ejpQslvcxi+17Uj4Y232bQR2ekUzeA0yGQ+GsgHXBks=; b=e94ORa4n15tjckPZvsJhW3JnCaMvU+sqDR5sq6O7xasVvWwOcfjwUU6QRbrkWW1pfv LT1sBwUOT0T/uKAndfbggXRD2qGrTkTrhvH8/h2jn8p+z2G5X635Hz5kMcJ66KrEyms2 YRpDWYyBosXpiRfOWZtiT4STbm95BqmYOOGaNj87LyBkKJlRqX+NiTtrUVFFW0KZ0hdw 9WUrI8ADEH4nN/98Fvm/FZPEehIdlG9HToUG4UdtlCgykHNXt/IJHIT+l8MSaajbTJJT qh5tIASMsQUO7dI8PfJGcPfPF9/tnRHysh69pMCaRei4mIx56RB5MPFqhrXtNJyAu3Yn SQDg== X-Gm-Message-State: AOJu0Yw4k+hzmWiXTX8DolbiE1XlKwVXLpAl6+zx7IpYm62DvaHGDaaQ yoIAui9ROLLURFb/4zWqVNuNgxXzmWnrTHJ0aqdjcqp0GiCk+za9eWAVnp8yIfHKIQjyI6iiSCa yz/vvRAqSEuid6A5jnLlPuZTaHwYp9pjvrcVh9lBDYOu/uO2xt+36Fk6Gpn+NtlDDquwqUeWApp 2JvGFEpF2ZBJDTmUmsM5iEBFZ+VejC5Wsc03cwgEVrSQ== X-Received: by 2002:a17:90a:ee8a:b0:28e:20d5:a047 with SMTP id i10-20020a17090aee8a00b0028e20d5a047mr4585840pjz.27.1707758381993; Mon, 12 Feb 2024 09:19:41 -0800 (PST) X-Google-Smtp-Source: AGHT+IE8haR/xZRaaxtHQUiW1rl2zCcR9aYW9QClhCR3zCNn3xT63kzh7eVSYbelO0PEpOw/NcE3Mo7zj0NeO3gg1Dk= X-Received: by 2002:a17:90a:ee8a:b0:28e:20d5:a047 with SMTP id i10-20020a17090aee8a00b0028e20d5a047mr4585823pjz.27.1707758381633; Mon, 12 Feb 2024 09:19:41 -0800 (PST) MIME-Version: 1.0 References: <20240210004253.2352981-1-tom@tromey.com> In-Reply-To: <20240210004253.2352981-1-tom@tromey.com> From: Alexandra Petlanova Hajkova Date: Mon, 12 Feb 2024 18:19:29 +0100 Message-ID: Subject: Re: [PATCH] Use DW_FORM_ref_addr for DIE offset in .debug_names To: Tom Tromey Cc: gdb-patches@sourceware.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: multipart/alternative; boundary="000000000000b324f10611327bef" X-Spam-Status: No, score=-4.9 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,HTML_MESSAGE,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --000000000000b324f10611327bef Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Sat, Feb 10, 2024 at 1:43=E2=80=AFAM Tom Tromey wrote: > Today I realized that while the .debug_names writer uses DW_FORM_udata > for the DIE offset, DW_FORM_ref_addr would be more appropriate here. > This patch makes this change. > > Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=3D31361 > > I can confirm this change does not introduce any regressions for ppc64le, Fedora Rawhide --000000000000b324f10611327bef--