From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 86C3F3858D35 for ; Mon, 22 Apr 2024 11:33:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 86C3F3858D35 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 86C3F3858D35 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713785601; cv=none; b=wRWlDFHGVIUX++ZvG/eM7kX9iDDXraDkUUKJLxk+JcD4fQR0ak/Jllirfi1WjERP9JkEiu7D6JZ6q4XHeDJ66NIE+L42FgRldUulpLCA/w/zUgTZU0PSRDO5laQVDzmxT9mDzpHsZNP9ckozzxkEBZ3acfNOKC0gM1h/ETkBZKc= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713785601; c=relaxed/simple; bh=t0SwIVISMz2IRag6xb9mQ4Wc/U982tJHo/tQY1KI4tY=; h=DKIM-Signature:MIME-Version:From:Date:Message-ID:Subject:To; b=SIQqJusmWh4Df1/yT30ekqLXccHWnD3mcSmH1SyfAGT5xonzsPxfVmCC6LkQhP/xG+qqCio9Sy4IYwve7qnP1gzKZmOQ6JWyTGqDZql5oJ6jd5i5J3ci0X6PNLRFoQ8kq8+NDC0Ienfu6s8eq4ElXJUX44Gz8gT6IsJ5D9G9I0o= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1713785591; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=hAAiLiwgiU8tPXKf93Uqn1mRc2WzWWjy/g+wtAtnnPs=; b=HxkztO5AeEiw3wFiU64pBBrusvCqDJSWkWntgeAQy5u6lCNRi9EOKJC8iDi8RUbkq9WSzq kVKtNIJqkKxoHPlhCEA1VS4mBhf830go4ypolaoEMluOTKIhaefuANgHZ4rI/DJ1AsnkDi nPASs/+NW2tZDBVMZnuwFPy+eqj25DI= Received: from mail-pl1-f198.google.com (mail-pl1-f198.google.com [209.85.214.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-494-_u8OHNINPsu9llkdUcbpaw-1; Mon, 22 Apr 2024 07:33:09 -0400 X-MC-Unique: _u8OHNINPsu9llkdUcbpaw-1 Received: by mail-pl1-f198.google.com with SMTP id d9443c01a7336-1e8afd9e4ceso36507485ad.2 for ; Mon, 22 Apr 2024 04:33:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713785588; x=1714390388; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=hAAiLiwgiU8tPXKf93Uqn1mRc2WzWWjy/g+wtAtnnPs=; b=jquabCpZJCtgfEQMocto8GmBqDinmOXjJx5sFlvWMVtmY0zjyhejCKI/jnPnpSCMYA +VDGc6kyc2fv5goUfq1btr+RDdOy+Q7tQZK6lRz0HZch5XPiMk/6wUysT3lZ/x8LFXgy Y4EydnbnLQgOMkiETwywV+4UB4P9eRjkKu3dwlspOJWcI68D3A/RpJRLqJY2a2MWR982 TL1KbLlWOdIeKUeaViNJCX8HWFBYfvDH5CJI3JwWUjl70U54Efd3nTRwejVszjWbgfMp XSGeR5s4Uak0RaC3vSTUGYiJ6fwLL/FxxEwxGRxdBMGBWoBX+j755dr5uifsbbQz1Jw4 7ttA== X-Forwarded-Encrypted: i=1; AJvYcCVlz3hXp1I1mtH2Jpqi2470Q4ca6OUd6vFh9TmcoEw4TkfRGwmzgK+z4UnIjGwdLZNcYJFHL9z3aI6NkHiE2aC+m3+cRl0lIo4Drw== X-Gm-Message-State: AOJu0YyIZLn733h00jHoTvpC08hBB6B/iqcCq5k1NpW4gDpPqHwckCbv llpT8zkzfjXEH4iZKvbXMspqWrxntKe04NvHkR7w4ObbkSkTyLv6C9BgSFsowAnjOx0yU9qcmiF V0VaiaI4jxdt7j/gpQvvliUlCvKbCPXUsoXU28A1IH0U+N837rsbhv1lbMdVJ2abnvKdqW+9ahV YtikoFFTJzS+Qc695TExelssN8jpxYU6tIdQZqxM1+MQ== X-Received: by 2002:a17:902:ea05:b0:1e8:9054:1019 with SMTP id s5-20020a170902ea0500b001e890541019mr11365326plg.54.1713785588334; Mon, 22 Apr 2024 04:33:08 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHPE8SYn42fEtltxzygFpmhfKIAtiCmgbsWWSUd0QBUfiEmFkUin4zUcma+wghtpTgVWXX8QLFUxKxjH8DhuDU= X-Received: by 2002:a17:902:ea05:b0:1e8:9054:1019 with SMTP id s5-20020a170902ea0500b001e890541019mr11365304plg.54.1713785587965; Mon, 22 Apr 2024 04:33:07 -0700 (PDT) MIME-Version: 1.0 References: <20240419151342.1592474-1-pedro@palves.net> <20240419151342.1592474-7-pedro@palves.net> <87r0f1w5uf.fsf@tromey.com> In-Reply-To: <87r0f1w5uf.fsf@tromey.com> From: Alexandra Petlanova Hajkova Date: Mon, 22 Apr 2024 13:32:56 +0200 Message-ID: Subject: Re: [PATCH 06/12] Improve vRun error reporting To: Tom Tromey Cc: Pedro Alves , gdb-patches@sourceware.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: multipart/alternative; boundary="000000000000313d940616adcdf4" X-Spam-Status: No, score=-4.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,HTML_MESSAGE,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,RCVD_IN_SORBS_WEB,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --000000000000313d940616adcdf4 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, Apr 19, 2024 at 8:44=E2=80=AFPM Tom Tromey wrote: > >>>>> "Pedro" =3D=3D Pedro Alves writes: > > Pedro> To know whether we have a textual error message, extend > packet_result > Pedro> to carry that information. While at it, convert packet_result to > use > Pedro> factory methods, and change its std::string parameter to a plain > const > Pedro> char *, as that it always what we have handy to pass to it. > > Didn't Alexandra have a similar series? > > My series touches the same area but this patch does not conflict with them. I would say this enhances what I've done. --000000000000313d940616adcdf4--