From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 636C13858C66 for ; Mon, 15 May 2023 13:13:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 636C13858C66 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1684156384; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=tLbEKZKSu186PZU3crc9rPjjz5lRS0DPkkbXS1/i+zQ=; b=ahk6MwL9FB0vIMa4FEiP1HLjk8blEBqNjsNnfrQIc01BwSOQUT6H+nYIC+TbQJ+0gxXJSH X7uSDAr57AqWQhPW8CBICEjMn/83WmAuYtyhpvBKiIzJLh+s8YfHXnaEbMOjdfAihfI10g xE4LcrhSNazWp5r1KqYu66JxKCjAFmE= Received: from mail-pf1-f197.google.com (mail-pf1-f197.google.com [209.85.210.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-494-PriV0CnkN7u6wDl28ID_Jw-1; Mon, 15 May 2023 09:13:02 -0400 X-MC-Unique: PriV0CnkN7u6wDl28ID_Jw-1 Received: by mail-pf1-f197.google.com with SMTP id d2e1a72fcca58-645538f6101so45617606b3a.1 for ; Mon, 15 May 2023 06:13:02 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684156381; x=1686748381; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=tLbEKZKSu186PZU3crc9rPjjz5lRS0DPkkbXS1/i+zQ=; b=eO4Fxog19unGfuXvv9KI2CPoncbXvvY65G8z/Tae7gNgGG3drUzhovbYegJII+w8YA zGOQzkBWgajFReWW5ZYYAIH7m0wajtDRYp83vPsxECqlJ1HgPtkAsVHaLJ79fM0SGcpo b8H5jKUsDiy0eyke+FyrgGZ3y4y2zTpEgE6W2AG139MSaMot1R4NWASZZ2FDqQW49ggT +aniiqod4/aGENgEWqfoixj0CRjY36KAAiWFEfqupaET5x11ydhzecxUAic1DllagoYm tnWiqbhssGr68FS+H06L6WzTM7YjaHt9Q0BRa2Vm3njKReW8Ec2Rjkt7/vBbd7HLH2b0 VJDQ== X-Gm-Message-State: AC+VfDxsvO7ej1kRzZ8A+p7ZyYgvL0tBwzzDKgEdXnanNuESUhlepdZj S++zFMiMHSvD3wpEmhuAzoJoSLkYoSs1qVzpUlx7Yce8W3EYWaHk6+mHrzYEmHTS+vDfUfhQFu8 HLrJYBi1I1psmcg6tS7SogUgXpc//68ZkoKILBVrD3y2+mw== X-Received: by 2002:a17:90a:1503:b0:24e:14a4:9b92 with SMTP id l3-20020a17090a150300b0024e14a49b92mr38692488pja.5.1684156381176; Mon, 15 May 2023 06:13:01 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ418qrDEAXg6GcFNhMPkwx3b+aggCU7onDvHOyk9YZdeq62g9L/Hx0/z1YNojxVlzcEZbPWACAXViUVrvnxO8E= X-Received: by 2002:a17:90a:1503:b0:24e:14a4:9b92 with SMTP id l3-20020a17090a150300b0024e14a49b92mr38692470pja.5.1684156380902; Mon, 15 May 2023 06:13:00 -0700 (PDT) MIME-Version: 1.0 References: <20230511144832.17974-1-simon.marchi@efficios.com> <20230511144832.17974-3-simon.marchi@efficios.com> In-Reply-To: <20230511144832.17974-3-simon.marchi@efficios.com> From: Alexandra Petlanova Hajkova Date: Mon, 15 May 2023 15:12:49 +0200 Message-ID: Subject: Re: [PATCH 02/12] gdb: make some breakpoint methods use `this` To: Simon Marchi Cc: gdb-patches@sourceware.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: multipart/alternative; boundary="000000000000d48ff205fbbb3681" X-Spam-Status: No, score=-4.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,HTML_MESSAGE,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --000000000000d48ff205fbbb3681 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, May 11, 2023 at 4:49=E2=80=AFPM Simon Marchi via Gdb-patches < gdb-patches@sourceware.org> wrote: > Some implementations of breakpoint::check_status and > breakpoint::print_it do this: > > struct breakpoint *b =3D bs->breakpoint_at; > > bs->breakpoint_at is always the same as `this` (we can get convinced by > looking at the call sites of check_status and print_it), so it would > just be clearer to access fields through `this` instead. > > Change-Id: Ic542a64fcd88e31ae2aad6feff1da278c7086891 > > I think this chage simplifies the code and I can confirm this change causes no regressions on aarch64 Fedora_Rawhide. --000000000000d48ff205fbbb3681--