On Mon, Oct 2, 2023 at 2:52 PM Tom de Vries via Gdb-patches <
gdb-patches@sourceware.org> wrote:

> When dumping m_die_range_map using:
> ...
>     addrmap_dump (&m_die_range_map, gdb_stdlog, nullptr);
> ...
> I get:
> ...
>   0x00000000000000d4 0x355e600
>   0x00000000000000de 0x355e630
>   0x00000000000000f5 0x355e600
>   0x0000000000000101 0x0
>   0x00000000000001c2 0x355e7b0
>   0x00000000000001cc 0x355e7e0
>   0x00000000000001e3 0x355e7b0
>   0x00000000000001ef 0x0
> ...
> which doesn't make it clear which cooked_die_entries the values refer to.
>
> Add a function parent_map::dump that passes an annotation function
> to addrmap_dump such that we have instead:
> ...
>   0x00000000000000d4 0x360d300 (0xd3)
>   0x00000000000000de 0x360d330 (0xdd)
>   0x00000000000000f5 0x360d300 (0xd3)
>   0x0000000000000101 0x0
>   0x00000000000001c2 0x360d4b0 (0x1c1)
>   0x00000000000001cc 0x360d4e0 (0x1cb)
>   0x00000000000001e3 0x360d4b0 (0x1c1)
>   0x00000000000001ef 0x0
> ...
>
> Tested on x86_64-linux.
> ---
>  I think is a very useful cahnge. I can confirm this causes no regrissions
> on ppc64le Fedora Rawhide.
>