From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 4C3E83858D28 for ; Tue, 10 Oct 2023 09:06:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 4C3E83858D28 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1696928764; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Ax27D/rGgqHkkI0NXZaZdvDOmnpN2yz62vuwNqiW3WY=; b=PXqrI+U1LktF6ei2+wA/SlRHdgoUP8QHw1AdKbTqMftNk4bAvhnSs3EnbUO5timPGoOPEN +3I0KwZQ9O6UaJ/oZZ7Wx50dxV5cgE4NGyyF4uRy2oaF5D2YTBMeCG1l2H+57hSkF2muuD bWYOBt+f1d1sx24aPE4AoLAqpwQwKAE= Received: from mail-pj1-f69.google.com (mail-pj1-f69.google.com [209.85.216.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-84-FOZTjtcpPPeO4muxumqa3g-1; Tue, 10 Oct 2023 05:06:03 -0400 X-MC-Unique: FOZTjtcpPPeO4muxumqa3g-1 Received: by mail-pj1-f69.google.com with SMTP id 98e67ed59e1d1-2773b534dd2so4240038a91.2 for ; Tue, 10 Oct 2023 02:06:02 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696928762; x=1697533562; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Ax27D/rGgqHkkI0NXZaZdvDOmnpN2yz62vuwNqiW3WY=; b=SI+DLPHA3APAzXVaq3KtlN4Sdmi2LfGcxkafg8Ja6XAeWCSSRJSBVPUtcyKSnOXDv5 C5vLUTY2QGWi2iPf1Bt96MpUvsQha609bzRbUlcKG3tu4M97TdlHLgbr+j0PDoOTyrRm B0eW7+GNIq9ehdCcw0P/Jo/NyKPAqWWi+2JMWzDxjmXfIDAYdwieE6Wx5eu1/BqCdZLK 4p7sTkN+T8d5rZ0jKXJtM083Zvs+wasQLQZJcsejHTnlceOzl7S7+fFyZ2/HFS/iVi8r HDgzBcXBO6Fn2Kwf6SDytXTAXLOrUoBvO7volt0NdWnAeFo80DoXLiZvXKSAb1z25CIP 70jA== X-Gm-Message-State: AOJu0YwasE9c2eh9LI1zp0jXlIv+UXGyCGRpX0GjTLWB++j31V8Xe6Xo 1a6ziKqLbv9E3acEi9pj+2b88XpndMJqZkKj6vCEUEkPILjBJUB5vgW5H7PzqddinartFl3r9bc htZGagBQQj2H0wU2B1Uprhu4qPwE7wRrVeI47MSO9qmf2IvEz X-Received: by 2002:a17:90a:8e82:b0:263:1f1c:ef4d with SMTP id f2-20020a17090a8e8200b002631f1cef4dmr13713335pjo.10.1696928761799; Tue, 10 Oct 2023 02:06:01 -0700 (PDT) X-Google-Smtp-Source: AGHT+IF6QTnH9rLmCfIQxlHg6WMucaqVzYs9Ac+HPBHb6/xBFPScKYnKgWlO9D0TaeYclATIuuWQwZVLNk1ksdDSGnk= X-Received: by 2002:a17:90a:8e82:b0:263:1f1c:ef4d with SMTP id f2-20020a17090a8e8200b002631f1cef4dmr13713326pjo.10.1696928761522; Tue, 10 Oct 2023 02:06:01 -0700 (PDT) MIME-Version: 1.0 References: <20231002125051.29911-1-tdevries@suse.de> <20231002125051.29911-5-tdevries@suse.de> In-Reply-To: <20231002125051.29911-5-tdevries@suse.de> From: Alexandra Petlanova Hajkova Date: Tue, 10 Oct 2023 11:05:50 +0200 Message-ID: Subject: Re: [PATCH 04/13] [gdb/symtab] Add parent_map::dump To: Tom de Vries Cc: gdb-patches@sourceware.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: multipart/alternative; boundary="0000000000000a462806075904e9" X-Spam-Status: No, score=-3.9 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,HTML_MESSAGE,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --0000000000000a462806075904e9 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, Oct 2, 2023 at 2:52=E2=80=AFPM Tom de Vries via Gdb-patches < gdb-patches@sourceware.org> wrote: > When dumping m_die_range_map using: > ... > addrmap_dump (&m_die_range_map, gdb_stdlog, nullptr); > ... > I get: > ... > 0x00000000000000d4 0x355e600 > 0x00000000000000de 0x355e630 > 0x00000000000000f5 0x355e600 > 0x0000000000000101 0x0 > 0x00000000000001c2 0x355e7b0 > 0x00000000000001cc 0x355e7e0 > 0x00000000000001e3 0x355e7b0 > 0x00000000000001ef 0x0 > ... > which doesn't make it clear which cooked_die_entries the values refer to. > > Add a function parent_map::dump that passes an annotation function > to addrmap_dump such that we have instead: > ... > 0x00000000000000d4 0x360d300 (0xd3) > 0x00000000000000de 0x360d330 (0xdd) > 0x00000000000000f5 0x360d300 (0xd3) > 0x0000000000000101 0x0 > 0x00000000000001c2 0x360d4b0 (0x1c1) > 0x00000000000001cc 0x360d4e0 (0x1cb) > 0x00000000000001e3 0x360d4b0 (0x1c1) > 0x00000000000001ef 0x0 > ... > > Tested on x86_64-linux. > --- > I think is a very useful cahnge. I can confirm this causes no regrissions > on ppc64le Fedora Rawhide. > --0000000000000a462806075904e9--